Fix SCTP failure with ipv6 source address routing
Subsystems (3)
PATCH 1/1 Fix SCTP failure with ipv6 source address routing
From: Weixing Shi <[email protected]>
Given the below test case, using source address routing, SCTP does not work.
Node-A:
1)ifconfig eth0 inet6 add 2001:1::1/64 2)ip -6 rule add from 2001:1::1 table 100 pref 100 3)ip -6 route add 2001:2::1 dev eth0 table 100 4)sctp_darn -H 2001:1::1 -P 250 -l &
Node-B:
1)ifconfig eth0 inet6 add 2001:2::1/64
2)ip -6 rule add from 2001:2::1 table 100 pref 100 3)ip -6 route add 2001:1::1 dev eth0 table 100 4)sctp_darn -H 2001:2::1 -P 250 -h 2001:1::1 -p 250 -s
Root cause:
Node-A and Node-B use source address routing, and in the begining, the source address will be NULL. So SCTP will search the routing table by the destination address (because it is using the source address routing table), and hence the resulting dst_entry will be NULL.
Solution:
After SCTP gets the correct source address, then we search for dst_entry again, and then we will get the correct value.
--- net/sctp/transport.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)
net/sctp/transport.c +9 -2
@@ -295,9 +295,16 @@ void sctp_transport_route(struct sctp_transport *transport,if (saddr)memcpy (&transport->saddr, saddr,sizeof (union sctp_addr )); -else +else { af->get_saddr (opt, asoc, dst, daddr, &transport->saddr); - +/* When using source address routing, since dst was +* looked up prior to filling in the source address, dst +* needs to be looked up again to get the correct dst +*/ +if (dst) +dst_release (dst); + dst = af->get_dst (asoc, daddr, &transport->saddr); + } transport->dst = dst;if ((transport->param_flags &SPP_PMTUD_DISABLE ) && transport->pathmtu) {return ;
Signature · 1 line
1.6.5.2
Quoted 24 lines · Paul Gortmaker
From: Weixing Shi <[email protected]>
Given the below test case, using source address routing, SCTP does not work.
Node-A:
1)ifconfig eth0 inet6 add 2001:1::1/64 2)ip -6 rule add from 2001:1::1 table 100 pref 100 3)ip -6 route add 2001:2::1 dev eth0 table 100 4)sctp_darn -H 2001:1::1 -P 250 -l &Node-B:
1)ifconfig eth0 inet6 add 2001:2::1/64
2)ip -6 rule add from 2001:2::1 table 100 pref 100 3)ip -6 route add 2001:1::1 dev eth0 table 100 4)sctp_darn -H 2001:2::1 -P 250 -h 2001:1::1 -p 250 -sRoot cause:
Node-A and Node-B use source address routing, and in the begining, the source address will be NULL. So SCTP will search the routing table by the destination address (because it is using the source address routing table), and hence the resultingdst_entrywill be NULL.
Quoted 3 lines
Solution:
After SCTP gets the correct source address, then we search fordst_entryagain, and then we will get the correct value.
The problem here is that ipv6 route lookup code in sctp doesn't bother searching for the source address, unlike the v4 route lookup code.
Compare sctp_v4_get_dst() and sctp_v6_get_dst. The v4 version bends over backwards trying to get the correct route, while the v6 version simple does a single lookup and returns the result.
The v6 route lookup code needs to be fixed to take into account the bound address list.
-vlad
Quoted 30 lines
Signed-off-by Weixing Shi <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>--- net/sctp/transport.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)net/sctp/transport.c +9
-2@@ -295,9 +295,16 @@ void sctp_transport_route(struct sctp_transport *transport,if (saddr)memcpy (&transport->saddr, saddr,sizeof (union sctp_addr )); -else +else { af->get_saddr (opt, asoc, dst, daddr, &transport->saddr); - +/* When using source address routing, since dst was +* looked up prior to filling in the source address, dst +* needs to be looked up again to get the correct dst +*/ +if (dst) +dst_release (dst); + dst = af->get_dst (asoc, daddr, &transport->saddr); + } transport->dst = dst;if ((transport->param_flags &SPP_PMTUD_DISABLE ) && transport->pathmtu) {return ;
Quoted 34 lines · Vlad Yasevich
Quoted 24 lines · Paul Gortmaker
From: Weixing Shi<[email protected]>
Given the below test case, using source address routing, SCTP does not work.
Node-A:
1)ifconfig eth0 inet6 add 2001:1::1/64 2)ip -6 rule add from 2001:1::1 table 100 pref 100 3)ip -6 route add 2001:2::1 dev eth0 table 100 4)sctp_darn -H 2001:1::1 -P 250 -l&Node-B:
1)ifconfig eth0 inet6 add 2001:2::1/64 2)ip -6 rule add from 2001:2::1 table 100 pref 100 3)ip -6 route add 2001:1::1 dev eth0 table 100 4)sctp_darn -H 2001:2::1 -P 250 -h 2001:1::1 -p 250 -sRoot cause:
Node-A and Node-B use source address routing, and in the begining, the source address will be NULL. So SCTP will search the routing table by the destination address (because it is using the source address routing table), and hence the resultingdst_entrywill be NULL.Quoted 3 lines
Solution:
After SCTP gets the correct source address, then we search fordst_entryagain, and then we will get the correct value.The problem here is that ipv6 route lookup code in sctp doesn't bother searching for the source address, unlike the v4 route lookup code.
Quoted 6 lines
Compare
sctp_v4_get_dst()andsctp_v6_get_dst. The v4 version bends over backwards trying to get the correct route, while the v6 version simple does a single lookup and returns the result.The v6 route lookup code needs to be fixed to take into account the bound address list.
Thanks for the feedback -- we'll take a look and see if we can fix it as per your recommendation and re-test.
Paul.
Quoted 33 lines
-vlad
Quoted 30 lines
Signed-off-by Weixing Shi<[email protected]>Signed-off-by Paul Gortmaker<[email protected]>--- net/sctp/transport.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)net/sctp/transport.c +9
-2@@ -295,9 +295,16 @@ void sctp_transport_route(struct sctp_transport *transport,if (saddr)memcpy (&transport->saddr, saddr,sizeof (union sctp_addr )); -else +else { af->get_saddr (opt, asoc, dst, daddr,&transport->saddr); - +/* When using source address routing, since dst was +* looked up prior to filling in the source address, dst +* needs to be looked up again to get the correct dst +*/ +if (dst) +dst_release (dst); + dst = af->get_dst (asoc, daddr,&transport->saddr); + } transport->dst = dst;if ((transport->param_flags&SPP_PMTUD_DISABLE )&& transport->pathmtu) {return ;