Skip to contentSkip to conversation

FAT: cosmetic: Remove useless assignment

PATCH Superseded Benoît Thébaudeau 2 participants 3 messages Jul 19, 2012 – Sep 2, 2012 VFAT/FAT/msdos filesystem

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Benoît Thébaudeau

author
#0 lore raw

PATCH 2/7 FAT: cosmetic: Remove useless assignment

fatlength is not used after this assignment, so it is useless and can be removed.

Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Wolfgang Denk <[email protected]>
---
 .../fs/fat/fat.c                                   |    1 -
 1 file changed, 1 deletion(-)
fs/fat/fat.c +0 -1
index f6fd457..e628cf7 100644
@@ -210,7 +210,6 @@ static __u32 get_fatent (fsdata *mydata, __u32 entry)
 		if (startblock + getsize > fatlength)
 			getsize = fatlength - startblock;
 
-		fatlength *= mydata->sect_size;	/* We want it in bytes now */
 		startblock += mydata->fat_sect;	/* Offset from start of disk */
 
 		if (disk_read(startblock, getsize, bufptr) < 0) {
author
#1 lore raw

PATCH v2 3/8 FAT: cosmetic: Remove useless assignment

fatlength is not used after this assignment, so it is useless and can be removed.

Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Wolfgang Denk <[email protected]>

---
Changes for v2:
- Patch renumbering because of the new v2 1/8.
- Possible code style changes due to the new v2 1/8.

 .../fs/fat/fat.c                                   |    1 -
 1 file changed, 1 deletion(-)
fs/fat/fat.c +0 -1
index 87a1623..48c8844 100644
@@ -210,7 +210,6 @@ static __u32 get_fatent(fsdata *mydata, __u32 entry)
 		if (startblock + getsize > fatlength)
 			getsize = fatlength - startblock;
 
-		fatlength *= mydata->sect_size;	/* We want it in bytes now */
 		startblock += mydata->fat_sect;	/* Offset from start of disk */
 
 		if (disk_read(startblock, getsize, bufptr) < 0) {
Applied
#2 lore raw

PATCH v2 3/8 FAT: cosmetic: Remove useless assignment

Dear Beno?t Th?baudeau,

Quoted 5 lines · In message <[email protected]> you…

fatlength is not used after this assignment, so it is useless and can be removed.

Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Wolfgang Denk <[email protected]>
Quoted 7 lines

---
Changes for v2:
- Patch renumbering because of the new v2 1/8.
- Possible code style changes due to the new v2 1/8.

 .../fs/fat/fat.c                                   |    1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The good Christian should beware of mathematicians and all those who
make empty prophecies. The danger already exists that  mathematicians
have  made a covenant with the devil to darken the spirit and confine
man in the bonds of Hell."                          - Saint Augustine