S3C: DMA API: Change argument type of s3c2410_dma_devconfig
Subsystems (3)
PATCH 2/7 S3C: DMA API: Change argument type of s3c2410_dma_devconfig
From: Jassi Brar <[email protected]>
All other functions have the channel argument of type 'unsigned int' the s3c2410_dma_devconfig also accept the same value as argument but treat it as type 'int'. Remove this anomaly by make it 'unsigned int'.
Signed-off-by Jassi Brar <[email protected]>
--- arch/arm/mach-s3c64xx/dma.c | 2 +- arch/arm/plat-s3c24xx/dma.c | 2 +- arch/arm/plat-samsung/include/plat/dma.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-s3c64xx/dma.c +1 -1
@@ -413,7 +413,7 @@ err_buff:EXPORT_SYMBOL (s3c2410_dma_enqueue); -int s3c2410_dma_devconfig (int channel, +int s3c2410_dma_devconfig (unsigned int channel,enum s3c2410_dmasrc source,unsigned long devaddr) {
arch/arm/plat-s3c24xx/dma.c +1 -1
@@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config);* devaddr: physical address of the source */ -int s3c2410_dma_devconfig (int channel, +int s3c2410_dma_devconfig (unsigned int channel,enum s3c2410_dmasrc source,unsigned long devaddr) {
arch/arm/plat-samsung/include/plat/dma.h +2 -2
@@ -110,8 +110,8 @@ extern int s3c2410_dma_config(unsigned int channel, int xferunit);* configure the device we're talking to */ -extern int s3c2410_dma_devconfig (int channel,enum s3c2410_dmasrc source, -unsigned long devaddr); +extern int s3c2410_dma_devconfig (unsigned int channel, +enum s3c2410_dmasrc source,unsigned long devaddr);/* s3c2410_dma_getposition *
Signature · 1 line
1.6.2.5
PATCH 2/7 S3C: DMA API: Change argument type of s3c2410_dma_devconfig
Quoted 5 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
All other functions have the channel argument of type 'unsigned int' the
s3c2410_dma_devconfigalso accept the same value as argument but treat it as type 'int'. Remove this anomaly by make it 'unsigned int'.
Looks fine.
Quoted 51 lines
Signed-off-by Jassi Brar <[email protected]>--- arch/arm/mach-s3c64xx/dma.c | 2 +- arch/arm/plat-s3c24xx/dma.c | 2 +- arch/arm/plat-samsung/include/plat/dma.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)arch/arm/mach-s3c64xx/dma.c +1
-1@@ -413,7 +413,7 @@ err_buff:EXPORT_SYMBOL (s3c2410_dma_enqueue); -int s3c2410_dma_devconfig (int channel, +int s3c2410_dma_devconfig (unsigned int channel,enum s3c2410_dmasrc source,unsigned long devaddr) {arch/arm/plat-s3c24xx/dma.c +1
-1@@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config);* devaddr: physical address of the source */ -int s3c2410_dma_devconfig (int channel, +int s3c2410_dma_devconfig (unsigned int channel,enum s3c2410_dmasrc source,unsigned long devaddr) {arch/arm/plat-samsung/include/plat/dma.h +2
-2@@ -110,8 +110,8 @@ extern int s3c2410_dma_config(unsigned int channel, int xferunit);* configure the device we're talking to */ -extern int s3c2410_dma_devconfig (int channel,enum s3c2410_dmasrc source, -unsigned long devaddr); +extern int s3c2410_dma_devconfig (unsigned int channel, +enum s3c2410_dmasrc source,unsigned long devaddr);/* s3c2410_dma_getposition * Signature · 1 line
1.6.2.5
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.