Skip to contentSkip to conversation

staging:iio:lis3l02dq - incorrect ws used in container of call.

PATCH Applied Jonathan Cameron 2 participants 2 messages Mar 11, 2010 – Apr 23, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:iio:lis3l02dq - incorrect ws used in container of call.

---
The word oops comes to mind. Original patch to merge the two work queues in here (prior to Greg taking them into staging) changed the top half to only use one of them and the bottom half to assume it was the other.

Currently causes a NULL pointer dereference if you enable any of the events on an lis3l02dq. Just goes to show I need a few more regression tests.

 drivers/staging/iio/accel/lis3l02dq_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/iio/accel/lis3l02dq_core.c +1 -1
index f008837..56ab337 100644
@@ -617,7 +617,7 @@ static int lis3l02dq_thresh_handler_th(struct iio_dev *dev_info,
 static void lis3l02dq_thresh_handler_bh_no_check(struct work_struct *work_s)
 {
 	struct iio_work_cont *wc
-		= container_of(work_s, struct iio_work_cont, ws_nocheck);
+		= container_of(work_s, struct iio_work_cont, ws);
 	struct lis3l02dq_state *st = wc->st;
 	u8 t;
 
Signature · 1 line
1.6.4.4
#1 lore raw

patch staging-iio-lis3l02dq-incorrect-ws-used-in-container-of-call.patch added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

Subject: staging: iio: lis3l02dq - incorrect ws used in container of =
call.

to my gregkh-2.6 tree. Its filename is

staging-iio-lis3l02dq-incorrect-ws-used-in-container-of-call.patch

This tree can be found at=20
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patch=
es/

Quoted 1 line
Quoted 1 line

From [email protected] Thu Apr 22 16:37:59 2010

From: Jonathan Cameron <[email protected]>
Date: Thu, 11 Mar 2010 17:29:48 +0000
Subject: staging: iio: lis3l02dq - incorrect ws used in container of call= .
To: Greg KH <[email protected]>, "[email protected]" <linux-iio@vge= r.kernel.org>
Message-ID: <[email protected]>

The word oops comes to mind. Original patch to merge the two work queues in here (prior to Greg taking them into staging) changed the top half to only use one of them and the bottom half to assume it was the other.

Currently causes a NULL pointer dereference if you enable any of the even= ts
on an lis3l02dq. Just goes to show I need a few more regression tests.

---
 drivers/staging/iio/accel/lis3l02dq_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/lis3l02dq_core.c +0 -0
@@ -618,7 +618,7 @@ static int lis3l02dq_thresh_handler_th(s
 static void lis3l02dq_thresh_handler_bh_no_check(struct work_struct *wor=

k_s)
{
struct iio_work_cont *wc
- =3D container_of(work_s, struct iio_work_cont, ws_nocheck);
+ =3D container_of(work_s, struct iio_work_cont, ws);
struct lis3l02dq_state *st =3D wc->st;
u8 t;
=20