Skip to contentSkip to conversation

Fix the RARP protocol ID

PATCH Applied Stefan Berger 2 participants 3 messages Apr 24, 2010 – May 3, 2010

lore
Share & tools
lore

Stefan Berger

author
#0 lore raw

PATCH 1/1 Fix the RARP protocol ID

The packet(s) sent out after migration are supposed to be RAPR type of packets. If they are supposed to go anywhere useful, the RAPR ethernet identifier needs to be fix.

Also see http://www.iana.org/assignments/ethernet-numbers for 0x8035 for RARP.

Signed-off-by Stefan Berger <[email protected]>
---
 savevm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
savevm.c +1 -1
Index: qemu-git/savevm.c
===================================================================
@@ -89,7 +89,7 @@ static BlockDriverState *bs_snapshots;
 #define SELF_ANNOUNCE_ROUNDS 5
 
 #ifndef ETH_P_RARP
-#define ETH_P_RARP 0x0835
+#define ETH_P_RARP 0x8035
 #endif
 #define ARP_HTYPE_ETH 0x0001
 #define ARP_PTYPE_IP 0x0800
author
#1 lore raw

[email protected] wrote on 04/24/2010 08:54:07 AM:

Quoted 6 lines

The packet(s) sent out after migration are supposed to be RAPR type of packets. If they are supposed to go anywhere useful, the RAPR ethernet identifier needs to be fix.

Also see http://www.iana.org/assignments/ethernet-numbers for 0x8035 for RARP.

Hi! It's probably not high on the agenda, but any reason why the created packet
looks like a RAPR packet and yet has the wrong ethernet protocol ID? If this
packet is sent to tell the local switch that the VM is now on a different

port, why not just send an ARP request packet asking for an IP address of 0.0.0.0 ?

Stefan

Quoted 23 lines
Signed-off-by Stefan Berger <[email protected]>
---
 savevm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: qemu-git/savevm.c
===================================================================

savevm.c +1 -1
@@ -89,7 +89,7 @@ static BlockDriverState *bs_snapshots;
 #define SELF_ANNOUNCE_ROUNDS 5
 
 #ifndef ETH_P_RARP
-#define ETH_P_RARP 0x0835
+#define ETH_P_RARP 0x8035
 #endif
 #define ARP_HTYPE_ETH 0x0001
 #define ARP_PTYPE_IP 0x0800
Applied
#2 lore raw
In reply to Stefan Berger
Quoted 9 lines · Stefan Berger

The packet(s) sent out after migration are supposed to be RAPR type of packets. If they are supposed to go anywhere useful, the RAPR ethernet identifier needs to be fix.

Also see http://www.iana.org/assignments/ethernet-numbers for 0x8035 for RARP.

Signed-off-by Stefan Berger<[email protected]>

Applied. Thanks.

Regards,

Anthony Liguori

Quoted 22 lines
---
  savevm.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: qemu-git/savevm.c
===================================================================

savevm.c +1 -1
@@ -89,7 +89,7 @@ static BlockDriverState *bs_snapshots;
  #define SELF_ANNOUNCE_ROUNDS 5
 
  #ifndef ETH_P_RARP
-#define ETH_P_RARP 0x0835
+#define ETH_P_RARP 0x8035
  #endif
  #define ARP_HTYPE_ETH 0x0001
  #define ARP_PTYPE_IP 0x0800