Simtec patches for new Kirkwood based boad
cover Simtec patches for new Kirkwood based boad
A fix for the RTC driver, updates for using RnB with the Orion NAND driver and the machine definition for the DTCOMMOD.
Is there anytone currently picking up mach-kirkwood patches or should this go to Russell's patch tracker?
Signature · 3 lines
Ben (ben at fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'
PATCH 1/4 orion/kirkwood: add RnB line support to orion mtd driver
An embedded and charset-unspecified text was scrubbed...
Name: slinux/arm/kirkwood/mtd-ready-not-busy-support.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100420/33783abf/attachment.el>
PATCH 1/4 orion/kirkwood: add RnB line support to orion mtd driver
Quoted 6 lines · Ben Dooks
plain text document attachment (slinux)
Add support for a board to register a callback to get the state of the RnB line if it has it attached.Signed-off-by Ben Dooks <[email protected]>Cc Linux MTD <[email protected]>
Added both to l2-mtd-2.6.git / dunno
Signature · 2 lines
Best Regards, Artem Bityutskiy (????? ????????)
PATCH 2/4 kirkwood: allow machines to register RnB callback
In reply to Ben DooksAn embedded and charset-unspecified text was scrubbed...
Name: slinux/arm/kirkwood/allow-mtd-ready-not-busy-registration.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100420/51029c0f/attachment.el>
PATCH 3/4 rtc-mv: Fix 12/24 hour error message
In reply to Ben DooksAn embedded and charset-unspecified text was scrubbed...
Name: slinux/arm/kirkwood/fix-rtc-error-message.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100420/5325fcab/attachment.el>
PATCH 4/4 ARM: kirkwood: Add Datong DTCOMMOD machine definition
In reply to Ben DooksAn embedded and charset-unspecified text was scrubbed...
Name: slinux/arm/kirkwood/dtcommod-board-support.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100420/9508a69f/attachment.el>
PATCH 4/4 ARM: kirkwood: Add Datong DTCOMMOD machine definition
Review
Quoted 7 lines · Ben Dooks
(quoted diff) +7
-0+static void __init dtcommod_init(void) +{ + kirkwood_init(); + kirkwood_mpp_conf(dtcommod_mpp_config); + + kirkwood_uart0_init(); + /* need to init nand, but we have RnB line */
What's the purpose of that comment there?
Quoted 12 lines
(quoted diff) +12
-0+ + kirkwood_ge00_init(&dtcommod_ge0_data); + kirkwood_ge01_init(&dtcommod_ge1_data); + kirkwood_sata_init(&dtcommod_sata_data); + kirkwood_sdio_init(&dtcommod_mvsdio_data); + + i2c_register_board_info(0, dtcommod_i2c_devs, + ARRAY_SIZE(dtcommod_i2c_devs)); + + gpio_request(GPIO_RNB, "NAND RnB"); + gpio_direction_input(GPIO_RNB); +
Review
Quoted 10 lines
(quoted diff) +10
-0+ gpio_request(GPIO_SDPWR, "SD Power Enable"); + gpio_direction_output(GPIO_SDPWR, 0); + + kirkwood_nand_init_rnb(ARRAY_AND_SIZE(dtcommod_nand_parts), + dtcommod_nand_rnb); + + /* add the i2c bus info */ + + kirkwood_ehci_init(); + kirkwood_i2c_init();
And isn't that comment misplaced too?
Review
Quoted 9 lines
(quoted diff) +9
-0+} + +static int __init dtcommod_pci_init(void) +{ + if (machine_is_dtcommod()) + kirkwood_pcie_init(); + + return 0; +}
You do have a PCIe slot/device, right?
Other than that, ACK.
Nicolas
cover Simtec patches for new Kirkwood based boad
In reply to Ben DooksQuoted 2 lines · Ben Dooks
Is there anytone currently picking up mach-kirkwood patches or should this go to Russell's patch tracker?
I usually do, and push them to git://git.marvell.com/orion.
But I don't mind if you want to push them to the patch system instead.
Nicolas