Skip to contentSkip to conversation

Staging: adis16255: Fix compile error

PATCH In review Javier Martinez Canillas 3 participants 3 messages May 2, 2010 – May 4, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: adis16255: Fix compile error

This patch solves a compilation error in today linux-next tree.

The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.

---
 drivers/staging/adis16255/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/adis16255/Makefile +1 -1
index 3f8b1f0..dc4debc 100644
@@ -1 +1 @@
-obj-$(CONFIG_ADIS16255) +�is16255.o
+obj-$(CONFIG_ADIS16255)                += adis1625.o
Signature · 1 line
1.7.0.4
#1 lore raw

The main work of this driver is providing sys node for users to access data. Which directory will this driver be placed after moving from staging? It's better to rewrite it based on IIO. Otherwise, the architecture for this kind of driver will be difficult to be consistent.
-barry

Quoted 29 lines · Javier Martinez Canillas

This patch solves a compilation error in today linux-next tree.

The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.

---
 drivers/staging/adis16255/Makefile |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/adis16255/Makefile +1 -2
index 3f8b1f0..dc4debc 100644
@@ -1 +1 @@
-obj-$(CONFIG_ADIS16255) +�is16255.o
+obj-$(CONFIG_ADIS16255)                += adis1625.o
--

1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#2 lore raw

Hi.

2010/5/4 Barry Song <[email protected]>:

Quoted 5 lines

The main work of this driver is providing sys node for users to access data. Which directory will this driver be placed after moving from staging? It's better to rewrite it based on IIO. Otherwise, the architecture for this kind of driver will be difficult to be consistent.

It's not yet decided to which subsystem the driver will be merged to. But sysfs entries go to /sys/bus/spi/drivers/ so there shouldn't be an issue if it later moves to IIO.
(what I want to do when IIO gets out of staging).

Regards,
Matthias Brugger

Quoted 2 lines

-barry

Signature · 1 line
motzblog.wordpress.com