lockdep: allow user to disable CONFIG_TRACE_IRQFLAGS
Subsystems (2)
PATCH 2/2 lockdep: allow user to disable CONFIG_TRACE_IRQFLAGS
From: Ming Lei <[email protected]>
There is still the lost irq-on tracing issue on ARM, (see http://marc.info/?l=linux-arm-kernel&m=126047420005553&w=2)
which may disable lockdep after kernel boot, seems no good solution for the issue up to now.
The patch exports the config option of CONFIG_TRACE_IRQFLAGS and allows user to disable it for support of checking circular dead lock only if irq flags tracing can't work correctly always.
--- lib/Kconfig.debug | 3 +++ lib/locking-selftest.c | 2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)
lib/Kconfig.debug +3 -0
@@ -550,11 +550,14 @@ config DEBUG_LOCKDEP of more runtime overhead. config TRACE_IRQFLAGS + bool "Lock prove: IRQ flags tracing" depends on DEBUG_KERNEL bool default y depends on TRACE_IRQFLAGS_SUPPORT depends on PROVE_LOCKING + help + If you say Y here, IRQ flags will be traced to prove locking. config DEBUG_SPINLOCK_SLEEP bool "Spinlock debugging: sleep-inside-spinlock checking"
lib/locking-selftest.c +2 -0
@@ -1176,6 +1176,7 @@ void locking_selftest(void)printk (" --------------------------------------------------------------------------\n" ); +#ifdef CONFIG_TRACE_IRQFLAGS /* * irq-context testcases: */
@@ -1188,6 +1189,7 @@ void locking_selftest(void)DO_TESTCASE_6x2 ("irq read-recursion" , irq_read_recursion);// DO_TESTCASE_6x2B("irq read-recursion #2", irq_read_recursion2); +#endif if (unexpected_testcase_failures) {printk ("-----------------------------------------------------------------\n" );
Signature · 1 line
1.6.2.5
2010/5/5 <[email protected]>:
Quoted 60 lines
From: Ming Lei <[email protected]>
There is still the lost irq-on tracing issue on ARM, (see http://marc.info/?l=linux-arm-kernel&m=126047420005553&w=2)
which may disable lockdep after kernel boot, seems no good solution for the issue up to now.The patch exports the config option of
CONFIG_TRACE_IRQFLAGSand allows user to disable it for support of checking circular dead lock only if irq flags tracing can't work correctly always.Signed-off-by Ming Lei <[email protected]>---
?lib/Kconfig.debug ? ? ?| ? ?3 +++
?lib/locking-selftest.c | ? ?2 ++
?2 files changed, 5 insertions(+), 0 deletions(-)lib/Kconfig.debug +0
-0@@ -550,11 +550,14 @@ config DEBUG_LOCKDEP? ? ? ? ?of more runtime overhead.
?config
TRACE_IRQFLAGS
+ ? ? ? bool "Lock prove: IRQ flags tracing"
? ? ? ?depends onDEBUG_KERNEL
? ? ? ?bool
? ? ? ?default y
? ? ? ?depends onTRACE_IRQFLAGS_SUPPORT
? ? ? ?depends onPROVE_LOCKING
+ ? ? ? help
+ ? ? ? ? If you say Y here, IRQ flags will be traced to prove locking.?config
DEBUG_SPINLOCK_SLEEP
? ? ? ?bool "Spinlock debugging: sleep-inside-spinlock checking"lib/locking-selftest.c +1
-0@@ -1176,6 +1176,7 @@ void locking_selftest(void) ? ? ? ?printk(" ?--------------------------------------------------------------------------\n"); +#ifdef CONFIG_TRACE_IRQFLAGS ? ? ? ?/*
? ? ? ? * irq-context testcases:
? ? ? ? */lib/locking-selftest.c +1
-1@@ -1188,6 +1189,7 @@ void locking_selftest(void) ? ? ? ?DO_TESTCASE_6x2("irq read-recursion", irq_read_recursion); ?// ? ? DO_TESTCASE_6x2B("irq read-recursion #2", irq_read_recursion2); +#endif ? ? ? ?if (unexpected_testcase_failures) { ? ? ? ? ? ? ? ?printk("-----------------------------------------------------------------\n"); --1.6.2.5
Signature · 1 line
Lei Ming
Peter Zijlstra
maintainerQuoted 4 lines · On Wed, 2010-05-05 at 00:02 +0800, [email protected] wrote:
There is still the lost irq-on tracing issue on ARM, (see http://marc.info/?l=linux-arm-kernel&m=126047420005553&w=2)
which may disable lockdep after kernel boot, seems no good solution for the issue up to now.
Well, do like x86 does in entry.S call into lockdep right before returning to userspace.