scsi: fix cxgb3i build errors

PATCH In review Randy Dunlap 2 participants 3 messages May 4, 2010 SCSI

lore

Share & tools

lore

Randy Dunlap

author

2010-05-04 17:30 UTC #0 lore raw

PATCH 1/1 scsi: fix cxgb3i build errors

From: Randy Dunlap <[email protected]>

cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET.
This change fixes multiple build (link) errors:

ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>

Cc Karen Xie <[email protected]>

---
 drivers/scsi/cxgb3i/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/cxgb3i/Kconfig +1 -1

@@ -1,6 +1,6 @@
 config SCSI_CXGB3_ISCSI
 	tristate "Chelsio S3xx iSCSI support"
-	depends on CHELSIO_T3_DEPENDS
+	depends on CHELSIO_T3_DEPENDS && NET
 	select CHELSIO_T3
 	select SCSI_ISCSI_ATTRS
 	---help---

James Bottomley

2010-05-04 17:36 UTC #1 lore raw

Quoted 25 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>
cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET.
This change fixes multiple build (link) errors:
ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
Signed-off-by Randy Dunlap <[email protected]>
Cc Karen Xie <[email protected]>
---
 drivers/scsi/cxgb3i/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/cxgb3i/Kconfig line 3

Quoted 4 lines

drivers/scsi/cxgb3i/Kconfig +1 -1

@@ -1,6 +1,6 @@
 config SCSI_CXGB3_ISCSI
 	tristate "Chelsio S3xx iSCSI support"
-	depends on CHELSIO_T3_DEPENDS
+	depends on CHELSIO_T3_DEPENDS && NET

Something's seriously wrong here.

CHELSIO_T3_DEPENDS is supposed to be the rollup for all the dependencies. It's actually defined as this:

config CHELSIO_T3_DEPENDS

	tristate
	depends on PCI && INET
	default y

INET is the tcp/ip stack ... so how did you build a kernel that has NET=n and INET=y (it's guarded by an #if NET in the Kconfig file)?

James

Randy Dunlap

author

2010-05-04 21:54 UTC #2 lore raw

Quoted 36 lines · James Bottomley

Quoted 25 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET.
This change fixes multiple build (link) errors:
ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
Signed-off-by Randy Dunlap <[email protected]>
Cc Karen Xie <[email protected]>
---
 drivers/scsi/cxgb3i/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/cxgb3i/Kconfig line 3
Quoted 4 lines
drivers/scsi/cxgb3i/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config SCSI_CXGB3_ISCSI
 	tristate "Chelsio S3xx iSCSI support"
-	depends on CHELSIO_T3_DEPENDS
+	depends on CHELSIO_T3_DEPENDS && NET
Something's seriously wrong here.
CHELSIO_T3_DEPENDS is supposed to be the rollup for all the dependencies. It's actually defined as this:

Quoted 7 lines

config CHELSIO_T3_DEPENDS
	tristate
	depends on PCI && INET
	default y
INET is the tcp/ip stack ... so how did you build a kernel that has NET=n and INET=y (it's guarded by an #if NET in the Kconfig file)?

Hm, I managed to do that somehow, but I didn't save the Kconfig file and I can't make it happen again, so just drop this patch. Thanks.

Signature · 2 lines

~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***