Skip to contentSkip to conversation

Add clocksource_register_hz/khz interface

PATCH In review John Stultz 2 participants 3 messages May 6, 2010 – May 7, 2010 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add clocksource_register_hz/khz interface

Hey Thomas,
I updated the patch docs and made the calls EXPORT_SYMBOL_GPL.
However the need for both khz and hz is due to high freq clocksources like the TSC who's cycles/sec are close to the upper bound of a u32.

Let me know if you (or anyone else) have any further thoughts on the interface, as again, it would be nice to have it ready for 2.6.35 so the per-arch conversions can be pushed.

thanks
-john

How to pick good mult/shif pairs has always been difficult to describe to folks writing clocksource drivers, since it requires careful tradeoffs in adjustment accuracy vs overflow limits.

Now, with the clocks_calc_mult_shift function, its much easier. However, not many clocksources have converted to using that function, and there is still the issue of the max interval length assumption being made by each clocksource driver independently.

So this patch simplifies the registration process by having clocksources be registered with a hz/khz value and the the registration function taking care of setting mult/shift.

This should take most of the confusion out of writing a clocksource driver.

Additionally it also keeps the shift size tradeoff (more accuracy vs longer possible nohz times) centralized so the timekeeping core can keep track of the assumptions being made.

CC Thomas Gleixner <[email protected]>
---
 include/linux/clocksource.h |    3 ++
 kernel/time/clocksource.c   |   72 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+), 0 deletions(-)
include/linux/clocksource.h +3 -0
index 4bca8b6..1b0a5e0 100644
@@ -274,6 +274,9 @@ static inline s64 clocksource_cyc2ns(cycle_t cycles, u32 mult, u32 shift)
 
 
 /* used to install a new clocksource */
+
+extern int clocksource_register_hz(struct clocksource*, u32);
+extern int clocksource_register_khz(struct clocksource*, u32);
 extern int clocksource_register(struct clocksource*);
 extern void clocksource_unregister(struct clocksource*);
 extern void clocksource_touch_watchdog(void);
kernel/time/clocksource.c +72 -0

78 lines not on this page · raw message

Signature · 1 line
1.6.0.4
#1 lore raw
Quoted 4 lines · John Stultz

Hey Thomas,
I updated the patch docs and made the calls EXPORT_SYMBOL_GPL.
However the need for both khz and hz is due to high freq clocksources like the TSC who's cycles/sec are close to the upper bound of a u32.

Come on. It's not that hard :)

int clocksource_register_freq(struct clocksource *cs, u32 scale, u32 freq)

{
	clocks_calc_mult_shift(&cs->mult, &cs->shift, freq,
			       NSEC_PER_SEC / scale, MAX_UPDATE_LENGTH * scale);

	....
}

static inline int clocksource_register_hz(struct clocksource *cs, u32 freq)

{
	clocksource_regiser_freq(cs, 1, freq);
}

static inline int clocksource_register_khz(struct clocksource *cs, u32 freq)

{
	clocksource_regiser_freq(cs, 1000, freq);
}

Thanks,

tglx

#2 lore raw
Quoted 8 lines · Thomas Gleixner
Quoted 4 lines · John Stultz

Hey Thomas,
I updated the patch docs and made the calls EXPORT_SYMBOL_GPL.
However the need for both khz and hz is due to high freq clocksources like the TSC who's cycles/sec are close to the upper bound of a u32.

Come on. It's not that hard :)

Oh... So your fine with having two interfaces, but just want the code redundancy removed between the two interfaces?

Ok, I misunderstood. That's no problem.

thanks
-john

Quoted 21 lines

int clocksource_register_freq(struct clocksource *cs, u32 scale, u32 freq)

{
	clocks_calc_mult_shift(&cs->mult, &cs->shift, freq,
			       NSEC_PER_SEC / scale, MAX_UPDATE_LENGTH * scale);

	....
}

static inline int clocksource_register_hz(struct clocksource *cs, u32 freq)

{
	clocksource_regiser_freq(cs, 1, freq);
}

static inline int clocksource_register_khz(struct clocksource *cs, u32 freq)

{
	clocksource_regiser_freq(cs, 1000, freq);
}

Thanks,

tglx