mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage
PATCH 1/1 mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage
In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]", mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.
This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.
--- drivers/regulator/mc13783-regulator.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0
b/drivers/regulator/mc13783-regulator.c
index ad036dd..4597d50 100644
drivers/regulator/mc13783-regulator.c +0 -0
@@ -440,8 +440,8 @@ static int
mc13783_fixed_regulator_set_voltage(struct regulator_dev *rdev,
dev_dbg(rdev_get_dev(rdev), "%s id: %d min_uV: %d max_uV: %d\n",
__func__, id, min_uV, max_uV);
- if (min_uV > mc13783_regulators[id].voltages[0] &&
- max_uV < mc13783_regulators[id].voltages[0])
+ if (min_uV >= mc13783_regulators[id].voltages[0] &&
+ max_uV <= mc13783_regulators[id].voltages[0])
return 0;
else
return -EINVAL;
@@ -649,6 +649,6 @@ static void __exit mc13783_regulator_exit(void)
module_exit(mc13783_regulator_exit);
MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Sascha Hauer <[email protected]"); +MODULE_AUTHOR("Sascha Hauer <[email protected]>");
MODULE_DESCRIPTION("Regulator Driver for Freescale MC13783 PMIC"); MODULE_ALIAS("platform:mc13783-regulator");
Signature · 1 line
1.5.4.3
Quoted 9 lines · Axel Lin
In the case of "
min_uV==max_uV== mc13783_regulators[id].voltages[0]",mc13783_fixed_regulator_set_voltageshould return 0 instead of-EINVAL.This patch also adds a missing ">" character for
MODULE_AUTHOR, a trivial fix.Signed-off-by Axel Lin <[email protected]>Cc Mark Brown <[email protected]>Cc Liam Girdwood <[email protected]>
Quoted 35 lines
--- drivers/regulator/mc13783-regulator.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/regulator/mc13783-regulator.c +2
-2@@ -440,8 +440,8 @@ static int mc13783_fixed_regulator_set_voltage(struct regulator_dev *rdev, dev_dbg(rdev_get_dev(rdev), "%s id: %d min_uV: %d max_uV: %d\n", __func__, id, min_uV, max_uV); -if (min_uV > mc13783_regulators[id].voltages[0 ] && - max_uV < mc13783_regulators[id].voltages[0 ]) +if (min_uV >= mc13783_regulators[id].voltages[0 ] && + max_uV <= mc13783_regulators[id].voltages[0 ])return 0 ;else drivers/regulator/mc13783-regulator.c +1
-1return -EINVAL ;@@ -649,6 +649,6 @@ static void __exit mc13783_regulator_exit(void)module_exit (mc13783_regulator_exit);MODULE_LICENSE ("GPL v2" ); -MODULE_AUTHOR ("Sascha Hauer <[email protected]" ); +MODULE_AUTHOR ("Sascha Hauer <[email protected]>" );MODULE_DESCRIPTION ("Regulator Driver for Freescale MC13783 PMIC" );MODULE_ALIAS ("platform:mc13783-regulator" );Signature · 1 line
1.5.4.3
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |