Skip to contentSkip to conversation

lmb: Make lmb_alloc_try_nid() fallback to LMB_ALLOC_ANYWHERE

PATCH In review Benjamin Herrenschmidt 1 participant 2 messages May 10, 2010 23 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#23 lore raw

PATCH 24/25 lmb: Make lmb_alloc_try_nid() fallback to LMB_ALLOC_ANYWHERE

lmb_alloc_nid() used to fallback to allocating anywhere by using lmb_alloc() as a fallback.

However, some of my previous patches limit lmb_alloc() to the region covered by LMB_ALLOC_ACCESSIBLE which is not quite what we want for lmb_alloc_try_nid().

So we fix it by explicitely using LMB_ALLOC_ANYWHERE.

Not that so far only sparc uses lmb_alloc_nid() and it hasn't been updated to clamp the accessible zone yet. Thus the temporary "breakage" should have no effect.

---
 lib/lmb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/lmb.c +1 -1
index fd98261..6c38c87 100644
@@ -531,7 +531,7 @@ phys_addr_t __init lmb_alloc_try_nid(phys_addr_t size, phys_addr_t align, int ni
 
 	if (res)
 		return res;
-	return lmb_alloc(size, align);
+	return lmb_alloc_base(size, align, LMB_ALLOC_ANYWHERE);
 }
 
 
Signature · 7 lines
1.6.3.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#24 lore raw

PATCH 25/25 lmb: Add debugfs files to dump the arrays content

---
 lib/lmb.c |   51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 51 insertions(+), 0 deletions(-)
lib/lmb.c +51 -0
index 6c38c87..1e11891 100644
@@ -16,6 +16,8 @@
 #include <linux/bitops.h>
 #include <linux/poison.h>
 #include <linux/pfn.h>
+#include <linux/debugfs.h>
+#include <linux/seq_file.h>
 #include <linux/lmb.h>
 
 struct lmb lmb;
@@ -696,3 +698,52 @@ static int __init early_lmb(char *p)
 }
 early_param("lmb", early_lmb);
 
+#ifdef CONFIG_DEBUG_FS
+
+static int lmb_debug_show(struct seq_file *m, void *private)
+{
+	struct lmb_type *type = m->private;
+	struct lmb_region *reg;
+	int i;
+
+	for (i = 0; i < type->cnt; i++) {
+		reg = &type->regions[i];
+		seq_printf(m, "%4d: ", i);
+		if (sizeof(phys_addr_t) == 4)
+			seq_printf(m, "0x%08lx..0x%08lx\n",
+				   (unsigned long)reg->base,
+				   (unsigned long)(reg->base + reg->size - 1));
+		else
+			seq_printf(m, "0x%016llx..0x%016llx\n",
+				   (unsigned long long)reg->base,
+				   (unsigned long long)(reg->base + reg->size - 1));
+
+	}
+	return 0;
+}
+
+static int lmb_debug_open(struct inode *inode, struct file *file)
+{
+	return single_open(file, lmb_debug_show, inode->i_private);
+}
+
+static const struct file_operations lmb_debug_fops = {
+	.open = lmb_debug_open,
+	.read = seq_read,
+	.llseek = seq_lseek,
+	.release = single_release,
+};
+
+static int __init lmb_init_debugfs(void)
+{
+	struct dentry *root = debugfs_create_dir("lmb", NULL);
+	if (!root)
+		return -ENXIO;
+	debugfs_create_file("memory", S_IRUGO, root, &lmb.memory, &lmb_debug_fops);
+	debugfs_create_file("reserved", S_IRUGO, root, &lmb.reserved, &lmb_debug_fops);
+	
+	return 0;
+}
+__initcall(lmb_init_debugfs);
+
+#endif /* CONFIG_DEBUG_FS */
Signature · 7 lines
1.6.3.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>