Skip to contentSkip to conversation

Fix UART clocks on 440SPe

PATCH In review Benjamin Herrenschmidt 3 participants 3 messages May 12, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix UART clocks on 440SPe

The code to fixup the serial ports on 440SPe uses the incorrect addresses for these. This fixes it.

---

I'm surprised nobody noticed, serial is pretty busted for me without that patch :-)

arch/powerpc/boot/4xx.c +3 -3
index 27db893..627de25 100644
@@ -544,9 +544,9 @@ void ibm440spe_fixup_clocks(unsigned int sys_clk,
 	unsigned int plb_clk = __ibm440eplike_fixup_clocks(sys_clk, tmr_clk, 1);
 
 	/* serial clocks beed fixup based on int/ext */
-	eplike_fixup_uart_clk(0, "/plb/opb/serial@10000200", ser_clk, plb_clk);
-	eplike_fixup_uart_clk(1, "/plb/opb/serial@10000300", ser_clk, plb_clk);
-	eplike_fixup_uart_clk(2, "/plb/opb/serial@10000600", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(0, "/plb/opb/serial@f0000200", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(1, "/plb/opb/serial@f0000300", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(2, "/plb/opb/serial@f0000600", ser_clk, plb_clk);
 }
 
 void ibm405gp_fixup_clocks(unsigned int sys_clk, unsigned int ser_clk)
#2 lore raw
In reply to Benjamin Herrenschmidt
Quoted 8 lines · Benjamin Herrenschmidt

The code to fixup the serial ports on 440SPe uses the incorrect addresses for these. This fixes it.

---

I'm surprised nobody noticed, serial is pretty busted for me without that patch :-)

Odd. I don't have a 440SPe, so no surprise there but I would have thought someone would notice. Though this is only needed if you are using an older U-Boot that needs cuImage, and I'm guessing Stefan runs u-boot.git on his boards ;)

arch/powerpc/boot/4xx.c void ibm440spe_fixup_clocks(unsigned int sys_clk, · line 546

Quoted 9 lines
arch/powerpc/boot/4xx.c +0 -0
index 27db893..627de25 100644
@@ -544,9 +544,9 @@ void ibm440spe_fixup_clocks(unsigned int sys_clk,
 	unsigned int plb_clk = __ibm440eplike_fixup_clocks(sys_clk, tmr_clk, 1);
 
 	/* serial clocks beed fixup based on int/ext */

You couldn't be bothered to fixup the typo? s/beed/need ;) I'll fix it when I bring this in.

Quoted 7 lines
arch/powerpc/boot/4xx.c +3 -3
-	eplike_fixup_uart_clk(0, "/plb/opb/serial@10000200", ser_clk, plb_clk);
-	eplike_fixup_uart_clk(1, "/plb/opb/serial@10000300", ser_clk, plb_clk);
-	eplike_fixup_uart_clk(2, "/plb/opb/serial@10000600", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(0, "/plb/opb/serial@f0000200", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(1, "/plb/opb/serial@f0000300", ser_clk, plb_clk);
+	eplike_fixup_uart_clk(2, "/plb/opb/serial@f0000600", ser_clk, plb_clk);
 }