Eliminate useless err variable
PATCH 1/1 Eliminate useless err variable
Hi,
This patch removes an unneeded "err" variable that is always returned as zero.
Regards,
Bob Peterson
Red Hat File Systems
--
fs/gfs2/meta_io.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
fs/gfs2/meta_io.c +1 -3
@@ -34,7 +34,6 @@static int gfs2_aspace_writepage (struct page *page,struct writeback_control *wbc) { -int err;struct buffer_head *bh, *head;int nr_underway =0 ; int write_op = (1 << BIO_RW_META) | ((wbc->sync_mode == WB_SYNC_ALL ?
@@ -86,11 +85,10 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb }while (bh != head);unlock_page (page); - err =0 ;if (nr_underway ==0 )end_page_writeback (page); -return err; +return 0 ; }const struct address_space_operations gfs2_meta_aops = {
PATCH 1/1 Eliminate useless err variable
Hi,
Now in the -nmw git tree. Thanks,
Steve.
Quoted 38 lines · Bob Peterson
Hi,
This patch removes an unneeded "err" variable that is always returned as zero.
Regards,
Bob Peterson
Red Hat File Systems
--fs/gfs2/meta_io.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)fs/gfs2/meta_io.c +1
-3@@ -34,7 +34,6 @@static int gfs2_aspace_writepage (struct page *page,struct writeback_control *wbc) { -int err;struct buffer_head *bh, *head;int nr_underway =0 ; int write_op = (1 << BIO_RW_META) | ((wbc->sync_mode == WB_SYNC_ALL ?@@ -86,11 +85,10 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb }while (bh != head);unlock_page (page); - err =0 ;if (nr_underway ==0 )end_page_writeback (page); -return err; +return 0 ; }const struct address_space_operations gfs2_meta_aops = {