Skip to contentSkip to conversation

HID: Removing/Renaming preprocessor macros for Roccat Kone

PATCH Applied Stefan Achatz 2 participants 2 messages May 12, 2010 – May 18, 2010

Subsystems (2)
HID Roccat drivers
lore
Share & tools
lore

Stefan Achatz

author maintainer
#0 lore raw

PATCH 1/5 HID: Removing/Renaming preprocessor macros for Roccat Kone

Quoted 1 line

From a50a004999d4bd2b9ae08f1298b1fc89ce9e1e12 Mon Sep 17 00:00:00 2001

From: Stefan Achatz <[email protected]>
Date: Sat, 8 May 2010 16:34:05 +0200
Subject: [PATCH 1/5] HID: Removing/Renaming preprocessor macros for Roccat Kone

Removed useless preprocessor macros and renamed remaining one to be more qualified.

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hid-roccat-kone.c |    8 ++++----
 drivers/hid/hid-roccat-kone.h |    5 +----
 2 files changed, 5 insertions(+), 8 deletions(-)
drivers/hid/hid-roccat-kone.c +4 -4
index 7b11784..d23d309 100644
@@ -630,7 +630,7 @@ static ssize_t kone_sysfs_set_startup_profile(struct device *dev,
 static ssize_t kone_sysfs_show_driver_version(struct device *dev,
 		struct device_attribute *attr, char *buf)
 {
-	return snprintf(buf, PAGE_SIZE, DRIVER_VERSION "\n");
+	return snprintf(buf, PAGE_SIZE, ROCCAT_KONE_DRIVER_VERSION "\n");
 }
 
 /*

@@ -1002,6 +1002,6 @@ static void kone_exit(void)
 module_init(kone_init);
 module_exit(kone_exit);
 
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_AUTHOR("Stefan Achatz");
+MODULE_DESCRIPTION("USB Roccat Kone driver");
+MODULE_LICENSE("GPL v2");
drivers/hid/hid-roccat-kone.h +1 -4
index ee6898c..99290ad 100644
@@ -14,10 +14,7 @@
 
 #include <linux/types.h>
 
-#define DRIVER_VERSION "v0.3.0"
-#define DRIVER_AUTHOR "Stefan Achatz"
-#define DRIVER_DESC "USB Roccat Kone driver"
-#define DRIVER_LICENSE "GPL v2"
+#define ROCCAT_KONE_DRIVER_VERSION "v0.3.1"
 
 #pragma pack(push)
 #pragma pack(1)
Signature · 1 line
1.6.6.1
#1 lore raw
Quoted 42 lines · Stefan Achatz
Quoted 1 line

From a50a004999d4bd2b9ae08f1298b1fc89ce9e1e12 Mon Sep 17 00:00:00 2001

From: Stefan Achatz <[email protected]>
Date: Sat, 8 May 2010 16:34:05 +0200
Subject: [PATCH 1/5] HID: Removing/Renaming preprocessor macros for Roccat Kone

Removed useless preprocessor macros and renamed remaining one to be more qualified.

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hid-roccat-kone.c |    8 ++++----
 drivers/hid/hid-roccat-kone.h |    5 +----
 2 files changed, 5 insertions(+), 8 deletions(-)
drivers/hid/hid-roccat-kone.c +4 -4
index 7b11784..d23d309 100644
@@ -630,7 +630,7 @@ static ssize_t kone_sysfs_set_startup_profile(struct device *dev,
 static ssize_t kone_sysfs_show_driver_version(struct device *dev,
 		struct device_attribute *attr, char *buf)
 {
-	return snprintf(buf, PAGE_SIZE, DRIVER_VERSION "\n");
+	return snprintf(buf, PAGE_SIZE, ROCCAT_KONE_DRIVER_VERSION "\n");
 }
 
 /*

@@ -1002,6 +1002,6 @@ static void kone_exit(void)
 module_init(kone_init);
 module_exit(kone_exit);
 
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_AUTHOR("Stefan Achatz");
+MODULE_DESCRIPTION("USB Roccat Kone driver");
+MODULE_LICENSE("GPL v2");
drivers/hid/hid-roccat-kone.h +0 -0
index ee6898c..99290ad 100644

drivers/hid/hid-roccat-kone.h line 17

Quoted 8 lines
drivers/hid/hid-roccat-kone.h +1 -4
@@ -14,10 +14,7 @@
 
 #include <linux/types.h>
 
-#define DRIVER_VERSION "v0.3.0"
-#define DRIVER_AUTHOR "Stefan Achatz"
-#define DRIVER_DESC "USB Roccat Kone driver"
-#define DRIVER_LICENSE "GPL v2"
+#define ROCCAT_KONE_DRIVER_VERSION "v0.3.1"

Why do we need this? git is much better tracking revisions than humans, who usually forget to update the defines anyway ...

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.