Skip to contentSkip to conversation

detour TTY driver

PATCH Applied Samo Pogacnik 6 participants 47 messages May 15, 2010 – Sep 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 detour TTY driver

Hi,

Here is the initial suggestion for a simple detour TTY driver, which provides the ability to write user messages through printk. This allows user output to be inlined with kernel output. Together with printk time-stamping enabled, a detailed boot sequence analyses is possible. Additionally, console logs could have been stored through the same mechanism as kernel messages and does not require the system logger to be started very/too soon.

regards, Samo

---

Documentation/devices.txt +1 -0
index 53d64d3..f889097 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/detour	Detour via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index e023682..4d21e2d 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config DETOUR_TTY
+	bool "TTY driver to detour user output via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/detour.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..b84db55 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_DETOUR_TTY)	+= dty.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/dty.c new file +137 -0

137 lines not on this page · raw message

#1 lore raw
Quoted 10 lines · On Sat, 15 May 2010 12:17:00 +0200 Samo Pogacnik wrote:

Hi,

Here is the initial suggestion for a simple detour TTY driver, which provides the ability to write user messages through printk. This allows user output to be inlined with kernel output. Together with printk time-stamping enabled, a detailed boot sequence analyses is possible. Additionally, console logs could have been stored through the same mechanism as kernel messages and does not require the system logger to be started very/too soon.

Hi again,

This version of patch provides the ability to initially redirect console to "detour TTY" (on driver initialization), if "detour" boot command line option is set.

best regards, Samo

p.s.
Randy, Alan: Would you be so kind to comment on usability and acceptability of this tty driver approach? Thanks.

---

Documentation/devices.txt +1 -0
index 53d64d3..f889097 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/detour	Detour via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
Documentation/kernel-parameters.txt +2 -0
index 839b21b..1fd9f09 100644
@@ -623,6 +623,8 @@ and is between 256 and 4096 characters. It is defined in the file
 			Defaults to the default architecture's huge page size
 			if not specified.
 
+	detour		[KNL] Initial console redirect via detour tty.
+
 	dhash_entries=	[KNL]
 			Set number of hash buckets for dentry cache.
 
drivers/char/Kconfig +15 -0
index 3141dd3..f81781d 100644
@@ -485,6 +485,21 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config DETOUR_TTY
+	bool "TTY driver to detour user output via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/detour. By setting boot command line option "detour",
+	  the console is initially redirected to detour TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..b84db55 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_DETOUR_TTY)	+= dty.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/dty.c new file +183 -0

183 lines not on this page · raw message

init/main.c +12 -0
index 5c85402..be9dee9 100644
@@ -263,6 +263,18 @@ static int __init loglevel(char *str)
 
 early_param("loglevel", loglevel);
 
+#ifdef CONFIG_DETOUR_TTY
+extern void set_console_detour(void);
+
+static int __init detour(char *str)
+{
+	set_console_detour();
+	return 0;
+}
+
+early_param("detour", detour);
+#endif
+
 /*
  * Unknown boot options get handed to init, unless they look like
  * unused parameters (modprobe will find them in /proc/cmdline).
#2 lore raw
Quoted 2 lines

Randy, Alan: Would you be so kind to comment on usability and acceptability of this tty driver approach? Thanks.

Not sure the naming is ideal (detour what where, simply calling it '/dev/ttyprintk' might be clearer - but this is detail

drivers/char/dty.c line 31

Quoted 5 lines
drivers/char/dty.c new file +5 -0
+void set_console_detour(void)
+{
+	console_detour = 1;
+}
+EXPORT_SYMBOL(set_console_detour);

module parameters can be set compiled in with modulename.option=foo so there are easier ways to do that.

Quoted 4 lines

+ * Our simple preformatting:
+ * - every cr is replaced by '^'nl combination
+ * - every non cr or nl ended write is padded with '\'nl combination
+ * - adds a detour source tag in front of each line

This seems to make it more ambiguous

drivers/char/dty.c line 95

Quoted 6 lines
drivers/char/dty.c new file +6 -0
+/*
+ *	Dummy tty ops open for succesfull terminal device open.
+ */
+static int dty_open(struct tty_struct *tty, struct file *filp)
+{
+	return 0;

The kernel really expects posix behaviour but I'm not sure how much it really matters in this case. Fixing that isn't hard though (use tty_port helpers and basically no supporting functions)

drivers/char/dty.c line 139

Quoted 3 lines
drivers/char/dty.c new file +3 -0
+	/* register our fops write function */
+	tty_default_fops(&detour_fops);
+	detour_fops.write = detour_write;

No. The behaviour of a tty is very precisely defined by the standards and stomping over things you shouldn't is not good at all. Remember your tty sets its own initial termios settings so you can set those to give the initial behaviour you want. You need the tty layer here in your case anyway as you don't have sufficient locking otherwise !

Also I'd provide a write_room method which always answers 'lots'

Do you need a recursion check. Suppose I open this device and capture printk console messages to it ? Alternatively maybe you need an ioctl handler to trap that case and reject it as a stupidity filter (or both ?)

drivers/char/dty.c line 145

Quoted 5 lines
drivers/char/dty.c new file +5 -0
+	cdev_init(&dty_driver->cdev, &detour_fops);
+
+	/* create our unnumbered device */
+	device_create(tty_class, NULL, MKDEV(TTYAUX_MAJOR, 3), NULL,
+		dty_driver->name);

These need to check for failures.

Quoted 13 lines
drivers/char/dty.c new file +13 -0
+static void initial_console_redirect(void)
+{
+	long ret;
+
+	/* re-register our fops write function */
+	detour_fops.write = detour_write;
+
+	detour_file.f_dentry = &detour_dentry;
+	detour_file.f_dentry->d_inode = &detour_inode;
+	detour_file.f_op = &detour_fops;
+	detour_file.f_mode |= FMODE_WRITE;
+	security_file_alloc(&detour_file);
+	INIT_LIST_HEAD(&detour_file.f_u.fu_list);

drivers/char/dty.c line 183

Quoted 10 lines
drivers/char/dty.c new file +10 -0
+
+	detour_inode.i_rdev = MKDEV(TTYAUX_MAJOR, 3);
+	security_inode_alloc(&detour_inode);
+	INIT_LIST_HEAD(&detour_inode.inotify_watches);
+
+	ret = detour_fops.open(&detour_inode, &detour_file);
+	printk(KERN_INFO "detour_fops.open() returned %ld\n", ret);
+	ret = detour_fops.unlocked_ioctl(&detour_file, TIOCCONS, 0);
+	printk(KERN_INFO "detour_fops.ioctl() returned %ld\n", ret);
+}

Bletch.. I'm really opposed to this kind of hackery. Fix your userspace a tiny bit.

So
- Write only tty that uses printk: Looks good to me, implementation quibbles only
- Magic kernel hacks to shuffle things around in the initial console logic - hideous. I still really think you need to fix your userspace

#3 lore raw
Quoted 10 lines · Alan Cox
Quoted 10 lines
drivers/char/dty.c new file +10 -0
+	/* re-register our fops write function */
+	detour_fops.write = detour_write;
+
+	detour_file.f_dentry = &detour_dentry;
+	detour_file.f_dentry->d_inode = &detour_inode;
+	detour_file.f_op = &detour_fops;
+	detour_file.f_mode |= FMODE_WRITE;
+	security_file_alloc(&detour_file);
+	INIT_LIST_HEAD(&detour_file.f_u.fu_list);
+
Quoted 8 lines

drivers/char/dty.c line 182

Quoted 8 lines
drivers/char/dty.c new file +8 -0
+	detour_inode.i_rdev = MKDEV(TTYAUX_MAJOR, 3);
+	security_inode_alloc(&detour_inode);
+	INIT_LIST_HEAD(&detour_inode.inotify_watches);
+
+	ret = detour_fops.open(&detour_inode, &detour_file);
+	printk(KERN_INFO "detour_fops.open() returned %ld\n", ret);
+	ret = detour_fops.unlocked_ioctl(&detour_file, TIOCCONS, 0);
+	printk(KERN_INFO "detour_fops.ioctl() returned %ld\n", ret);

That alone is enough for a NAK. Do Not Do That. Fake struct file/dentry/inode and their uses are not acceptable. Neither is modifying file_operations, while we are at it.

#4 lore raw
In reply to Alan Cox
Quoted 27 lines
Quoted 13 lines
drivers/char/dty.c new file +13 -0
+static void initial_console_redirect(void)
+{
+	long ret;
+
+	/* re-register our fops write function */
+	detour_fops.write = detour_write;
+
+	detour_file.f_dentry = &detour_dentry;
+	detour_file.f_dentry->d_inode = &detour_inode;
+	detour_file.f_op = &detour_fops;
+	detour_file.f_mode |= FMODE_WRITE;
+	security_file_alloc(&detour_file);
+	INIT_LIST_HEAD(&detour_file.f_u.fu_list);

drivers/char/dty.c line 183

Quoted 10 lines
drivers/char/dty.c new file +10 -0
+
+	detour_inode.i_rdev = MKDEV(TTYAUX_MAJOR, 3);
+	security_inode_alloc(&detour_inode);
+	INIT_LIST_HEAD(&detour_inode.inotify_watches);
+
+	ret = detour_fops.open(&detour_inode, &detour_file);
+	printk(KERN_INFO "detour_fops.open() returned %ld\n", ret);
+	ret = detour_fops.unlocked_ioctl(&detour_file, TIOCCONS, 0);
+	printk(KERN_INFO "detour_fops.ioctl() returned %ld\n", ret);
+}

Bletch.. I'm really opposed to this kind of hackery. Fix your userspace a tiny bit.

Quoted 6 lines

So
- Write only tty that uses printk: Looks good to me, implementation quibbles only
- Magic kernel hacks to shuffle things around in the initial console logic - hideous. I still really think you need to fix your userspace

Thank you for all comments. I'll try to follow them (might take some time) and i'll remove the internal console redirection magic for sure.

regards, Samo

#5 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Hi,

This is another version of former detour TTY driver, trying to follow Alan's suggestions:
- renamed from detour to ttyprintk
- removed possibility for initial internal redirection of console to this tty
- providing hopefully more proper open/close tty operations
- fixed initial termios settings
- added primitive write_room operation
- added ratelimting support (recursion check) and an ioctl trap to catch ratelimiting being activated. i'd appreciate a suggestion on this ioctl command naming/value and on location of its definition?
- additional error checking

I also have a question about the tioccons() function from the tty_io.c. Should this function also check, if the redirection tty has been opened for writing, since there are going to be implicit writes to this tty for each console message? This would prevent users without write permissions to successfully perform TIOCCONS ioctl. This would also prevent writing capable users to successfully perform TIOCCONS with read-only opened tty, but failing to write console messages to the redirection tty afterwards. This seems to happen because the mode of opened tty at the time of issuing TIOCCONS ioctl is remembered.

Alan, could you please give the patch bellow another look?

thanks, Samo

---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +305 -0

305 lines not on this page · raw message

#6 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

drivers/char/ttyprintk.c line 120

Quoted 7 lines
drivers/char/ttyprintk.c new file +6 -0
+/*
+ * TTY operations open function.
+ */
+static int tpk_open(struct tty_struct *tty, struct file *filp)
+{
+	struct ttyprintk_port *port = &tpk_port;

You can replace the rest with

	return tty_port_open(port, tty, filp);
}

drivers/char/ttyprintk.c line 140

Quoted 5 lines

+ * TTY operations close function.
+ */

drivers/char/ttyprintk.c new file +3 -0
+static void tpk_close(struct tty_struct *tty, struct file *filp)
+{
+	struct ttyprintk_port *port = tty->driver_data;

and

	tty_port_close(port, tty, filp);
Quoted 1 line

+}

which saves a lot of work

Quoted 7 lines
drivers/char/ttyprintk.c new file +7 -0
+
+/*
+ * TTY operations write function.
+ */
+int tpk_write(struct tty_struct *tty,
+		const unsigned char *buf, int count)
+{

drivers/char/ttyprintk.c line 204

Quoted 10 lines
drivers/char/ttyprintk.c new file +10 -0
+	struct ttyprintk_port *port;
+	int ret;
+
+	port = tty->driver_data;
+
+	if (!port)
+		return 0;
+
+	if (!(port->port.flags & ASYNC_INITIALIZED))
+		return 0;

These two can't happen if you use tty_port_* so it is better to blow up. If you think you may be seeing it occur then use WARN_ON() or similar

drivers/char/ttyprintk.c line 209

Quoted 5 lines
drivers/char/ttyprintk.c new file +5 -0
+
+	/* exclusive use of tpk_printk within this tty */
+	mutex_lock(&port->port_write_mutex);
+	ret = tpk_printk(buf, count);
+	mutex_unlock(&port->port_write_mutex);

And this is serialized by the caller (not that having your own lock is any harm)

Quoted 5 lines
drivers/char/ttyprintk.c new file +5 -0
+#define	TPKRLEV	(('e'<<8) | 0) /* Wait for ttyprintk ratelimiting event*/
+static int tpk_ioctl(struct tty_struct *tty, struct file *file,
+			unsigned int cmd, unsigned long arg)
+{
+	struct ttyprintk_port *port;

drivers/char/ttyprintk.c line 239

Quoted 10 lines
drivers/char/ttyprintk.c new file +10 -0
+
+	port = tty->driver_data;
+
+	if (!port)
+		return -EINVAL;
+
+	switch (cmd) {
+	case TPKRLEV:
+		wait_event_interruptible(ttyprintk_ratelimit_wq,
+			(ttyprintk_ratelimit_event != 0));

Ok that wasn't quite what I had in mind.

What I was thinking was needed was this

	/* Stop TIOCCONS */
	case TIOCCONS:
		return -EOPNOTSUPP;

only it won't work that way. I'll sort that out in tty_io.c once the driver is happy. That way anything trying to mis-redirect the console will get stopped early which is probably more reliable than a ratelimit ?

drivers/char/ttyprintk.c line 294

Quoted 1 line
drivers/char/ttyprintk.c new file +1 -0
+	memset(&tpk_port, 0, sizeof(tpk_port));

It's static so that isn't needed

drivers/char/ttyprintk.c line 296

Quoted 2 lines
drivers/char/ttyprintk.c new file +2 -0
+	tty_port_init(&tpk_port.port);
+	spin_lock_init(&tpk_port.lock);

The one other bit you will need to use the helpers is

struct tty_port_operations null_ops = { };

	tpk_port.port->ops = &null_ops;

Alan

#7 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 21 lines
Quoted 6 lines
drivers/char/ttyprintk.c new file +5 -0
+#define	TPKRLEV	(('e'<<8) | 0) /* Wait for ttyprintk ratelimiting event*/
+static int tpk_ioctl(struct tty_struct *tty, struct file *file,
+			unsigned int cmd, unsigned long arg)
+{
+	struct ttyprintk_port *port;

drivers/char/ttyprintk.c line 239

Quoted 10 lines
drivers/char/ttyprintk.c new file +10 -0
+
+	port = tty->driver_data;
+
+	if (!port)
+		return -EINVAL;
+
+	switch (cmd) {
+	case TPKRLEV:
+		wait_event_interruptible(ttyprintk_ratelimit_wq,
+			(ttyprintk_ratelimit_event != 0));

Ok that wasn't quite what I had in mind.

What I was thinking was needed was this

Quoted 8 lines
	/* Stop TIOCCONS */
	case TIOCCONS:
		return -EOPNOTSUPP;

only it won't work that way. I'll sort that out in tty_io.c once the driver is happy. That way anything trying to mis-redirect the console will get stopped early which is probably more reliable than a ratelimit ?

I'm thinking to leave the ratelimit support in for the time being. I had in mind cases, when someone does
"cat /proc/kmsg > dev/ttyprintk" or
suppose the console is redirected to ttyprintk (which i would like to be able to do from user program) and then someone does:
"cat /proc/kmsg > /dev/console"... or
if console is redirected after this command ?

Were you thinking of some other mis-redirection case?

Samo

#8 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 5 lines

I'm thinking to leave the ratelimit support in for the time being. I had in mind cases, when someone does
"cat /proc/kmsg > dev/ttyprintk" or
suppose the console is redirected to ttyprintk (which i would like to be able to do from user program)

Console as in the printk sense would then loop.

If you are going to do the flow control you should probably do something like

write_room()

{
	if (!flow_controlled)
		space = 8192;
	return space;
}

write()

{
	space -= len;
}

then your flow control will behave properly and slow down users rather than losing data (except stuff sent without blocking)

#9 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 19 lines · On 21.06.2010 (Mon) at 15:38 +0100 Alan Cox wrote:
Quoted 5 lines

I'm thinking to leave the ratelimit support in for the time being. I had in mind cases, when someone does
"cat /proc/kmsg > dev/ttyprintk" or
suppose the console is redirected to ttyprintk (which i would like to be able to do from user program)

Console as in the printk sense would then loop.

If you are going to do the flow control you should probably do something like

write_room()

{
	if (!flow_controlled)
		space = 8192;
	return space;
}
Quoted 8 lines

write()

{
	space -= len;
}

then your flow control will behave properly and slow down users rather than losing data (except stuff sent without blocking)

For correct flow control, i suppose current empty space of the real (final) printk buffer is needed. On the other hand my intermediate pre-formatting buffer is only "one line" long, but serialized on access in a way that it is always completely available (except for the time of tpk_printk() function running). As such intermediate buffer only defines maximum write_room space.

Now there are two ideas. The first one is to dig out current real printk buffer space (smells like hacking?) and adapt write_room to that space in some logical manner. And the other would be to use ratelimit support to switch between max and zero in write_room answer and remove other retelimit response?

What do you suggest, do i miss something?

regards, Samo

#10 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 2 lines

For correct flow control, i suppose current empty space of the real (final) printk buffer is needed. On the other hand my intermediate

Console drivers have their own buffering so that doesn't really work. If you want to just avoid explosions then you don't need to be quite so clever

Quoted 3 lines

in some logical manner. And the other would be to use ratelimit support to switch between max and zero in write_room answer and remove other retelimit response?

Yes - except that a driver isn't permitted to reduce the write room space by more than bytes written. That is if you offer 512 bytes you can't offer 0 until 512 bytes have been written - hence the design of the pseudo code I posted in the previous message.

#11 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 9 lines
Quoted 4 lines

in some logical manner. And the other would be to use ratelimit support to switch between max and zero in write_room answer and remove other retelimit response?

Yes - except that a driver isn't permitted to reduce the write room space by more than bytes written. That is if you offer 512 bytes you can't offer 0 until 512 bytes have been written - hence the design of the pseudo code I posted in the previous message.

Now flow control is provided in a way that each write ratelimit false detection shrinks available space for its output lenth. On the other hand write returns available space back to maximum on true ratelimit detection result. Additionaly each next write_room returns at least one character space under high load, if zero space is reached.

Additionally a private ttyprintk_ratelimit function is provided to suppress "missed callbacks" printks, because we do not really miss anything.

regards, Samo
----

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +264 -0

264 lines not on this page · raw message

#12 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

drivers/char/ttyprintk.c line 176

Quoted 7 lines
drivers/char/ttyprintk.c new file +7 -0
+static int tpk_write_room(struct tty_struct *tty)
+{
+	int ret = tpk_space;
+
+	/* allow char by char under max pressure */
+	if (tpk_space == 0)
+		tpk_space = 1;

That won't do what you think, the ldisc will keep seeing progress and generate millions of 1 byte I/Os in a loop !

Otherwise looks excellent.

drivers/char/ttyprintk.c line 197

Quoted 4 lines
drivers/char/ttyprintk.c new file +4 -0
+	switch (cmd) {
+	/* Stop TIOCCONS */
+	case TIOCCONS:
+		return -EOPNOTSUPP;

And I'll fix this bit up to work properly in the core code.

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

#13 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 10 lines

drivers/char/ttyprintk.c line 176

Quoted 7 lines
drivers/char/ttyprintk.c new file +7 -0
+static int tpk_write_room(struct tty_struct *tty)
+{
+	int ret = tpk_space;
+
+	/* allow char by char under max pressure */
+	if (tpk_space == 0)
+		tpk_space = 1;

That won't do what you think, the ldisc will keep seeing progress and generate millions of 1 byte I/Os in a loop !

I thought that this would automatically reduce processor load, which is obviously not the case. Sorry for the delay, but i am trying to figure out how to slow down write method when under pressure.

And that setting tpk_space to 1 would then be just in case we reach 0 to enable further processing.

Samo

#14 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 3 lines

I thought that this would automatically reduce processor load, which is obviously not the case. Sorry for the delay, but i am trying to figure out how to slow down write method when under pressure.

Ok I played with this a bit. Much to my surprise until I thought about it in detail it all works fine without any of the ratelimiting at all. There is a problem if you manage to redirect the console *in kernel* to the printk driver, but that needs stopping anyway and rate limit won't fix it (you blow the stack before it kicks in)

In the case where userspace loads it hard and its a graphical console then we use a lot of CPU power drawing stuff on screen, but killing the process does as is expected.

With a serial console the printk itself blocks which blocks the line discipline which in turn slows stuff down.

The only two bad things I can see how to cause are

- Slowing down output by stuffing lots of extra data into the port (which I can do anyway just fine) so isn't worse than before.

- Filling up the dmesg log easily and hiding important messages. Not really a problem in this case bcause the whole point of this is embedded and capturing those messages as if they were system ones.

So much to my surprise the flow control is a red herring and best left out.

Alan

#15 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Dne 27.06.2010 (ned) ob 14:35 +0100 je Alan Cox zapisal(a):

Quoted 22 lines
Quoted 3 lines

I thought that this would automatically reduce processor load, which is obviously not the case. Sorry for the delay, but i am trying to figure out how to slow down write method when under pressure.

Ok I played with this a bit. Much to my surprise until I thought about it in detail it all works fine without any of the ratelimiting at all. There is a problem if you manage to redirect the console *in kernel* to the printk driver, but that needs stopping anyway and rate limit won't fix it (you blow the stack before it kicks in)

In the case where userspace loads it hard and its a graphical console then we use a lot of CPU power drawing stuff on screen, but killing the process does as is expected.

With a serial console the printk itself blocks which blocks the line discipline which in turn slows stuff down.

The only two bad things I can see how to cause are

- Slowing down output by stuffing lots of extra data into the port (which I can do anyway just fine) so isn't worse than before.

Quoted 8 lines

- Filling up the dmesg log easily and hiding important messages. Not really a problem in this case bcause the whole point of this is embedded and capturing those messages as if they were system ones.

So much to my surprise the flow control is a red herring and best left out.

Alan

If without flow control, do you think it makes sense to very slowly introduce more and more delay (interruptible) into tty's write operation when output rate is "too" high? That way non-error conditions would not suffer (not discarding any messages, only delaying additional 1 msec on 100 writes), when ratelimit would have been exceeded from time to time. And on the other hand endless high-volume output, which is probably an error condition, would slowly give away more and more of its processing time. Maybe this would also help if output is made on behalf of some high RT-prioritized process?

Of course, i can easily remove ratelimiting as well, if the situation with flow control isn't clear and this only complicates things.

Samo

#16 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Alan Cox

Hi,

Please bear with me for a bit longer, because i got slightly modified perspective of some things i did within the driver.
I.e. somewhere down the road i forgot that my pre-formatting function does not really limit output buffer size with its "one-line" buffer size. So now 4K output size is assumed and always provided by write_room(). The other thing is that i tried to resolve two things being in conflict. I tried to fit driver to existing distro initialization, which required immediate output also for not line terminated strings. And on the other hand not line terminated strings could have been provided by line discipline all the time. So i finally removed immediate output code and let user takes care by terminating lines if immediate output is required.

There is additional possibility to fine tune ratelimiting and printk delaying parameters via defines also with more comments added.

Alan, if you agree, i would send this one to GregKH?

regards, Samo
---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +283 -0

283 lines not on this page · raw message

#17 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Alan Cox
Quoted 11 lines

Review

Quoted 7 lines
(quoted diff) +7 -0
+static int tpk_write_room(struct tty_struct *tty)
+{
+	int ret = tpk_space;
+
+	/* allow char by char under max pressure */
+	if (tpk_space == 0)
+		tpk_space = 1;

That won't do what you think, the ldisc will keep seeing progress and generate millions of 1 byte I/Os in a loop !

Somewhat changed to slowly increase delay in write, if ratelimiting doesn't end.

Quoted 2 lines

Otherwise looks excellent.

Thanks to you.

Quoted 9 lines

Review

Quoted 5 lines
(quoted diff) +4 -0
+	switch (cmd) {
+	/* Stop TIOCCONS */
+	case TIOCCONS:
+		return -EOPNOTSUPP;

And I'll fix this bit up to work properly in the core code.

Quoted 3 lines

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

I am not sure if i understand. Should i exclude devices.txt from patch before sending it to GregKH?

Samo
---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +297 -0

297 lines not on this page · raw message

#18 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Alan Cox
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

regards, Samo
---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +225 -0

225 lines not on this page · raw message

#19 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 7 lines · Samo Pogacnik
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

Quoted 7 lines

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

regards, Samo
---

I need some information on what this patch is, and why we would want it, so that it can be put into the changelog. Care to resend it with that information present?

thanks,

greg k-h

#20 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Alan Cox
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

regards, Samo
---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +225 -0

225 lines not on this page · raw message

#21 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 7 lines · Samo Pogacnik
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

Quoted 8 lines

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

Why does this need to be a tty driver? Why not a misc device?

And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality?

confused,

greg k-h

#22 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 1 line

Why does this need to be a tty driver? Why not a misc device?

So you can use it as a"console" (in the user space sense) tty device on embedded devices which don't have a meaningful normal output subsystem.

Alan

#23 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 4 lines · Alan Cox
Quoted 1 line

Why does this need to be a tty driver? Why not a misc device?

So you can use it as a"console" (in the user space sense) tty device on embedded devices which don't have a meaningful normal output subsystem.

But can't you do that today with kmsg? The startup of systemd does this in a way that handles all of the log messages very nicely, and the embedded people are sure to pick it up as well because of the simplicity.

thanks,

greg k-h

#24 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Greg KH
Quoted 12 lines · On 24.08.2010 (Tue) at 14:10 -0700 Greg KH wrote:
Quoted 11 lines · Samo Pogacnik
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

Quoted 6 lines
Quoted 4 lines

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

Why does this need to be a tty driver? Why not a misc device?

Thanks for the response. I'll try to explain.
Well it all started with a kernel hack, which internaly redirected console output to printk function to be able to capture console messages inline with real kernel messages. Console messages have also been automatically stored via system logging facility, which was very useful especially for analyzes of the initrd part of the userspace system initialization. Through initial posts (thread: console logging detour via printk) Alan suggested, that a separate TTY driver could provide this functionality and that may initial hacking isn't acceptable.

Quoted 3 lines

And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality?

I must admit, i was not aware of the /dev/kmsg driver, but i made a few tests and found out that it seems not to be possible to redirect console to kmsg.

regards, Samo

#25 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 19 lines · Samo Pogacnik
Quoted 12 lines · On 24.08.2010 (Tue) at 14:10 -0700 Greg KH wrote:
Quoted 11 lines · Samo Pogacnik
Quoted 3 lines · On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote:

With my devices.txt owner hat on I'll allocate the minor as you suggest (and double check this causes no problems), with my tty hat on can you send it to GregKH for merging into the tree.

Hi,

I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

Quoted 6 lines
Quoted 4 lines

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

Why does this need to be a tty driver? Why not a misc device?

Quoted 9 lines

Thanks for the response. I'll try to explain.
Well it all started with a kernel hack, which internaly redirected console output to printk function to be able to capture console messages inline with real kernel messages. Console messages have also been automatically stored via system logging facility, which was very useful especially for analyzes of the initrd part of the userspace system initialization. Through initial posts (thread: console logging detour via printk) Alan suggested, that a separate TTY driver could provide this functionality and that may initial hacking isn't acceptable.

That's what kmsg can do :)

Quoted 5 lines
Quoted 2 lines

And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality?

I must admit, i was not aware of the /dev/kmsg driver, but i made a few tests and found out that it seems not to be possible to redirect console to kmsg.

See how systemd does this, as it sounds like exactly what you want to do. Look in either Fedora 14, or openSUSE Factory for examples of this, with no kernel changes needed.

thanks,

greg k-h

#26 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Dne 24.08.2010 (tor) ob 15:20 -0700 je Greg KH zapisal(a):

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality?

I must admit, i was not aware of the /dev/kmsg driver, but i made a few tests and found out that it seems not to be possible to redirect console to kmsg.

See how systemd does this, as it sounds like exactly what you want to do. Look in either Fedora 14, or openSUSE Factory for examples of this, with no kernel changes needed.

I'll check out systemd.

however:)
It may be that systemd does not cover the initrd part of the initialization and it may be an overkill do introduce systemd to an existing system just to be analyzed.

regards, Samo

#27 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 11 lines · Samo Pogacnik

Dne 24.08.2010 (tor) ob 15:20 -0700 je Greg KH zapisal(a):

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality?

I must admit, i was not aware of the /dev/kmsg driver, but i made a few tests and found out that it seems not to be possible to redirect console to kmsg.

See how systemd does this, as it sounds like exactly what you want to do. Look in either Fedora 14, or openSUSE Factory for examples of this, with no kernel changes needed.

Quoted 6 lines

I'll check out systemd.

however:)
It may be that systemd does not cover the initrd part of the initialization and it may be an overkill do introduce systemd to an existing system just to be analyzed.

No, it does cover that. You should be able to do that with a simple console redirection to /dev/kmsg What happened when you tried to do that?

thanks,

greg k-h

#28 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 3 lines

No, it does cover that. You should be able to do that with a simple console redirection to /dev/kmsg What happened when you tried to do that?

stty: standard input: Inappropriate ioctl for device

It's value is twofold

- formatting
- tty ioctls work as they should on a console (eg vhangup)

and its a tiny driver with no impact on the rest of the kernel - so to me it seems useful in that form.

Alan

#29 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 5 lines · Alan Cox
Quoted 3 lines

No, it does cover that. You should be able to do that with a simple console redirection to /dev/kmsg What happened when you tried to do that?

stty: standard input: Inappropriate ioctl for device

Kay, how does systemd handle the kmsg console redirection?

Quoted 3 lines

It's value is twofold

- formatting

Ick, we really want to format things from userspace here?

thanks,

greg k-h

#30 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 3 lines
Quoted 1 line

- formatting

Ick, we really want to format things from userspace here?

Depends what you are trying to do.

Put an embedded hat on

Do you want to be able to flip between a real debug interface and a logging device on the same software set without risking changing behaviour

Do you want to load a 70K daemon and an initrd or burn about 1.5K on a kernel interface ?

Alan

#31 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 10 lines · Alan Cox
Quoted 3 lines
Quoted 1 line

- formatting

Ick, we really want to format things from userspace here?

Depends what you are trying to do.

Put an embedded hat on

Do you want to be able to flip between a real debug interface and a logging device on the same software set without risking changing behaviour

I don't understand this point.

Quoted 2 lines

Do you want to load a 70K daemon and an initrd or burn about 1.5K on a kernel interface ?

I'd rather burn 0K on the one we have today :)

Seriously, look at how Fedora 14 handles this, why can't you do the same for embedded systems all from userspace, no additional code needed anywhere.

thanks,

greg k-h

#32 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

2010/8/25 Greg KH <[email protected]>:

Quoted 10 lines · Alan Cox

Seriously, look at how Fedora 14 handles this, why can't you do the same for embedded systems all from userspace, no additional code needed anywhere.

thanks,

greg k-h
--

Samo sometimes ago I gave you some information on the system startup about OpenSuse, have you look at it? It's possible that what Greg said, it's true.

Regards,

Marco

#33 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Greg KH
Quoted 4 lines
Quoted 2 lines

Do you want to be able to flip between a real debug interface and a logging device on the same software set without risking changing behaviour

I don't understand this point.

A tty has a very specific set of behaviours simply by being a tty. Some applications rely upon them so being able to flip between the two interfaces is useful.

Quoted 4 lines
Quoted 2 lines

Do you want to load a 70K daemon and an initrd or burn about 1.5K on a kernel interface ?

I'd rather burn 0K on the one we have today :)

So say "N" when configuring

Quoted 3 lines

Seriously, look at how Fedora 14 handles this, why can't you do the same for embedded systems all from userspace, no additional code needed anywhere.

Its a whole set of extra processes and daemons and stuff, and minimally uses something like 70K even if its very compact (8K stack, 40K+ page tables, 16K of buffers, code, data) - oh and I forgot the fifo buffering and pty cost - so its near 100K. 1.5K v 100K - for something 1.5K of kernel code that anyone else can turn off and would be off by default ?

On a lot of embedded systems you don't have all the stuff Fedora carts around. No modules, initrds, magic front end processes, graphical startup daemons etc, all of which work to produce that feature IFF you have pty support in your kernel, and for the current code also glibc.

You also want errors to get out (or stored) even if there are crashes - which the Fedora one is not very good at. To be fair in the Fedora world its not a big deal to say 'Oh dear, boot with ....'. Embedded isn't the same, and you want to capture the odd rare error reliably.

Alan

#34 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 8 lines · Alan Cox
Quoted 4 lines
Quoted 2 lines

Do you want to be able to flip between a real debug interface and a logging device on the same software set without risking changing behaviour

I don't understand this point.

A tty has a very specific set of behaviours simply by being a tty. Some applications rely upon them so being able to flip between the two interfaces is useful.

Would that work for this driver in use as a console?

Quoted 10 lines
Quoted 3 lines

Seriously, look at how Fedora 14 handles this, why can't you do the same for embedded systems all from userspace, no additional code needed anywhere.

Its a whole set of extra processes and daemons and stuff, and minimally uses something like 70K even if its very compact (8K stack, 40K+ page tables, 16K of buffers, code, data) - oh and I forgot the fifo buffering and pty cost - so its near 100K. 1.5K v 100K - for something 1.5K of kernel code that anyone else can turn off and would be off by default ?

exec < /dev/console > /dev/kmsg 2>&1

That's one extra process, not that much, right?

Quoted 4 lines

On a lot of embedded systems you don't have all the stuff Fedora carts around. No modules, initrds, magic front end processes, graphical startup daemons etc, all of which work to produce that feature IFF you have pty support in your kernel, and for the current code also glibc.

It sounded like they had an initrd that they cared about here.

Quoted 4 lines

You also want errors to get out (or stored) even if there are crashes - which the Fedora one is not very good at. To be fair in the Fedora world its not a big deal to say 'Oh dear, boot with ....'. Embedded isn't the same, and you want to capture the odd rare error reliably.

again, the above exec line should work for what the embedded people want, right?

thanks,

greg k-h

#35 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 1 line

Would that work for this driver in use as a console?

Yes

Quoted 3 lines

exec < /dev/console > /dev/kmsg 2>&1

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Quoted 7 lines
Quoted 4 lines

You also want errors to get out (or stored) even if there are crashes - which the Fedora one is not very good at. To be fair in the Fedora world its not a big deal to say 'Oh dear, boot with ....'. Embedded isn't the same, and you want to capture the odd rare error reliably.

again, the above exec line should work for what the embedded people want, right?

We didn't *need* devtmpfs either - that was a little bit of user space. It's a similar thing - you can do the job better in 1.5K of kernel code than 150K or more of user space - which is not trivial on a box with no swap.

Alan

#36 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 9 lines · Alan Cox
Quoted 1 line

Would that work for this driver in use as a console?

Yes

Quoted 3 lines

exec < /dev/console > /dev/kmsg 2>&1

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

You also want errors to get out (or stored) even if there are crashes - which the Fedora one is not very good at. To be fair in the Fedora world its not a big deal to say 'Oh dear, boot with ....'. Embedded isn't the same, and you want to capture the odd rare error reliably.

Quoted 7 lines
Quoted 2 lines

again, the above exec line should work for what the embedded people want, right?

We didn't *need* devtmpfs either - that was a little bit of user space. It's a similar thing - you can do the job better in 1.5K of kernel code than 150K or more of user space - which is not trivial on a box with no swap.

Ok, I didn't realize it really was that big.

Samo, care to resend the patch?

thanks,

greg k-h

#37 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Distros no - I doubt any normal PC distro would turn the facility on. Embedded - yes especially deeply embedded.

Quoted 1 line

Ok, I didn't realize it really was that big.

libc page tables
app page tables
stacks (kernel and user)
arguments/exec page
buffers

Yes - it soon adds up.

Alan

#38 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 9 lines · Alan Cox
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Distros no - I doubt any normal PC distro would turn the facility on. Embedded - yes especially deeply embedded.

So should this be dependent on CONFIG_EMBEDDED then?

thanks,

greg k-h

#39 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 5 lines · On Wed, 25 Aug 2010 11:16:47 -0700 Greg KH <[email protected]> wrote:
Quoted 4 lines · Alan Cox
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Distros no - I doubt any normal PC distro would turn the facility on. Embedded - yes especially deeply embedded.

So should this be dependent on CONFIG_EMBEDDED then?

No objection to that

#40 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Greg KH
Quoted 5 lines · On 25.08.2010 (sre) at 11:16 -0700 Greg KH wrote:
Quoted 4 lines · Alan Cox
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Distros no - I doubt any normal PC distro would turn the facility on. Embedded - yes especially deeply embedded.

So should this be dependent on CONFIG_EMBEDDED then?

Should i resend the patch with CONFIG_EMBEDDED dependency enabled? I do not have any real objections to that, except that the driver operates the same way regardless of the (non-)embedded configuration.

regards, Samo

#41 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 12 lines · Samo Pogacnik
Quoted 11 lines · On 25.08.2010 (sre) at 11:16 -0700 Greg KH wrote:
Quoted 9 lines · Alan Cox
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's one extra process, not that much, right?

About 150K or so way too much and its not robust.

Fair enough. So, with this driver, would it make sense for the distros to switch over to using it instead of the above line in their initrd?

Distros no - I doubt any normal PC distro would turn the facility on. Embedded - yes especially deeply embedded.

Quoted 6 lines
Quoted 2 lines

So should this be dependent on CONFIG_EMBEDDED then?

Should i resend the patch with CONFIG_EMBEDDED dependency enabled? I do not have any real objections to that, except that the driver operates the same way regardless of the (non-)embedded configuration.

No, I can change it when I apply the patch next week (sorry, swamped at the moment.)

thanks,

greg k-h

#42 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Greg KH
Quoted 2 lines · On 25.08.2010 Greg KH wrote:

Samo, care to resend the patch?

Sure, here it is:
---
I hope that this TTY driver is ok for merging. It is very basic - removed all flow control and rate limiting. Patch has been generated against 2.6.34 kernel version.

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

regards, Samo
---

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +225 -0

225 lines not on this page · raw message

#43 lore raw

patch "add ttyprintk driver" added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

add ttyprintk driver

to my gregkh-2.6 tree which can be found in directory form at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
and in git form at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/patches.git

The filename of this patch is:
add-ttyprintk-driver.patch

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

If this patch meets the merge guidelines for a bugfix, it should be merged into Linus's tree before the next major kernel release. If not, it will be merged into Linus's tree during the next merge window.

Either way, you will probably be copied on the patch when it gets sent to Linus for merging so that others can see what is happening in kernel development.

If you have any questions about this process, please let me know.

From [email protected] Wed Sep 1 15:35:26 2010
Subject: add ttyprintk driver
From: Samo Pogacnik <[email protected]>
To: linux kernel <[email protected]>
Cc: linux-embedded <[email protected]>,
Greg KH <[email protected]>, Alan Cox <[email protected]>, Kay Sievers <[email protected]>
Date: Wed, 25 Aug 2010 20:44:07 +0200
Message-Id: <1282761847.5857.9.camel@itpsd6lap>

Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, via output to ttyprintk device. It is possible to store "console" messages inline with kernel messages for better analyses of the boot process, for example.

---
 Documentation/devices.txt |    1 
 drivers/char/Kconfig      |   15 +++
 drivers/char/Makefile     |    1 
 drivers/char/ttyprintk.c  |  225 ++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 242 insertions(+)
Documentation/devices.txt +1 -0
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +15 -0
@@ -493,6 +493,21 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	depends on EMBEDDED
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
@@ -12,6 +12,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.
 obj-y				+= tty_mutex.o
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +225 -0

225 lines not on this page · raw message

#44 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 5 lines · Alan Cox
Quoted 3 lines

No, it does cover that.  You should be able to do that with a simple console redirection to /dev/kmsg  What happened when you tried to do that?

stty: standard input: Inappropriate ioctl for device

Kay, how does systemd handle the kmsg console redirection?

Systemd does not steal the console, this is done by plymouth, in the same way blogd can do that. It uses a pty and rewrites the messages.

Systemd does pass syslog to the kernel buffer during early boot. Init provides /dev/log. With systemd, the started services usually don't get the console connected, but use syslog anyway or the stdout/err gets redirected to syslog.

With systemd the console is not too useful because we start everything in parallel. If all the services would put out stuff there like sysv did, it would look like a real mess.

Kay

#45 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

Quoted 13 lines · Kay Sievers
Quoted 8 lines · Greg KH
Quoted 5 lines · Alan Cox
Quoted 3 lines

No, it does cover that.  You should be able to do that with a simple console redirection to /dev/kmsg  What happened when you tried to do that?

stty: standard input: Inappropriate ioctl for device

Kay, how does systemd handle the kmsg console redirection?

Systemd does not steal the console, this is done by plymouth, in the same way blogd can do that. It uses a pty and rewrites the messages.

Quoted 8 lines

Systemd does pass syslog to the kernel buffer during early boot. Init provides /dev/log. With systemd, the started services usually don't get the console connected, but use syslog anyway or the stdout/err gets redirected to syslog.

With systemd the console is not too useful because we start everything in parallel. If all the services would put out stuff there like sysv did, it would look like a real mess.

Or isn't that what you asked for? We just write the stuff that arrives at syslog to /dev/kmsg to put things in the kernel log buffer.

Also initrds are usually using
exec < /dev/console > /dev/kmsg 2>&1
to get stuff directly to the kernel buffer.

What does /dev/ttyprintk offer on top of that?

Kay

#46 lore raw

Re: [PATCH] detour TTY driver - now ttyprintk

In reply to Alan Cox
Quoted 10 lines

Review

Quoted 7 lines
(quoted diff) +6 -0
+/*
+ * TTY operations open function.
+ */
+static int tpk_open(struct tty_struct *tty, struct file *filp)
+{
+	struct ttyprintk_port *port = &tpk_port;

You can replace the rest with

Quoted 3 lines
	return tty_port_open(port, tty, filp);
}

fixed

Quoted 7 lines

Review

Quoted 5 lines

+ * TTY operations close function.
+ */

(quoted diff) +3 -0
+static void tpk_close(struct tty_struct *tty, struct file *filp)
+{
+	struct ttyprintk_port *port = tty->driver_data;

and

Quoted 6 lines
	tty_port_close(port, tty, filp);
Quoted 1 line

+}

which saves a lot of work

yeah right, done

Quoted 12 lines
Quoted 12 lines
(quoted diff) +12 -0
+
+/*
+ * TTY operations write function.
+ */
+int tpk_write(struct tty_struct *tty,
+		const unsigned char *buf, int count)
+{
+	struct ttyprintk_port *port;
+	int ret;
+
+	port = tty->driver_data;
+
Quoted 9 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+	if (!port)
+		return 0;
+
+	if (!(port->port.flags & ASYNC_INITIALIZED))
+		return 0;

These two can't happen if you use tty_port_* so it is better to blow up. If you think you may be seeing it occur then use WARN_ON() or similar

the two checks were removed

Quoted 9 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+
+	/* exclusive use of tpk_printk within this tty */
+	mutex_lock(&port->port_write_mutex);
+	ret = tpk_printk(buf, count);
+	mutex_unlock(&port->port_write_mutex);

And this is serialized by the caller (not that having your own lock is any harm)

own lock peserved just in case

Quoted 10 lines
Quoted 10 lines
(quoted diff) +9 -0
+#define	TPKRLEV	(('e'<<8) | 0) /* Wait for ttyprintk ratelimiting event*/
+static int tpk_ioctl(struct tty_struct *tty, struct file *file,
+			unsigned int cmd, unsigned long arg)
+{
+	struct ttyprintk_port *port;
+
+	port = tty->driver_data;
+
+	if (!port)
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+		return -EINVAL;
+
+	switch (cmd) {
+	case TPKRLEV:
+		wait_event_interruptible(ttyprintk_ratelimit_wq,
+			(ttyprintk_ratelimit_event != 0));

Ok that wasn't quite what I had in mind.

ratelimiting remained present

Quoted 7 lines

What I was thinking was needed was this

	/* Stop TIOCCONS */
	case TIOCCONS:
		return -EOPNOTSUPP;

added

Quoted 6 lines

only it won't work that way. I'll sort that out in tty_io.c once the driver is happy. That way anything trying to mis-redirect the console will get stopped early which is probably more reliable than a ratelimit ?

Review

Quoted 1 line
(quoted diff) +1 -0
+	memset(&tpk_port, 0, sizeof(tpk_port));

memset removed

Quoted 7 lines

It's static so that isn't needed

Review

Quoted 2 lines
(quoted diff) +2 -0
+	tty_port_init(&tpk_port.port);
+	spin_lock_init(&tpk_port.lock);

The one other bit you will need to use the helpers is

Quoted 5 lines

struct tty_port_operations null_ops = { };

	tpk_port.port->ops = &null_ops;

Alan

Also added, with many thanks,

Samo
----

Documentation/devices.txt +1 -0
index 53d64d3..71aef33 100644
@@ -239,6 +239,7 @@ Your cooperation is appreciated.
 		  0 = /dev/tty		Current TTY device
 		  1 = /dev/console	System console
 		  2 = /dev/ptmx		PTY master multiplex
+		  3 = /dev/ttyprintk	User messages via printk TTY device
 		 64 = /dev/cua0		Callout device for ttyS0
 		    ...
 		255 = /dev/cua191	Callout device for ttyS191
drivers/char/Kconfig +14 -0
index 3141dd3..5c38a06 100644
@@ -485,6 +485,20 @@ config LEGACY_PTY_COUNT
 	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
 	  architectures and 24 bytes on 64-bit architectures.
 
+config TTY_PRINTK
+	bool "TTY driver to output user messages via printk"
+	default n
+	---help---
+	  If you say Y here, the support for writing user messages (i.e.
+	  console messages) via printk is available.
+
+	  The feature is useful to inline user messages with kernel
+	  messages.
+	  In order to use this feature, you should output user messages
+	  to /dev/ttyprintk or redirect console to this TTY.
+
+	  If unsure, say N.
+
 config BRIQ_PANEL
 	tristate 'Total Impact briQ front panel driver'
 	depends on PPC_CHRP
drivers/char/Makefile +1 -0
index f957edf..ed60f45 100644
@@ -11,6 +11,7 @@ obj-y	 += mem.o random.o tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o tty_buffer.o t
 
 obj-$(CONFIG_LEGACY_PTYS)	+= pty.o
 obj-$(CONFIG_UNIX98_PTYS)	+= pty.o
+obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
 obj-$(CONFIG_VT)		+= vt_ioctl.o vc_screen.o selection.o keyboard.o
 obj-$(CONFIG_BFIN_JTAG_COMM)	+= bfin_jtag_comm.o
drivers/char/ttyprintk.c new file +248 -0

248 lines not on this page · raw message