HID: Added further information for Roccat Kone
Subsystems (2)
Stefan Achatz
maintainerPATCH 2/5 HID: Added further information for Roccat Kone
Quoted 1 line
From
0875b1fdc784c60d28d3c5bc02ffcf0f30ccea2cMon Sep 17 00:00:00 2001
From: Stefan Achatz <[email protected]>
Date: Sat, 8 May 2010 16:53:31 +0200
Subject: [PATCH 2/5] HID: Added further information for Roccat Kone
Added new data and changed workaround for abnormal button behaviour according to new gained knowledge about Roccat Kone device.
--- drivers/hid/hid-roccat-kone.c | 11 ++++++----- drivers/hid/hid-roccat-kone.h | 19 ++++++++++++++++--- 2 files changed, 22 insertions(+), 8 deletions(-)
drivers/hid/hid-roccat-kone.c +6 -5
@@ -928,14 +928,15 @@ static int kone_raw_event(struct hid_device *hdev, struct hid_report *report,return 0 ;/* -* Firmware 1.38 introduced new behaviour for tilt buttons. -* Pressed tilt button is reported in each movement event. +* Firmware 1.38 introduced new behaviour for tilt and special buttons. +* Pressed button is reported in each movement event. * Workaround sends only one event per press. */ -if (kone->last_tilt_state == event->tilt) - event->tilt =0 ; +if (memcmp (&kone->last_mouse_event.tilt, &event->tilt,5 )) +memcpy (&kone->last_mouse_event, event, +sizeof (struct kone_mouse_event ));else - kone->last_tilt_state = event->tilt; +memset (&event->tilt,0 ,5 );/* * handle special events and keep actual profile and dpi values
drivers/hid/hid-roccat-kone.h +16 -3
@@ -80,6 +80,17 @@ enum kone_button_info_types { kone_button_info_type_multimedia_volume_down =0x27 }; +enum kone_button_info_numbers { + kone_button_top =1 , + kone_button_wheel_tilt_left =2 , + kone_button_wheel_tilt_right =3 , + kone_button_forward =4 , + kone_button_backward =5 , + kone_button_middle =6 , + kone_button_plus =7 , + kone_button_minus =8 , +}; +struct kone_light_info {uint8_t number;/* number of light 1-5 */ uint8_t mod;/* 1 = on, 2 = off */
@@ -117,6 +128,7 @@ struct kone_profile {uint8_t light_effect_speed;/* range 0-255 */ struct kone_light_info light_infos[5 ]; +/* offset is kone_button_info_numbers - 1 */ struct kone_button_info button_infos[8 ];uint16_t checksum;/* \brief holds checksum of struct */
@@ -162,7 +174,7 @@ enum kone_mouse_events {/* TODO clarify meaning and occurence of kone_mouse_event_calibration */ kone_mouse_event_calibration =0xc0 , kone_mouse_event_call_overlong_macro =0xe0 , -/* switch events notify if user changed values wiht mousebutton click */ +/* switch events notify if user changed values with mousebutton click */ kone_mouse_event_switch_dpi =0xf0 , kone_mouse_event_switch_profile = 0xf1 };
@@ -185,8 +197,9 @@ struct kone_device {* is no way of getting this information from the device on demand */ int actual_profile, actual_dpi; -/* Used for neutralizing abnormal tilt button behaviour */ -int last_tilt_state; +/* Used for neutralizing abnormal button behaviour */ +struct kone_mouse_event last_mouse_event; +/* * It's unlikely that multiple sysfs attributes are accessed at a time, * so only one mutex is used to secure hardware access and profiles and
Signature · 1 line
1.6.6.1
Jiri Kosina
AppliedQuoted 19 lines · Stefan Achatz
Quoted 1 line
From
0875b1fdc784c60d28d3c5bc02ffcf0f30ccea2cMon Sep 17 00:00:00 2001From: Stefan Achatz <[email protected]>
Date: Sat, 8 May 2010 16:53:31 +0200
Subject: [PATCH 2/5] HID: Added further information for Roccat KoneAdded new data and changed workaround for abnormal button behaviour according to new gained knowledge about Roccat Kone device.
Signed-off-by Stefan Achatz <[email protected]>--- drivers/hid/hid-roccat-kone.c | 11 ++++++----- drivers/hid/hid-roccat-kone.h | 19 ++++++++++++++++--- 2 files changed, 22 insertions(+), 8 deletions(-)drivers/hid/hid-roccat-kone.c +0
-0
drivers/hid/hid-roccat-kone.c static int kone_raw_event(struct hid_device *hdev, struct hid_report *report, · line 933
Quoted 8 lines
drivers/hid/hid-roccat-kone.c +2
-2@@ -928,14 +928,15 @@ static int kone_raw_event(struct hid_device *hdev, struct hid_report *report,return 0 ;/* -* Firmware 1.38 introduced new behaviour for tilt buttons. -* Pressed tilt button is reported in each movement event. +* Firmware 1.38 introduced new behaviour for tilt and special buttons. +* Pressed button is reported in each movement event. * Workaround sends only one event per press.
Applied, thank you Stefan.
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.