Skip to contentSkip to conversation

HID: Removed unused variable from hidraw_read

PATCH Applied Stefan Achatz 2 participants 2 messages May 19, 2010 – May 25, 2010 HID

lore
Share & tools
lore

Stefan Achatz

author
#0 lore raw

PATCH 1/1 HID: Removed unused variable from hidraw_read

Removed unused variable from hidraw_read.

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hidraw.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/hid/hidraw.c +0 -2
index 6eadf1a..bfe1e26 100644
@@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
 {
 	struct hidraw_list *list = file->private_data;
 	int ret = 0, len;
-	char *report;
 	DECLARE_WAITQUEUE(wait, current);
 
 	mutex_lock(&list->read_mutex);

@@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
 		if (ret)
 			goto out;
 
-		report = list->buffer[list->tail].value;
 		len = list->buffer[list->tail].len > count ?
 			count : list->buffer[list->tail].len;
Signature · 1 line
1.6.6.1
Applied
#1 lore raw
Quoted 20 lines · Stefan Achatz

Removed unused variable from hidraw_read.

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hidraw.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/hid/hidraw.c +0 -1
index 6eadf1a..bfe1e26 100644
@@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
 {
 	struct hidraw_list *list = file->private_data;
 	int ret = 0, len;
-	char *report;
 	DECLARE_WAITQUEUE(wait, current);
 
 	mutex_lock(&list->read_mutex);

drivers/hid/hidraw.c static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count, · line 88

Quoted 7 lines
drivers/hid/hidraw.c +0 -1
@@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
 		if (ret)
 			goto out;
 
-		report = list->buffer[list->tail].value;
 		len = list->buffer[list->tail].len > count ?
 			count : list->buffer[list->tail].len;

Applied, good catch. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.