Skip to contentSkip to conversation

Convert Makefiles from COBJS-${} to COBJS-$()

PATCH New Kumar Gala 2 participants 2 messages May 21, 2010 – May 26, 2010 PowerPC

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 Convert Makefiles from COBJS-${} to COBJS-$()

Match style we use almost everywhere else

---
 arch/powerpc/cpu/mpc512x/Makefile    |   10 +++++-----
 board/freescale/common/Makefile      |   22 +++++++++++-----------
 board/freescale/mpc8610hpcd/Makefile |    2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)
arch/powerpc/cpu/mpc512x/Makefile +5 -5
index 9cfdb0f..28926e0 100644
@@ -37,11 +37,11 @@ COBJS-y += interrupts.o
 COBJS-y += iopin.o
 COBJS-y += serial.o
 COBJS-y += speed.o
-COBJS-${CONFIG_FSL_DIU_FB} += diu.o
-COBJS-${CONFIG_FSL_DIU_FB} += ../../../../board/freescale/common/fsl_diu_fb.o
-COBJS-${CONFIG_FSL_DIU_FB} += ../../../../board/freescale/common/fsl_logo_bmp.o
-COBJS-${CONFIG_CMD_IDE} += ide.o
-COBJS-${CONFIG_IIM} += iim.o
+COBJS-$(CONFIG_FSL_DIU_FB) += diu.o
+COBJS-$(CONFIG_FSL_DIU_FB) += ../../../../board/freescale/common/fsl_diu_fb.o
+COBJS-$(CONFIG_FSL_DIU_FB) += ../../../../board/freescale/common/fsl_logo_bmp.o
+COBJS-$(CONFIG_CMD_IDE) += ide.o
+COBJS-$(CONFIG_IIM) += iim.o
 COBJS-$(CONFIG_PCI) += pci.o
 
 COBJS	:= $(COBJS-y)
board/freescale/common/Makefile +11 -11
index 620eb16..df289aa 100644
@@ -29,18 +29,18 @@ endif
 
 LIB	= $(obj)lib$(VENDOR).a
 
-COBJS-${CONFIG_FSL_CADMUS}	+= cadmus.o
-COBJS-${CONFIG_FSL_VIA}		+= cds_via.o
-COBJS-${CONFIG_FSL_DIU_FB}	+= fsl_diu_fb.o fsl_logo_bmp.o
-COBJS-${CONFIG_FSL_PIXIS}	+= pixis.o
-COBJS-${CONFIG_FSL_NGPIXIS}	+= ngpixis.o
-COBJS-${CONFIG_PQ_MDS_PIB}	+= pq-mds-pib.o
-COBJS-${CONFIG_ID_EEPROM}	+= sys_eeprom.o
-COBJS-${CONFIG_FSL_SGMII_RISER}	+= sgmii_riser.o
+COBJS-$(CONFIG_FSL_CADMUS)	+= cadmus.o
+COBJS-$(CONFIG_FSL_VIA)		+= cds_via.o
+COBJS-$(CONFIG_FSL_DIU_FB)	+= fsl_diu_fb.o fsl_logo_bmp.o
+COBJS-$(CONFIG_FSL_PIXIS)	+= pixis.o
+COBJS-$(CONFIG_FSL_NGPIXIS)	+= ngpixis.o
+COBJS-$(CONFIG_PQ_MDS_PIB)	+= pq-mds-pib.o
+COBJS-$(CONFIG_ID_EEPROM)	+= sys_eeprom.o
+COBJS-$(CONFIG_FSL_SGMII_RISER)	+= sgmii_riser.o
 
-COBJS-${CONFIG_MPC8541CDS}	+= cds_pci_ft.o
-COBJS-${CONFIG_MPC8548CDS}	+= cds_pci_ft.o
-COBJS-${CONFIG_MPC8555CDS}	+= cds_pci_ft.o
+COBJS-$(CONFIG_MPC8541CDS)	+= cds_pci_ft.o
+COBJS-$(CONFIG_MPC8548CDS)	+= cds_pci_ft.o
+COBJS-$(CONFIG_MPC8555CDS)	+= cds_pci_ft.o
 
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
board/freescale/mpc8610hpcd/Makefile +1 -1
index 930a206..847edaf 100644
@@ -27,7 +27,7 @@ COBJS-y	+= $(BOARD).o
 COBJS-$(CONFIG_FSL_DDR2) += ddr.o
 COBJS-y	+= law.o
 
-COBJS-${CONFIG_FSL_DIU_FB}	+= mpc8610hpcd_diu.o
+COBJS-$(CONFIG_FSL_DIU_FB)	+= mpc8610hpcd_diu.o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS-y))
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 1/1 Convert Makefiles from COBJS-${} to COBJS-$()

Dear Kumar Gala,

Quoted 8 lines · In message <[email protected]> you…

Match style we use almost everywhere else

---
 arch/powerpc/cpu/mpc512x/Makefile    |   10 +++++-----
 board/freescale/common/Makefile      |   22 +++++++++++-----------
 board/freescale/mpc8610hpcd/Makefile |    2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hindsight is an exact science.