stm: select CONFIG_SRCU
Subsystems (3)
PATCH 1/1 stm: select CONFIG_SRCU
The newly added STM code uses SRCU, but does not ensure that this code is part of the kernel:
drivers/built-in.o: In function `stm_source_link_show':include/linux/srcu.h:221: undefined reference to __srcu_read_lock' include/linux/srcu.h:238: undefined reference to __srcu_read_unlock' drivers/built-in.o: In function `stm_source_link_drop':include/linux/srcu.h:221: undefined reference to __srcu_read_lock' include/linux/srcu.h:238: undefined reference to __srcu_read_unlock'
This adds a Kconfig 'select' statement like all the other SRCU using drivers have.
---
drivers/hwtracing/stm/Kconfig +1 -0
@@ -1,6 +1,7 @@ config STM tristate "System Trace Module devices" select CONFIGFS_FS + select SRCU help A System Trace Module (STM) is a device exporting data in System Trace Protocol (STP) format as defined by MIPI STP standards.
Quoted 10 lines · Arnd Bergmann
The newly added STM code uses SRCU, but does not ensure that this code is part of the kernel:
drivers/built-in.o: In function `stm_source_link_show':include/linux/srcu.h:221: undefined reference to__srcu_read_lock' include/linux/srcu.h:238: undefined reference to__srcu_read_unlock'drivers/built-in.o: In function `stm_source_link_drop':include/linux/srcu.h:221: undefined reference to__srcu_read_lock' include/linux/srcu.h:238: undefined reference to__srcu_read_unlock'
Quoted 5 lines
This adds a
Kconfig'select' statement like all the other SRCU using drivers have.Signed-off-by Arnd Bergmann <[email protected]>Fixes 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Related to this, I have to ask why if I answer to N to STM, I'm then presented with the STM driver options in this file. It's not like they'll be built, as drivers/Makefile has:
obj-$(CONFIG_STM) += hwtracing/stm/
so it seems rather pointless.. Maybe the other options here should be wrapped with if STM..endif ?
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Alexander Shishkin
maintainerQuoted 10 lines · Arnd Bergmann
The newly added STM code uses SRCU, but does not ensure that this code is part of the kernel:
drivers/built-in.o: In function `stm_source_link_show':include/linux/srcu.h:221: undefined reference to__srcu_read_lock' include/linux/srcu.h:238: undefined reference to__srcu_read_unlock'drivers/built-in.o: In function `stm_source_link_drop':include/linux/srcu.h:221: undefined reference to__srcu_read_lock' include/linux/srcu.h:238: undefined reference to__srcu_read_unlock'
Quoted 5 lines
This adds a
Kconfig'select' statement like all the other SRCU using drivers have.Signed-off-by Arnd Bergmann <[email protected]>Fixes 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Thanks!