Skip to contentSkip to conversation

Subject: Bug#308136: Debian bug 308136 (SEGV in pppd)

PATCH In review Alexey Mahotkin 1 participant 1 message May 27, 2010 PPP protocol drivers and compressors

lore
Share & tools
lore
#0 lore raw

PATCH 4/6 Subject: Bug#308136: Debian bug 308136 (SEGV in pppd)

From: Martin Lottermoser <[email protected]>

The function update_db_entry() may only be called if pppdb is not NULL; unfortunately in this situation it is. Other calls to update_db_entry() are protected against this, see, e.g., the end of script_setenv().

---
 pppd/main.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
pppd/main.c +5 -3
index 014d614..3cc2624 100644
@@ -1957,9 +1957,11 @@ script_setenv(var, value, iskey)
 		free(p-1);
 		script_env[i] = newstring;
 #ifdef USE_TDB
-		if (iskey && pppdb != NULL)
-		    add_db_key(newstring);
-		update_db_entry();
+		if (pppdb != NULL) {
+		    if (iskey)
+			add_db_key(newstring);
+		    update_db_entry();
+		}
 #endif
 		return;
 	    }
Signature · 1 line
1.6.2.5