Gspca-gl860 driver update

PATCH In review Olivier Lorin 1 participant 1 message May 30, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Olivier Lorin

author

2010-05-30 22:27 UTC #0 lore raw

PATCH 3/3 Gspca-gl860 driver update

gspca - gl860: minor functional changes

From: Olivier Lorin <[email protected]>

- Setting changes applied after an end of image marker reception This is the way MI2020 sensor works.
It seems to be logical to wait for a complete image before to change a setting.
- 1 ms "msleep" applied to each sensor after USB control data exchange This was done for two sensors because these exchanges were known to be too quick depending on laptop model.
It should be fairly logical to apply this delay to each sensor in order to prevent from having errors with untested hardwares.

Priority: normal

Signed-off-by Olivier Lorin <[email protected]>

gl860.c +2 -5

diff -urpN der_gl860i3/gl860.c gl860/gl860.c
@@ -63,7 +63,7 @@ static int sd_set_##thename(struct gspca
 \
 	sd->vcur.thename = val;\
 	if (gspca_dev->streaming)\
-		sd->dev_camera_settings(gspca_dev);\
+		sd->waitSet = 1;\
 	return 0;\
 } \
 static int sd_get_##thename(struct gspca_dev *gspca_dev, s32 *val)\

@@ -595,10 +595,7 @@ int gl860_RTx(struct gspca_dev *gspca_de
 	else if (len > 1 && r < len)
 		PDEBUG(D_ERR, "short ctrl transfer %d/%d", r, len);
 
-	if (_MI2020_ && (val || index))
-		msleep(1);
-	if (_OV2640_)
-		msleep(1);
+	msleep(1);
 
 	return r;
 }