Skip to contentSkip to conversation

mfd-core: properly handle platform_device_add_resources fail in mfd_add_device

PATCH In review Axel Lin 2 participants 2 messages May 31, 2010 – Jun 18, 2010 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd-core: properly handle platform_device_add_resources fail in mfd_add_device

platform_device_add_resources may fail, thus add error checking for it.

---
 drivers/mfd/mfd-core.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/mfd/mfd-core.c +3 -1
index 7dd76bc..1823a57 100644
@@ -70,7 +70,9 @@ static int mfd_add_device(struct device *parent, int id,
 			goto fail_res;
 	}
 
-	platform_device_add_resources(pdev, res, cell->num_resources);
+	ret = platform_device_add_resources(pdev, res, cell->num_resources);
+	if (ret)
+		goto fail_res;
 
 	ret = platform_device_add(pdev);
 	if (ret)
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 1 line · Axel Lin

platform_device_add_resources may fail, thus add error checking for it.

Thanks Axel, patch applied.

Cheers,
Samuel.

Quoted 25 lines
---
 drivers/mfd/mfd-core.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/mfd/mfd-core.c +3 -1
index 7dd76bc..1823a57 100644
@@ -70,7 +70,9 @@ static int mfd_add_device(struct device *parent, int id,
 			goto fail_res;
 	}
 
-	platform_device_add_resources(pdev, res, cell->num_resources);
+	ret = platform_device_add_resources(pdev, res, cell->num_resources);
+	if (ret)
+		goto fail_res;
 
 	ret = platform_device_add(pdev);
 	if (ret)
Signature · 1 line
1.5.4.3
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/