Skip to contentSkip to conversation

ahci: drop ATAPI_CMD constants

PATCH In review Sebastian Herbszt 2 participants 2 messages May 31, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ahci: drop ATAPI_CMD constants

Drop not used ATAPI_CMD constants.

hw/ahci.c +0 -15
index 9987459..a024706 100644
@@ -179,21 +179,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define ATA_CMD_WRITE_EXT	0x34	/* Write Sectores (with retries) with 48bit addressing */
 #define ATA_CMD_VRFY_EXT	0x42	/* Read Verify	(with retries)	with 48bit addressing */
 
-/*
- * ATAPI Commands
- */
-#define ATAPI_CMD_IDENT 0xA1 /* Identify AT Atachment Packed Interface Device */
-#define ATAPI_CMD_PACKET 0xA0 /* Packed Command */
-
-
-#define ATAPI_CMD_INQUIRY 0x12
-#define ATAPI_CMD_REQ_SENSE 0x03
-#define ATAPI_CMD_READ_CAP 0x25
-#define ATAPI_CMD_START_STOP 0x1B
-#define ATAPI_CMD_READ_12 0xA8
-
-
-
 typedef struct ahci_control_regs {
 	uint32_t  cap;
 	uint32_t  ghc;
#1 lore raw
Quoted 1 line · Sebastian Herbszt

Drop not used ATAPI_CMD constants.

I'd postpone that. We should get rid of _all_ ATA and ATAPI commands in ahci.c, but that'll be part of a bigger cleanup. IMHO we should reuse the IDE core for those.

Alex