: libertas: fix uninitialized variable warning
PATCH 1/1 : libertas: fix uninitialized variable warning
Fixes:
drivers/net/wireless/libertas/rx.c: In function ‘process_rxed_802_11_packet’:drivers/net/wireless/libertas/rx.c:354: error: ‘radiotap_hdr.flags’ may be used uninitialized in this function
Signed-off-by Prarit Bhargava <[email protected]>
drivers/net/wireless/libertas/rx.c +2 -3
@@ -330,9 +330,8 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,/* create the exported radio header */ /* radiotap header */ - radiotap_hdr.hdr.it_version =0 ; -/* XXX must check this value for pad */ - radiotap_hdr.hdr.it_pad =0 ; +memset (&radiotap_hdr,0 ,sizeof (radiotap_hdr)); +/* XXX must check radiotap_hdr.hdr.it_pad for pad */ radiotap_hdr.hdr.it_len =cpu_to_le16 (sizeof (struct rx_radiotap_hdr )); radiotap_hdr.hdr.it_present =cpu_to_le32 (RX_RADIOTAP_PRESENT ); radiotap_hdr.rate =convert_mv_rate_to_radiotap (prxpd->rx_rate);
Quoted 6 lines · Prarit Bhargava
Fixes:
drivers/net/wireless/libertas/rx.c: In function ‘process_rxed_802_11_packet’:drivers/net/wireless/libertas/rx.c:354: error: ‘radiotap_hdr.flags’ may be used uninitialized in this functionSigned-off-by Prarit Bhargava <[email protected]>
Acked-by Dan Williams <[email protected]>
Quoted 21 lines
drivers/net/wireless/libertas/rx.c +2
-4@@ -330,9 +330,8 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,/* create the exported radio header */ /* radiotap header */ - radiotap_hdr.hdr.it_version =0 ; -/* XXX must check this value for pad */ - radiotap_hdr.hdr.it_pad =0 ; +memset (&radiotap_hdr,0 ,sizeof (radiotap_hdr)); +/* XXX must check radiotap_hdr.hdr.it_pad for pad */ radiotap_hdr.hdr.it_len =cpu_to_le16 (sizeof (struct rx_radiotap_hdr )); radiotap_hdr.hdr.it_present =cpu_to_le32 (RX_RADIOTAP_PRESENT ); radiotap_hdr.rate =convert_mv_rate_to_radiotap (prxpd->rx_rate); --To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html