Skip to contentSkip to conversation

backlight: Fix blanking for LMS283GF05 LCD

PATCH New Marek Vasut 2 participants 4 messages Jun 5, 2010

Subsystems (2)
Framebuffer layer Backlight class/subsystem
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/2 backlight: Fix blanking for LMS283GF05 LCD

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in every case but POWERDOWN.

Signed-off-by Marek Vasut <[email protected]>
---
 drivers/video/backlight/lms283gf05.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/lms283gf05.c +1 -1
index abc43a0..5d3cf33 100644
@@ -129,7 +129,7 @@ static int lms283gf05_power_set(struct lcd_device *ld, int power)
 	struct spi_device *spi = st->spi;
 	struct lms283gf05_pdata *pdata = spi->dev.platform_data;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (pdata)
 			lms283gf05_reset(pdata->reset_gpio,
 					pdata->reset_inverted);
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in every case but POWERDOWN.

Signed-off-by Marek Vasut <[email protected]>
---
 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -1
index 9093ef0..c67801e 100644
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (priv->lcd_on)
 			return 0;
Signature · 1 line
1.7.1
#2 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

Quoted 2 lines · Marek Vasut

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in every case but POWERDOWN.

The patch is ok for me, but the comment could much more reflect what the patch does, no?

Quoted 19 lines
Signed-off-by Marek Vasut <[email protected]>
---
 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -1
index 9093ef0..c67801e 100644
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (priv->lcd_on)
 			return 0;
author
#3 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

Dne So 5. ?ervna 2010 11:25:24 Alberto Panizzo napsal(a):

Quoted 6 lines · Marek Vasut
Quoted 2 lines

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in every case but POWERDOWN.

The patch is ok for me, but the comment could much more reflect what the patch does, no?

Thanks for validating my work, we'll have another round ;)

Quoted 23 lines
Quoted 23 lines
Signed-off-by Marek Vasut <[email protected]>

---

 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/video/backlight/l4f00242t03.c index 9093ef0..c67801e 100644

drivers/video/backlight/l4f00242t03.c +1 -1
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device
 *ld, int power)
 
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
drivers/video/backlight/l4f00242t03.c +0 -0
 		if (priv->lcd_on)
 
 			return 0;