Skip to contentSkip to conversation

backlight: Fix blanking for LMS283GF05 LCD

PATCH New Marek Vasut 3 participants 5 messages Jun 5, 2010 – Nov 5, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 backlight: Fix blanking for LMS283GF05 LCD

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in NORMAL and UNBLANK case.

---
 drivers/video/backlight/lms283gf05.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/lms283gf05.c +1 -1
index abc43a0..5d3cf33 100644
@@ -129,7 +129,7 @@ static int lms283gf05_power_set(struct lcd_device *ld, int power)
 	struct spi_device *spi = st->spi;
 	struct lms283gf05_pdata *pdata = spi->dev.platform_data;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (pdata)
 			lms283gf05_reset(pdata->reset_gpio,
 					pdata->reset_inverted);
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in NORMAL and UNBLANK case.

---
 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -1
index 9093ef0..c67801e 100644
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (priv->lcd_on)
 			return 0;
 
Signature · 1 line
1.7.1
#2 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

Quoted 4 lines · Marek Vasut

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in NORMAL and UNBLANK case.

Richard,
Are you still maintaining the backlight tree?
These two patches never hit the mainline since gen, I hope this will happen soon since they really fix bugs :)

Best Regards,
Alberto!

Oh, add also this tag if possible:

Quoted 17 lines
---
 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -1
index 9093ef0..c67801e 100644
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (priv->lcd_on)
 			return 0;
 
Signature · 4 lines
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)
#3 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

Quoted 11 lines · Alberto Panizzo
Quoted 4 lines · Marek Vasut

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in NORMAL and UNBLANK case.

Richard,
Are you still maintaining the backlight tree?
These two patches never hit the mainline since gen, I hope this will happen soon since they really fix bugs :)

Quoted 6 lines

Best Regards,
Alberto!

Oh, add also this tag if possible:

I've talked with Andrew Morton and we've come up with a new plan to handle the backlight patches. I acked these the other day and they should be heading into -rc2.

Cheers,

Richard

Quoted 19 lines
Quoted 17 lines
---
 drivers/video/backlight/l4f00242t03.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -1
index 9093ef0..c67801e 100644
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
 	const u16 slpin = 0x10;
 	const u16 disoff = 0x28;
 
-	if (power) {
+	if (power <= FB_BLANK_NORMAL) {
 		if (priv->lcd_on)
 			return 0;
 
#4 lore raw

PATCH 2/2 backlight: Fix blanking for L4F00242T03 LCD

Quoted 19 lines · Richard Purdie
Quoted 11 lines · Alberto Panizzo
Quoted 4 lines · Marek Vasut

The LCD was turned on if the variable power was > 0, but that was incorrect. The LCD has to be turned on in NORMAL and UNBLANK case.

Richard,
Are you still maintaining the backlight tree?
These two patches never hit the mainline since gen, I hope this will happen soon since they really fix bugs :)

Quoted 6 lines

Best Regards,
Alberto!

Oh, add also this tag if possible:

Quoted 7 lines

I've talked with Andrew Morton and we've come up with a new plan to handle the backlight patches. I acked these the other day and they should be heading into -rc2.

Cheers,

Richard

Ok, thank you for the quick answer!

Cheers,

Signature · 4 lines
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)