Skip to contentSkip to conversation

alsa:patch_realtek.c Add SSID table for MacBookAir2,1

PATCH In review Justin P. Mattock 2 participants 8 messages Jun 6, 2010 – Jun 8, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 alsa:patch_realtek.c Add SSID table for MacBookAir2,1

This adds the SSID number to snd_pci_quirk for the MacBookAir2,1 taken from codec#0 at:
http://launchpadlibrarian.net/49455483/Card0.Codecs.codec.0.txt
keep in mind I do not have one of these machines on hand so please if you do have this machine please test for me..

---
 sound/pci/hda/patch_realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/pci/hda/patch_realtek.c +1 -0
index 17d4548..9b82d28 100644
@@ -9487,6 +9487,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4100, "Macmini 3,1", ALC885_MACMINI3),
+	SND_PCI_QUIRK(0x106b, 0x3500, "MacBookAir 2,1", ALC885_MBA21),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.5.2.180.gc5b3e
#1 lore raw

PATCH 2/5 alsa:patch_realtek.c Add support for the MacBookAir1,1

Note: The below patch does not work with patch 3/5 (Add-SSID-table-for-MacBookAir1-1)

I'm giving the option of either adding/creating a whole new section for the MacBookAir1,1 and or just add the SSID for the MacBookAir1,1 using ALC885_MBP3 (Add-SSID-table-for-MacBookAir1-1).

Below is a patch that add's support to the MacBookAir1,1 to patch_realtek.c to enable it's functions for sound mic, etc..
the bug entry is located here:
https://bugs.launchpad.net/mactel-support/+bug/268301
Also cleans up some coding fixes for:ALC885_MBA21

Note:I do not have this machine on hand only
codec#0 file for the machine so please
test if you have the appropriate equipment.
And also keep in mind I did look at both
the MacBookAir1,1(2,1) both seem to display
no info on what/where the mic is in their codec#0
file..(hopefully that can get resolved).

---
 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |   78 ++++++++++++++++++++++----
 2 files changed, 68 insertions(+), 11 deletions(-)
Documentation/sound/alsa/HD-Audio-Models.txt +1 -0
index 1d38b0d..d3838b5 100644
@@ -125,6 +125,7 @@ ALC882/883/885/888/889
   macpro	MacPro support
   mb5		Macbook 5,1
   macmini3	Macmini 3,1
+  mba11		MacBook Air 1,1
   mba21		Macbook Air 2,1
   mbp3		Macbook Pro rev3
   imac24	iMac 24'' with jack detection
sound/pci/hda/patch_realtek.c +67 -11

114 lines not on this page · raw message

Signature · 1 line
1.6.5.2.180.gc5b3e
#2 lore raw

PATCH 3/5 alsa:patch_realtek.c Add SSID table for MacBookAir1,1

Note: This patch does not work with Patch 2/5 (Add-support-for-the-MacBookAir1-1).

This patch add's the MacBookAir1,1 SSID entry to patch_realtek.c which adds sound support. bug entry:
https://bugs.launchpad.net/mactel-support/+bug/268301

Note:I do not have this machine on hand only codec#0 file for the machine so please test if you have the appropriate equipment.

---
 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Documentation/sound/alsa/HD-Audio-Models.txt +1 -0
index 1d38b0d..d3838b5 100644
@@ -125,6 +125,7 @@ ALC882/883/885/888/889
   macpro	MacPro support
   mb5		Macbook 5,1
   macmini3	Macmini 3,1
+  mba11		MacBook Air 1,1
   mba21		Macbook Air 2,1
   mbp3		Macbook Pro rev3
   imac24	iMac 24'' with jack detection
sound/pci/hda/patch_realtek.c +1 -0
index 17d4548..149b375 100644
@@ -9487,6 +9487,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4100, "Macmini 3,1", ALC885_MACMINI3),
+	SND_PCI_QUIRK(0x106b, 0x3400, "MacBookAir 1,1", ALC885_MBP3),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.5.2.180.gc5b3e
#3 lore raw

PATCH 4/5 alsa:patch_realtek.c Add support for the iMac7,1

Note: The below patch does not work with patch 5/5 (Add-SSID-table-for-iMac7-1)
I'm giving the option of either adding/creating a whole new section for the iMac7,1 and or just add the SSID for the iMac7,1 using ALC882_ASUS_A7M stated on bug entry:
https://bugs.launchpad.net/mactel-support/+bug/360866

Note:I do not have this machine on hand only codec#0 file for the machine so please
test if you have the appropriate equipment.

---
 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |   62 ++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 0 deletions(-)
Documentation/sound/alsa/HD-Audio-Models.txt +1 -0
index 1d38b0d..a9aac53 100644
@@ -127,6 +127,7 @@ ALC882/883/885/888/889
   macmini3	Macmini 3,1
   mba21		Macbook Air 2,1
   mbp3		Macbook Pro rev3
+  imac71	iMac 7,1
   imac24	iMac 24'' with jack detection
   imac91	iMac 9,1
   w2jc		ASUS W2JC
sound/pci/hda/patch_realtek.c +62 -0

105 lines not on this page · raw message

Signature · 1 line
1.6.5.2.180.gc5b3e
#4 lore raw

PATCH 5/5 alsa:patch_realtek.c Add SSID table for iMac7,1.

Note: This patch does not work with Patch 4/5 (Add-support-for-the-iMac7-1).

This patch add's the iMac7,1 SSID entry to patch_realtek.c which adds sound support. bug entry:
https://bugs.launchpad.net/mactel-support/+bug/360866

Note:I do not have this machine on hand only codec#0 file for the machine so please test if you have the appropriate equipment.

---
 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Documentation/sound/alsa/HD-Audio-Models.txt +1 -0
index 1d38b0d..a9aac53 100644
@@ -127,6 +127,7 @@ ALC882/883/885/888/889
   macmini3	Macmini 3,1
   mba21		Macbook Air 2,1
   mbp3		Macbook Pro rev3
+  imac71	iMac 7,1
   imac24	iMac 24'' with jack detection
   imac91	iMac 9,1
   w2jc		ASUS W2JC
sound/pci/hda/patch_realtek.c +1 -0
index 17d4548..a4f71fb 100644
@@ -9478,6 +9478,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC885_MBP3),
 	SND_PCI_QUIRK(0x106b, 0x3600, "Macbook 3,1", ALC889A_MB31),
 	SND_PCI_QUIRK(0x106b, 0x3800, "MacbookPro 4,1", ALC885_MBP3),
+	SND_PCI_QUIRK(0x106b, 0x3200, "iMac 7,1 Aluminum", ALC882_ASUS_A7M),
 	SND_PCI_QUIRK(0x106b, 0x3e00, "iMac 24 Aluminum", ALC885_IMAC24),
 	SND_PCI_QUIRK(0x106b, 0x4900, "iMac 9,1 Aluminum", ALC885_IMAC91),
 	SND_PCI_QUIRK(0x106b, 0x3f00, "Macbook 5,1", ALC885_MB5),
Signature · 1 line
1.6.5.2.180.gc5b3e
#5 lore raw
In reply to Justin P. Mattock

At Sun, 6 Jun 2010 16:09:49 -0700,

Quoted 8 lines · Justin P. Mattock

This adds the SSID number to snd_pci_quirk for the MacBookAir2,1 taken from codec#0 at:
http://launchpadlibrarian.net/49455483/Card0.Codecs.codec.0.txt
keep in mind I do not have one of these machines on hand so please if you do have this machine please test for me..

I applied this one (after rearranging the quirk list order).

Also the patch 3 and 5, both one-liner additions of a quirk, are applied, too, since they got tested somehow in bug reports.

Could you rebase your changes for the proper MBA 1,1 and imac 7,1 against the latest sound tree so that anyone can test them? If they work better, then we can apply later your changes in addition.

Thanks!

Takashi

Quoted 19 lines
---
 sound/pci/hda/patch_realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/pci/hda/patch_realtek.c +1 -0
index 17d4548..9b82d28 100644
@@ -9487,6 +9487,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
 	SND_PCI_QUIRK(0x106b, 0x4100, "Macmini 3,1", ALC885_MACMINI3),
+	SND_PCI_QUIRK(0x106b, 0x3500, "MacBookAir 2,1", ALC885_MBA21),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.5.2.180.gc5b3e
#6 lore raw
Quoted 16 lines · Takashi Iwai

At Sun, 6 Jun 2010 16:09:49 -0700,

Quoted 8 lines · Justin P. Mattock

This adds the SSID number to snd_pci_quirk for the MacBookAir2,1 taken from codec#0 at:
http://launchpadlibrarian.net/49455483/Card0.Codecs.codec.0.txt
keep in mind I do not have one of these machines on hand so please if you do have this machine please test for me..

I applied this one (after rearranging the quirk list order).

Also the patch 3 and 5, both one-liner additions of a quirk, are applied, too, since they got tested somehow in bug reports.

Quoted 9 lines

Could you rebase your changes for the proper MBA 1,1 and imac 7,1 against the latest sound tree so that anyone can test them? If they work better, then we can apply later your changes in addition.

Thanks!

Takashi

o.k. cool..
I'll rebase those two patches and send them out
(hopefully people test)..

Quoted 16 lines
Quoted 16 lines
---
  sound/pci/hda/patch_realtek.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
sound/pci/hda/patch_realtek.c +1 -0
index 17d4548..9b82d28 100644
@@ -9487,6 +9487,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
  	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
  	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
  	SND_PCI_QUIRK(0x106b, 0x4100, "Macmini 3,1", ALC885_MACMINI3),
+	SND_PCI_QUIRK(0x106b, 0x3500, "MacBookAir 2,1", ALC885_MBA21),
  	{} /* terminator */
  };
 
Quoted 4 lines
Quoted 3 lines

--
1.6.5.2.180.gc5b3e

cheers,

Justin P. Mattock

#7 lore raw
In reply to Takashi Iwai
Quoted 16 lines · Takashi Iwai

At Sun, 6 Jun 2010 16:09:49 -0700,

Quoted 8 lines · Justin P. Mattock

This adds the SSID number to snd_pci_quirk for the MacBookAir2,1 taken from codec#0 at:
http://launchpadlibrarian.net/49455483/Card0.Codecs.codec.0.txt
keep in mind I do not have one of these machines on hand so please if you do have this machine please test for me..

I applied this one (after rearranging the quirk list order).

Also the patch 3 and 5, both one-liner additions of a quirk, are applied, too, since they got tested somehow in bug reports.

Quoted 8 lines

Could you rebase your changes for the proper MBA 1,1 and imac 7,1 against the latest sound tree so that anyone can test them? If they work better, then we can apply later your changes in addition.

Thanks!

Takashi

o.k. rebased these two against
the latest sound tree..noticed
a couple of messups which are fixed now (Note to myself: when tired don't code)..

hopefully people test these and see..

cheers,

Justin P. Mattock