Skip to contentSkip to conversation

script:conf.c Fix warning: variable 'type' set but not used

PATCH In review Justin P. Mattock 2 participants 3 messages Jun 11, 2010 Kconfig

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 script:conf.c Fix warning: variable 'type' set but not used

Not sure if this is correct or not, but with
make menuconfig
HOSTCC scripts/kconfig/conf.o
scripts/kconfig/conf.c: In function 'conf_sym':
scripts/kconfig/conf.c:159:6: warning: variable 'type' set but not used scripts/kconfig/conf.c: In function 'conf_choice':
scripts/kconfig/conf.c:231:6: warning: variable 'type' set but not used
HOSTLD scripts/kconfig/mconf

I get this using gcc 4.6.0 the below change fixes this form me. (not sure with earlier version of gcc).
please have a look and let me know.

---
 scripts/kconfig/conf.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
scripts/kconfig/conf.c +0 -4
index 9960d1c..d6369e8 100644
@@ -156,14 +156,12 @@ static int conf_string(struct menu *menu)
 static int conf_sym(struct menu *menu)
 {
 	struct symbol *sym = menu->sym;
-	int type;
 	tristate oldval, newval;
 
 	while (1) {
 		printf("%*s%s ", indent - 1, "", _(menu->prompt->text));
 		if (sym->name)
 			printf("(%s) ", sym->name);
-		type = sym_get_type(sym);
 		putchar('[');
 		oldval = sym_get_tristate_value(sym);
 		switch (oldval) {
@@ -228,11 +226,9 @@ static int conf_choice(struct menu *menu)
 {
 	struct symbol *sym, *def_sym;
 	struct menu *child;
-	int type;
 	bool is_new;
 
 	sym = menu->sym;
-	type = sym_get_type(sym);
 	is_new = !sym_has_value(sym);
 	if (sym_is_changable(sym)) {
 		conf_sym(menu);
Signature · 1 line
1.7.1.rc1.21.gf3bd6
#1 lore raw
Quoted 5 lines

I get this using gcc 4.6.0 the below change fixes this form me. (not sure with earlier version of gcc).
please have a look and let me know.

From a quick look it's likely correct, but you really need

to send this to the Kconfig maintainer, not to me.

-Andi

#2 lore raw
Quoted 9 lines · Andi Kleen
Quoted 5 lines

I get this using gcc 4.6.0 the below change fixes this form me. (not sure with earlier version of gcc).
please have a look and let me know.

From a quick look it's likely correct, but you really need

to send this to the Kconfig maintainer, not to me.

-Andi

alright.. I've another one (hopefully right), so I'll just go through the list of warnings then with what I get out of i'll compose a list of cc's/patches to the appropriate person.

Justin P. Mattock