Skip to contentSkip to conversation

device-assignment, msi: PBA is long

PATCH Applied Hidetoshi Seto 3 participants 3 messages Jun 17, 2010 – Jun 18, 2010 KVM

lore
Share & tools
lore

Hidetoshi Seto

author
#0 lore raw

PATCH 1/1 device-assignment, msi: PBA is long

Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte() by the commit:
commit a81a1f0a7410976be7dbc9a81524a8640f446ab5
Author: Alex Williamson <[email protected]>
device-assignment: Don't use libpci

Signed-off-by Hidetoshi Seto <[email protected]>
---
 hw/device-assignment.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
hw/device-assignment.c +1 -1
index e254203..e237bd3 100644
@@ -1263,7 +1263,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
                       pci_dev->cap.length + PCI_MSIX_TABLE) = msix_table_entry;
         *(uint32_t *)(pci_dev->config + pci_dev->cap.start +
                       pci_dev->cap.length + PCI_MSIX_PBA) =
-                    assigned_dev_pci_read_byte(pci_dev, pos + PCI_MSIX_PBA);
+                    assigned_dev_pci_read_long(pci_dev, pos + PCI_MSIX_PBA);
         bar_nr = msix_table_entry & PCI_MSIX_BIR;
         msix_table_entry &= ~PCI_MSIX_BIR;
         dev->msix_table_addr = pci_region[bar_nr].base_addr + msix_table_entry;
Signature · 1 line
1.7.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Hidetoshi Seto

Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte() by the commit:
commit a81a1f0a7410976be7dbc9a81524a8640f446ab5
Author: Alex Williamson <[email protected]>
device-assignment: Don't use libpci

Signed-off-by Hidetoshi Seto <[email protected]>
---
 hw/device-assignment.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Oops.

Acked-by Alex Williamson <[email protected]>
Quoted 13 lines
hw/device-assignment.c +1 -1
index e254203..e237bd3 100644
@@ -1263,7 +1263,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
                       pci_dev->cap.length + PCI_MSIX_TABLE) = msix_table_entry;
         *(uint32_t *)(pci_dev->config + pci_dev->cap.start +
                       pci_dev->cap.length + PCI_MSIX_PBA) =
-                    assigned_dev_pci_read_byte(pci_dev, pos + PCI_MSIX_PBA);
+                    assigned_dev_pci_read_long(pci_dev, pos + PCI_MSIX_PBA);
         bar_nr = msix_table_entry & PCI_MSIX_BIR;
         msix_table_entry &= ~PCI_MSIX_BIR;
         dev->msix_table_addr = pci_region[bar_nr].base_addr + msix_table_entry;