Skip to contentSkip to conversation

cifs: guard cifsglob.h against multiple inclusion

RFC PATCH In review Suresh Jayaraman 2 participants 2 messages Jun 22, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 2/10 cifs: guard cifsglob.h against multiple inclusion

Add conditional compile macros to guard the header file against multiple inclusion.

---
 fs/cifs/cifsglob.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
fs/cifs/cifsglob.h +5 -0
index a88479c..6b2c39d 100644
@@ -16,6 +16,9 @@
  *   the GNU Lesser General Public License for more details.
  *
  */
+#ifndef _CIFS_GLOB_H
+#define _CIFS_GLOB_H
+
 #include <linux/in.h>
 #include <linux/in6.h>
 #include <linux/slab.h>
@@ -733,3 +736,5 @@ GLOBAL_EXTERN unsigned int cifs_min_small;  /* min size of small buf pool */
 GLOBAL_EXTERN unsigned int cifs_max_pending; /* MAX requests at once to server*/
 
 extern const struct slow_work_ops cifs_oplock_break_ops;
+
+#endif	/* _CIFS_GLOB_H */
Signature · 1 line
1.6.4.2
Acked-by on v1 2/10
#1 lore raw
Quoted 23 lines · On Tue, 22 Jun 2010 20:52:50 +0530 Suresh Jayaraman <[email protected]> wrote:

Add conditional compile macros to guard the header file against multiple inclusion.

---
 fs/cifs/cifsglob.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
fs/cifs/cifsglob.h +3 -0
index a88479c..6b2c39d 100644
@@ -16,6 +16,9 @@
  *   the GNU Lesser General Public License for more details.
  *
  */
+#ifndef _CIFS_GLOB_H
+#define _CIFS_GLOB_H
+
 #include <linux/in.h>
 #include <linux/in6.h>
 #include <linux/slab.h>

fs/cifs/cifsglob.h GLOBAL_EXTERN unsigned int cifs_min_small; /* min size of small buf pool */ · line 740

Quoted 5 lines
fs/cifs/cifsglob.h +2 -0
@@ -733,3 +736,5 @@ GLOBAL_EXTERN unsigned int cifs_min_small;  /* min size of small buf pool */
 GLOBAL_EXTERN unsigned int cifs_max_pending; /* MAX requests at once to server*/
 
 extern const struct slow_work_ops cifs_oplock_break_ops;
+
+#endif	/* _CIFS_GLOB_H */

Strong ACK