fbcon: deinline four foo_update_attr() functions

PATCH New Denys Vlasenko 1 participant 1 message Jun 24, 2010

Subsystems (2)

Framebuffer layer Console

lore

Share & tools

lore

Denys Vlasenko

author

2010-06-24 03:21 UTC #0 lore raw

PATCH 1/1 fbcon: deinline four foo_update_attr() functions

This patch deinlines four similar functions, foo_update_attr(), in four fbcon-related files.
These functions contain loops, two of theam have _hested_ loops, and they have more than one callsite each.
I think they should not be inlined.

Signed-off-by Denys Vlasenko <[email protected]>

---
 drivers/video/console/bitblit.c   |    2 +-
 drivers/video/console/fbcon_ccw.c |    2 +-
 drivers/video/console/fbcon_cw.c  |    2 +-
 drivers/video/console/fbcon_ud.c  |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

drivers/video/console/bitblit.c +1 -1

index af88651..28b1a83 100644
@@ -22,7 +22,7 @@
 /*
  * Accelerated handlers.
  */
-static inline void update_attr(u8 *dst, u8 *src, int attribute,
+static void update_attr(u8 *dst, u8 *src, int attribute,
 			       struct vc_data *vc)
 {
 	int i, offset = (vc->vc_font.height < 10) ? 1 : 2;

drivers/video/console/fbcon_ccw.c +1 -1

index d135671..41b32ae 100644
@@ -22,7 +22,7 @@
  * Rotation 270 degrees
  */
 
-static inline void ccw_update_attr(u8 *dst, u8 *src, int attribute,
+static void ccw_update_attr(u8 *dst, u8 *src, int attribute,
 				  struct vc_data *vc)
 {
 	int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;

drivers/video/console/fbcon_cw.c +1 -1

index 126110f..6a73782 100644
@@ -22,7 +22,7 @@
  * Rotation 90 degrees
  */
 
-static inline void cw_update_attr(u8 *dst, u8 *src, int attribute,
+static void cw_update_attr(u8 *dst, u8 *src, int attribute,
 				  struct vc_data *vc)
 {
 	int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;

drivers/video/console/fbcon_ud.c +1 -1

index 93a3e73..ff0872c 100644
@@ -22,7 +22,7 @@
  * Rotation 180 degrees
  */
 
-static inline void ud_update_attr(u8 *dst, u8 *src, int attribute,
+static void ud_update_attr(u8 *dst, u8 *src, int attribute,
 				  struct vc_data *vc)
 {
 	int i, offset = (vc->vc_font.height < 10) ? 1 : 2;

Signature · 1 line

1.6.2.5