Skip to contentSkip to conversation

video: simplify strlen()==0 check in fb_get_options()

PATCH New Denys Vlasenko 1 participant 1 message Jun 24, 2010 Framebuffer layer

lore
Share & tools
lore

Denys Vlasenko

author
#0 lore raw

PATCH 1/1 video: simplify strlen()==0 check in fb_get_options()

Replaced !strlen(str) check with !str[0]. Removed the variable which was used solely to store strlen result.

Signed-off-by Denys Vlasenko <[email protected]>
---
 drivers/video/fbmem.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/video/fbmem.c +2 -3
index 731fce6..a8500c6 100644
@@ -1786,7 +1786,7 @@ static int ofonly __read_mostly;
 int fb_get_options(char *name, char **option)
 {
 	char *opt, *options = NULL;
-	int opt_len, retval = 0;
+	int retval = 0;
 	int name_len = strlen(name), i;
 
 	if (name_len && ofonly && strncmp(name, "offb", 4))

@@ -1796,8 +1796,7 @@ int fb_get_options(char *name, char **option)
 		for (i = 0; i < FB_MAX; i++) {
 			if (video_options[i] = NULL)
 				continue;
-			opt_len = strlen(video_options[i]);
-			if (!opt_len)
+			if (!video_options[i][0])
 				continue;
 			opt = video_options[i];
 			if (!strncmp(name, opt, name_len) &&
Signature · 1 line
1.6.2.5