Skip to contentSkip to conversation

Add support for the Wacom Intuos 4 wireless

PATCH In review Bastien Nocera 2 participants 6 messages Apr 21, 2010 – Jul 20, 2010 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support for the Wacom Intuos 4 wireless

Same command set as the Graphire Bluetooth tablet.

---
 drivers/hid/hid-ids.h   |    1 +
 drivers/hid/hid-wacom.c |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
drivers/hid/hid-ids.h +1 -0
index 66a2ca8..21f360f 100644
@@ -456,6 +456,7 @@
 
 #define USB_VENDOR_ID_WACOM		0x056a
 #define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH	0x81
+#define USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH	0xbd
 
 #define USB_VENDOR_ID_WISEGROUP		0x0925
 #define USB_DEVICE_ID_SMARTJOY_PLUS	0x0005
drivers/hid/hid-wacom.c +1 -1
index 8d3b46f..91dbae3 100644
@@ -256,7 +256,7 @@ static void wacom_remove(struct hid_device *hdev)
 
 static const struct hid_device_id wacom_devices[] = {
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) },
-
+	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH) },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, wacom_devices);
Signature · 1 line
1.6.6.1
#1 lore raw
Quoted 25 lines · Bastien Nocera

Same command set as the Graphire Bluetooth tablet.

---
 drivers/hid/hid-ids.h   |    1 +
 drivers/hid/hid-wacom.c |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
drivers/hid/hid-ids.h +1 -0
index 66a2ca8..21f360f 100644
@@ -456,6 +456,7 @@
 
 #define USB_VENDOR_ID_WACOM		0x056a
 #define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH	0x81
+#define USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH	0xbd
 
 #define USB_VENDOR_ID_WISEGROUP		0x0925
 #define USB_DEVICE_ID_SMARTJOY_PLUS	0x0005
drivers/hid/hid-wacom.c +0 -0
index 8d3b46f..91dbae3 100644

drivers/hid/hid-wacom.c static void wacom_remove(struct hid_device *hdev) · line 262

Quoted 8 lines
drivers/hid/hid-wacom.c +1 -1
@@ -256,7 +256,7 @@ static void wacom_remove(struct hid_device *hdev)
 
 static const struct hid_device_id wacom_devices[] = {
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) },
-
+	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH) },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, wacom_devices);

Hi Bastien,

has this particular patch been tested?

How about addition of this VID/PID combination to hid_blacklist[]?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#2 lore raw

On Wed, 2010-04-21 at 15:53 +0200, Jiri Kosina wrote:
<snip>

Quoted 3 lines

Hi Bastien,

has this particular patch been tested?

ENOHARDWARE :(

But the specs I have say so.

Quoted 1 line

How about addition of this VID/PID combination to hid_blacklist[]?

My mistake, that needs to be done as well obviously.

Will send an updated patch shortly.

Cheers

#3 lore raw
Quoted 5 lines · Bastien Nocera
Quoted 1 line

How about addition of this VID/PID combination to hid_blacklist[]?

My mistake, that needs to be done as well obviously.

Will send an updated patch shortly.

No problem, I'll fix that up myself.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#4 lore raw
Quoted 9 lines · Jiri Kosina
Quoted 5 lines · Bastien Nocera
Quoted 1 line

How about addition of this VID/PID combination to hid_blacklist[]?

My mistake, that needs to be done as well obviously.

Will send an updated patch shortly.

No problem, I'll fix that up myself.

Hmm, I did something stupid there. The Intuos 4 wireless uses a different protocol from the Graphire wireless. Another driver will need to be written...

Could you please revert that patch?

Cheers

#5 lore raw
Quoted 6 lines · Bastien Nocera
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

How about addition of this VID/PID combination to hid_blacklist[]?

My mistake, that needs to be done as well obviously.

Will send an updated patch shortly.

Quoted 7 lines
Quoted 1 line

No problem, I'll fix that up myself.

Hmm, I did something stupid there. The Intuos 4 wireless uses a different protocol from the Graphire wireless. Another driver will need to be written...

Could you please revert that patch?

Reverted, thanks for letting me know.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.