Skip to contentSkip to conversation

dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit

PATCH New Axel Lin 1 participant 1 message Jul 5, 2010

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit

Quoted 1 line

From 03828286561e3d39cacfb831b2f303a047a6f787 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Mon, 5 Jul 2010 09:26:30 +0800
Subject: [PATCH] dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit

smi_data_buf_free is called twice in current implementation.
The second call simply return because smi_data_buf is set to NULL in first call. This patch removes the second smi_data_buf_free call.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/firmware/dcdbas.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/firmware/dcdbas.c +2 -3
index aa9bc9e..69ad529 100644
@@ -634,9 +634,6 @@ static void __exit dcdbas_exit(void)
 	 * before platform_device_unregister
 	 */
 	unregister_reboot_notifier(&dcdbas_reboot_nb);
-	smi_data_buf_free();
-	platform_device_unregister(dcdbas_pdev);
-	platform_driver_unregister(&dcdbas_driver);
 
 	/*
 	 * We have to free the buffer here instead of dcdbas_remove

@@ -645,6 +642,8 @@ static void __exit dcdbas_exit(void)
 	 * released.
 	 */
 	smi_data_buf_free();
+	platform_device_unregister(dcdbas_pdev);
+	platform_driver_unregister(&dcdbas_driver);
 }
 
 module_init(dcdbas_init);
Signature · 1 line
1.5.4.3