Skip to contentSkip to conversation

cifs: remove unused ip_address field in struct TCP_Server_Info

PATCH In review Suresh Jayaraman 2 participants 2 messages Jul 6, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: remove unused ip_address field in struct TCP_Server_Info

The ip_address field is not used and seems redundant as there is union addr already and I don't see any future use as well.

---
 fs/cifs/cifsglob.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/cifs/cifsglob.h +0 -1
index a88479c..f182fe8 100644
@@ -142,7 +142,6 @@ struct TCP_Server_Info {
 	struct list_head pending_mid_q;
 	void *Server_NlsInfo;	/* BB - placeholder for future NLS info  */
 	unsigned short server_codepage;	/* codepage for the server    */
-	unsigned long ip_address;	/* IP addr for the server if known */
 	enum protocolEnum protocolType;
 	char versionMajor;
 	char versionMinor;
#1 lore raw

Makes sense - plan to merge this and two others of yours into cifs-2.6.git today or tomorrow.

Quoted 21 lines · Suresh Jayaraman

The ip_address field is not used and seems redundant as there is union addr already and I don't see any future use as well.

---
 fs/cifs/cifsglob.h |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
fs/cifs/cifsglob.h +0 -0
index a88479c..f182fe8 100644
@@ -142,7 +142,6 @@ struct TCP_Server_Info {
        struct list_head pending_mid_q;

       void *Server_NlsInfo;   /* BB - placeholder for future NLS info  */ unsigned short server_codepage; /* codepage for the server    */
-       unsigned long ip_address;       /* IP addr for the server if known */ enum protocolEnum protocolType;
       char versionMajor;
       char versionMinor;

Signature · 3 lines
Thanks,

Steve