Skip to contentSkip to conversation

acerhdf: make needlessly global symbols static

PATCH In review Axel Lin 3 participants 3 messages Jul 8, 2010 – Jul 10, 2010

Subsystems (2)
x86 platform drivers Acer aspire one temperature and fan driver
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 acerhdf: make needlessly global symbols static

The following symbols are needlessly defined global:

thz_dev
cl_dev
acerhdf_dev
acerhdf_dev_ops
acerhdf_cooling_ops

This patch makes the symbols static.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/platform/x86/acerhdf.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/platform/x86/acerhdf.c +5 -5
index 7b2384d..5caaaf0 100644
@@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
 static char force_bios[16];
 static char force_product[16];
 static unsigned int prev_interval;
-struct thermal_zone_device *thz_dev;
-struct thermal_cooling_device *cl_dev;
-struct platform_device *acerhdf_dev;
+static struct thermal_zone_device *thz_dev;
+static struct thermal_cooling_device *cl_dev;
+static struct platform_device *acerhdf_dev;
 
 module_param(kernelmode, uint, 0);
 MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");

@@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
 }
 
 /* bind callback functions to thermalzone */
-struct thermal_zone_device_ops acerhdf_dev_ops = {
+static struct thermal_zone_device_ops acerhdf_dev_ops = {
 	.bind = acerhdf_bind,
 	.unbind = acerhdf_unbind,
 	.get_temp = acerhdf_get_ec_temp,

@@ -449,7 +449,7 @@ err_out:
 }
 
 /* bind fan callbacks to fan device */
-struct thermal_cooling_device_ops acerhdf_cooling_ops = {
+static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
 	.get_max_state = acerhdf_get_max_state,
 	.get_cur_state = acerhdf_get_cur_state,
 	.set_cur_state = acerhdf_set_cur_state,
Signature · 1 line
1.5.4.3
Acked-by on v1 1/1
#1 lore raw

From: Axel Lin <[email protected]>
Date: Thu, Jul 08, 2010 at 09:46:20AM +0800

Quoted 11 lines

The following symbols are needlessly defined global:

thz_dev
cl_dev
acerhdf_dev
acerhdf_dev_ops
acerhdf_cooling_ops

This patch makes the symbols static.

Signed-off-by Axel Lin <[email protected]>
Acked-by Borislav Petkov <[email protected]>
Quoted 44 lines
---
 drivers/platform/x86/acerhdf.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/platform/x86/acerhdf.c +5 -5
index 7b2384d..5caaaf0 100644
@@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
 static char force_bios[16];
 static char force_product[16];
 static unsigned int prev_interval;
-struct thermal_zone_device *thz_dev;
-struct thermal_cooling_device *cl_dev;
-struct platform_device *acerhdf_dev;
+static struct thermal_zone_device *thz_dev;
+static struct thermal_cooling_device *cl_dev;
+static struct platform_device *acerhdf_dev;
 
 module_param(kernelmode, uint, 0);
 MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");

@@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
 }
 
 /* bind callback functions to thermalzone */
-struct thermal_zone_device_ops acerhdf_dev_ops = {
+static struct thermal_zone_device_ops acerhdf_dev_ops = {
 	.bind = acerhdf_bind,
 	.unbind = acerhdf_unbind,
 	.get_temp = acerhdf_get_ec_temp,

@@ -449,7 +449,7 @@ err_out:
 }
 
 /* bind fan callbacks to fan device */
-struct thermal_cooling_device_ops acerhdf_cooling_ops = {
+static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
 	.get_max_state = acerhdf_get_max_state,
 	.get_cur_state = acerhdf_get_cur_state,
 	.set_cur_state = acerhdf_set_cur_state,
Signature · 1 line
1.5.4.3
Signature · 2 lines
Regards/Gruss,
Boris.
maintainer Acked-by
#2 lore raw
Quoted 11 lines · Borislav Petkov

From: Axel Lin <[email protected]>
Date: Thu, Jul 08, 2010 at 09:46:20AM +0800

Quoted 8 lines

The following symbols are needlessly defined global:

thz_dev
cl_dev
acerhdf_dev
acerhdf_dev_ops
acerhdf_cooling_ops

Quoted 5 lines
Quoted 3 lines

This patch makes the symbols static.

Signed-off-by Axel Lin <[email protected]>
Acked-by Borislav Petkov <[email protected]>
Acked-by Peter Feuerer <[email protected]>
Quoted 34 lines
Quoted 34 lines
---
 drivers/platform/x86/acerhdf.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/platform/x86/acerhdf.c +4 -4
index 7b2384d..5caaaf0 100644
@@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
 static char force_bios[16];
 static char force_product[16];
 static unsigned int prev_interval;
-struct thermal_zone_device *thz_dev;
-struct thermal_cooling_device *cl_dev;
-struct platform_device *acerhdf_dev;
+static struct thermal_zone_device *thz_dev;
+static struct thermal_cooling_device *cl_dev;
+static struct platform_device *acerhdf_dev;
 
 module_param(kernelmode, uint, 0);
 MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");

@@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
 }
 
 /* bind callback functions to thermalzone */
-struct thermal_zone_device_ops acerhdf_dev_ops = {
+static struct thermal_zone_device_ops acerhdf_dev_ops = {
 	.bind = acerhdf_bind,
 	.unbind = acerhdf_unbind,
 	.get_temp = acerhdf_get_ec_temp,

@@ -449,7 +449,7 @@ err_out:
 }
Quoted 11 lines
Quoted 11 lines
drivers/platform/x86/acerhdf.c +1 -1
 /* bind fan callbacks to fan device */
-struct thermal_cooling_device_ops acerhdf_cooling_ops = {
+static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
 	.get_max_state = acerhdf_get_max_state,
 	.get_cur_state = acerhdf_get_cur_state,
 	.set_cur_state = acerhdf_set_cur_state,
Signature · 1 line
1.5.4.3

thanks and kind regards,
--peter;