Skip to contentSkip to conversation

msi-wmi: make needlessly global symbols static

PATCH In review Axel Lin 2 participants 2 messages Jul 8, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 msi-wmi: make needlessly global symbols static

backlight is needlessly defined global.
This patch makes the symbol static.

---
 drivers/platform/x86/msi-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/msi-wmi.c +1 -1
index d173600..42a5469 100644
@@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
 };
 static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
 
-struct backlight_device *backlight;
+static struct backlight_device *backlight;
 
 static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
 
Signature · 1 line
1.5.4.3
Acked-by on v1 1/1
#1 lore raw

Hi Axel,

Quoted 4 lines · Axel Lin

backlight is needlessly defined global.
This patch makes the symbol static.

Thanks,

Anisse

Quoted 17 lines
---
 drivers/platform/x86/msi-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/msi-wmi.c +1 -1
index d173600..42a5469 100644
@@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
 };
 static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
 
-struct backlight_device *backlight;
+static struct backlight_device *backlight;
 
 static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };