Skip to contentSkip to conversation

Add cmd64x IDE driver to default pmac32 config

PATCH In review lawrence rust 2 participants 6 messages Jul 3, 2010 – Jul 8, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add cmd64x IDE driver to default pmac32 config

The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows...

01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)

Unfortunately the default pmac32 configuration does not include this driver and so PowerMac G3's can't load a root filesystem. This is an issue on a least Ubuntu since version 9.04, which uses the default config as a starting point.

Signed-off-by Lawrence Rust <lawrence at softsystem.co.uk>
arch/powerpc/configs/pmac32_defconfig +1 -1
diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig 
@@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_CMD64X is not set
+CONFIG_BLK_DEV_CMD64X=y
 # CONFIG_BLK_DEV_TRIFLEX is not set
 # CONFIG_BLK_DEV_CS5520 is not set
 # CONFIG_BLK_DEV_CS5530 is not set
#1 lore raw
Quoted 11 lines · lawrence rust

The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows...

01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)

Unfortunately the default pmac32 configuration does not include this driver and so PowerMac G3's can't load a root filesystem. This is an issue on a least Ubuntu since version 9.04, which uses the default config as a starting point.

Signed-off-by Lawrence Rust <lawrence at softsystem.co.uk>

Shouldn't we just switch the whole thing to libata now anyways ?

Cheers,
Ben.

Quoted 20 lines

diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig

arch/powerpc/configs/pmac32_defconfig +1 -1
@@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_CMD64X is not set
+CONFIG_BLK_DEV_CMD64X=y
 # CONFIG_BLK_DEV_TRIFLEX is not set
 # CONFIG_BLK_DEV_CS5520 is not set
 # CONFIG_BLK_DEV_CS5530 is not set

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

#2 lore raw
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 5 lines · lawrence rust

The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows...

01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)

Quoted 8 lines
Quoted 6 lines

Unfortunately the default pmac32 configuration does not include this driver and so PowerMac G3's can't load a root filesystem. This is an issue on a least Ubuntu since version 9.04, which uses the default config as a starting point.

Signed-off-by Lawrence Rust <lawrence at softsystem.co.uk>

Shouldn't we just switch the whole thing to libata now anyways ?

Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE code is removed) to use the IDE cmd64x driver to minimise kernel code size.

A minor correction to my previous post, the first version of Ubuntu to suffer from this problem was 9.10.

-- Lawrence

Quoted 26 lines

Cheers,
Ben.

Quoted 20 lines

diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig

arch/powerpc/configs/pmac32_defconfig +1 -1
@@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_CMD64X is not set
+CONFIG_BLK_DEV_CMD64X=y
 # CONFIG_BLK_DEV_TRIFLEX is not set
 # CONFIG_BLK_DEV_CS5520 is not set
 # CONFIG_BLK_DEV_CS5530 is not set

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Signature · 1 line
-- Lawrence Rust
#3 lore raw
Quoted 6 lines · lawrence rust

Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE code is removed) to use the IDE cmd64x driver to minimise kernel code size.

Sure it does nowadays: drivers/ata/pata_macio.c :-)

I merged that upstream in december last year, so it didn't make 2.6.32 which your distro probably uses, but it is in .33 and later.

Quoted 2 lines

A minor correction to my previous post, the first version of Ubuntu to suffer from this problem was 9.10.

Cheers,
Ben.

#4 lore raw
Quoted 8 lines · Benjamin Herrenschmidt
Quoted 6 lines · lawrence rust

Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE code is removed) to use the IDE cmd64x driver to minimise kernel code size.

Quoted 4 lines

Sure it does nowadays: drivers/ata/pata_macio.c :-)

I merged that upstream in december last year, so it didn't make 2.6.32 which your distro probably uses, but it is in .33 and later.

OK I see that - good news. However, for the moment I believe that it's safer to stay with IDE. It's the smallest of changes but the wholesale move to libata could well break numerous system install scripts - e.g. for yaboot.

-- Lawrence

#5 lore raw
Quoted 11 lines · lawrence rust
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 6 lines · lawrence rust

Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE code is removed) to use the IDE cmd64x driver to minimise kernel code size.

Sure it does nowadays: drivers/ata/pata_macio.c :-)

Quoted 7 lines
Quoted 2 lines

I merged that upstream in december last year, so it didn't make 2.6.32 which your distro probably uses, but it is in .33 and later.

OK I see that - good news. However, for the moment I believe that it's safer to stay with IDE. It's the smallest of changes but the wholesale move to libata could well break numerous system install scripts - e.g. for yaboot.

Well, distros have moved over mostly... I don't think keeping the defaults to the old stuff upstream is going to help getting things like yaboot fixed. I'll talk to Tony see what the situation there is tomorrow, but I'd rather fix yaboot and switch the default over.

Ben.