Skip to contentSkip to conversation

asus-laptop: return proper error for store_ledd if write_acpi_int fail

PATCH In review Axel Lin 2 participants 2 messages Jul 8, 2010

Subsystems (2)
x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 asus-laptop: return proper error for store_ledd if write_acpi_int fail

In current implementation, store_ledd() does not return error if write_acpi_int fail.
This patch fixes it by return -ENODEV if write_acpi_int fail.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/platform/x86/asus-laptop.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/asus-laptop.c +4 -3
index 93487eb..975751d 100644
@@ -796,10 +796,11 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
 
 	rv = parse_arg(buf, count, &value);
 	if (rv > 0) {
-		if (write_acpi_int(asus->handle, METHOD_LEDD, value))
+		if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
 			pr_warning("LED display write failed\n");
-		else
-			asus->ledd_status = (u32) value;
+			return -ENODEV;
+		}
+		asus->ledd_status = (u32) value;
 	}
 	return rv;
 }
Signature · 1 line
1.5.4.3
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines · Axel Lin

In current implementation, store_ledd() does not return error if write_acpi_int fail.
This patch fixes it by return -ENODEV if write_acpi_int fail.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/platform/x86/asus-laptop.c |    7 ++++---

 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/asus-laptop.c +4 -4
index 93487eb..975751d 100644
@@ -796,10 +796,11 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
 
        rv = parse_arg(buf, count, &value);
        if (rv > 0) {
-               if (write_acpi_int(asus->handle, METHOD_LEDD, value))
+               if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
                        pr_warning("LED display write failed\n");
-               else
-                       asus->ledd_status = (u32) value;
+                       return -ENODEV;
+               }
+               asus->ledd_status = (u32) value;
        }
        return rv;
  }
--

1.5.4.3

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks !

Acked-by Corentin Chary <[email protected]>
Signature · 2 lines
Corentin Chary
http://xf.iksaif.net