Skip to contentSkip to conversation

adm8211: fix memory leak

PATCH In review Kulikov Vasiliy 2 participants 2 messages Jul 10, 2010 – Jul 12, 2010

Subsystems (4)
Networking Network drivers Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Kulikov Vasiliy

author
#0 lore raw

PATCH 1/1 adm8211: fix memory leak

We must free priv->eeprom allocated in adm8211_read_eeprom().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/net/wireless/adm8211.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/net/wireless/adm8211.c +4 -1
index 880ad9d..bde2fa8 100644
@@ -1903,7 +1903,7 @@ static int __devinit adm8211_probe(struct pci_dev *pdev,
 	if (err) {
 		printk(KERN_ERR "%s (adm8211): Cannot register device\n",
 		       pci_name(pdev));
-		goto err_free_desc;
+		goto err_free_eeprom;
 	}
 
 	printk(KERN_INFO "%s: hwaddr %pM, Rev 0x%02x\n",

@@ -1912,6 +1912,9 @@ static int __devinit adm8211_probe(struct pci_dev *pdev,
 
 	return 0;
 
+ err_free_eeprom:
+	kfree(priv->eeprom);
+
  err_free_desc:
 	pci_free_consistent(pdev,
 			    sizeof(struct adm8211_desc) * priv->rx_ring_size +
Signature · 1 line
1.7.0.4