Skip to contentSkip to conversation

eeepc-laptop: fix hotplug_disabled module_param permissions

PATCH In review Axel Lin 2 participants 3 messages Jul 12, 2010 – Jul 23, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 eeepc-laptop: fix hotplug_disabled module_param permissions

The hotplug_disabled module parameter is determinated at the module load time. Change the value after the module is loaded does not make sense and has no effect at all, thus set the permissions to 0444 instead of 0644.

---
 drivers/platform/x86/eeepc-laptop.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/eeepc-laptop.c +1 -1
index 0306174..6b8e062 100644
@@ -53,7 +53,7 @@ MODULE_LICENSE("GPL");
 
 static bool hotplug_disabled;
 
-module_param(hotplug_disabled, bool, 0644);
+module_param(hotplug_disabled, bool, 0444);
 MODULE_PARM_DESC(hotplug_disabled,
 		 "Disable hotplug for wireless device. "
 		 "If your laptop need that, please report to "
Signature · 1 line
1.5.4.3
#1 lore raw

I think I've got all of your patches merged now, but let me know if I've missed any. They should be in my linux-next branch.

Signature · 1 line
Matthew Garrett | [email protected]
author
#2 lore raw

2010/7/22 Matthew Garrett <[email protected]>:

Quoted 2 lines

I think I've got all of your patches merged now, but let me know if I've missed any. They should be in my linux-next branch.

hi Matthew,
Thanks for merging the patches.

Below 3 patches are missing:
[PATCH] asus-laptop: fix asus_input_init error path

        http://lkml.org/lkml/2010/7/5/21
[PATCH] dell-laptop: make dell_laptop_i8042_filter() static
        http://lkml.org/lkml/2010/7/5/69
[PATCH] msi-wmi: make needlessly global symbols static
        http://lkml.org/lkml/2010/7/8/66

Regards,
Axel