xfs: unregister inode shrinker before freeing filesystem structures V2
PATCH 1/1 xfs: unregister inode shrinker before freeing filesystem structures V2
From: Dave Chinner <[email protected]>
Currently we don't remove the XFS mount from the shrinker list until late in the unmount path. By this time, we have already torn down the internals of the filesystem (e.g. the per-ag structures), and hence if the shrinker is executed between the teardown and the unregistering, the shrinker will get NULL per-ag structure pointers and panic trying to dereference them.
Fix this by removing the xfs mount from the shrinker list before tearing down it's internal structures.
--- fs/xfs/linux-2.6/xfs_super.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
fs/xfs/linux-2.6/xfs_super.c +5 -1
@@ -1145,6 +1145,11 @@ xfs_fs_put_super( {struct xfs_mount *mp =XFS_M (sb); +/* +* Unregister the memory shrinker before we tear down the mount +* structure so we don't have memory reclaim racing with us here. +*/ +xfs_inode_shrinker_unregister (mp);xfs_syncd_stop (mp);/*
@@ -1158,7 +1163,6 @@ xfs_fs_put_super(xfs_unmountfs (mp);xfs_freesb (mp); -xfs_inode_shrinker_unregister (mp);xfs_icsb_destroy_counters (mp);xfs_close_devices (mp);xfs_free_fsname (mp);
Signature · 6 lines
1.7.1 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Dave Chinner
From: Dave Chinner <[email protected]>
Currently we don't remove the XFS mount from the shrinker list until late in the unmount path. By this time, we have already torn down the internals of the filesystem (e.g. the per-ag structures), and hence if the shrinker is executed between the teardown and the unregistering, the shrinker will get NULL per-ag structure pointers and panic trying to dereference them.
Quoted 5 lines
Fix this by removing the xfs mount from the shrinker list before tearing down it's internal structures.
Signed-off-by Dave Chinner <[email protected]>---
Looks good
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs