Skip to contentSkip to conversation

staging: comedi: formatting of pointers in printk()

PATCH In review Kulikov Vasiliy 4 participants 4 messages Jul 15, 2010 – Jul 22, 2010

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Kulikov Vasiliy

author
#0 lore raw

PATCH 9/11 staging: comedi: formatting of pointers in printk()

Use %p instead of %08x in printk().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/comedi/drivers/quatech_daqp_cs.c +1 -1
index 8d16380..8b49cb1 100644
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
 
 	for (i = 0; i < len; i++) {
 		if (i % 16 = 0)
-			printk("\n0x%08x:", (unsigned int)cptr);
+			printk("\n%p:", cptr);
 
 		printk(" %02x", *(cptr++));
 	}
Signature · 1 line
1.7.0.4
#1 lore raw

drivers/staging/comedi/drivers/quatech_daqp_cs.c static void hex_dump(char *str, void *ptr, int len)

Quoted 12 lines · Kulikov Vasiliy

Use %p instead of %08x in printk().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/comedi/drivers/quatech_daqp_cs.c +0 -0
index 8d16380..8b49cb1 100644
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)

The name and parameters suggest to remove the function completely. (And use print_hex_dump_bytes instead.)

Quoted 8 lines
drivers/staging/comedi/drivers/quatech_daqp_cs.c +1 -1
 	for (i = 0; i < len; i++) {
 		if (i % 16 = 0)
-			printk("\n0x%08x:", (unsigned int)cptr);
+			printk("\n%p:", cptr);
 
 		printk(" %02x", *(cptr++));
 	}
Signature · 1 line
js
#2 lore raw
Quoted 8 lines · Jiri Slaby
Quoted 7 lines · Kulikov Vasiliy

Use %p instead of %08x in printk().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 8 lines

drivers/staging/comedi/drivers/quatech_daqp_cs.c static void hex_dump(char *str, void *ptr, int len)

Quoted 5 lines
drivers/staging/comedi/drivers/quatech_daqp_cs.c +0 -0
index 8d16380..8b49cb1 100644
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)

The name and parameters suggest to remove the function completely. (And use print_hex_dump_bytes instead.)

I agree, Kulikov, can you make that chagne instead?

thanks,

greg k-h

#3 lore raw
Quoted 5 lines · Greg KH
Quoted 3 lines · Jiri Slaby

On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
The name and parameters suggest to remove the function completely. (And use print_hex_dump_bytes instead.)

I agree, Kulikov, can you make that chagne instead?

The function isn't used at all and should simply be removed.