ALSA: msnd: check request_region() return value

PATCH Applied Kulikov Vasiliy 1 participant 1 message Jul 28, 2010

Subsystems (2)

Sound Kernel janitors

lore

Share & tools

lore

Kulikov Vasiliy

author

2010-07-28 16:40 UTC #0 lore raw

PATCH 6/10 ALSA: msnd: check request_region() return value

request_region() may fail, if so return -ENOMEM.

Signed-off-by Kulikov Vasiliy <[email protected]>

---
 sound/isa/msnd/msnd_pinnacle.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

sound/isa/msnd/msnd_pinnacle.c +4 -1

index 60b6abd..ed42f8e 100644
@@ -549,7 +549,10 @@ static int __devinit snd_msnd_attach(struct snd_card *card)
 		printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", chip->irq);
 		return err;
 	}
-	request_region(chip->io, DSP_NUMIO, card->shortname);
+	if (request_region(chip->io, DSP_NUMIO, card->shortname) == NULL) {
+		free_irq(chip->irq, chip);
+		return -ENOMEM;
+	}
 
 	if (!request_mem_region(chip->base, BUFFSIZE, card->shortname)) {
 		printk(KERN_ERR LOGNAME

Signature · 1 line

1.7.0.4