jz4740-adc/jz4740-hwmon: check kmalloc() result
Subsystems (2)
PATCH 1/2 jz4740-adc/jz4740-hwmon: check kmalloc() result
If kmalloc() fails, exit with -ENOMEM.
Signed-off-by Axel Lin <[email protected]>
---
This patch is against linux-next.
drivers/hwmon/jz4740-hwmon.c | 4 ++++ drivers/mfd/jz4740-adc.c | 4 ++++ 2 files changed, 8 insertions(+), 0 deletions(-)
drivers/hwmon/jz4740-hwmon.c +4 -0
@@ -107,6 +107,10 @@ static int __devinit jz4740_hwmon_probe(struct platform_device *pdev)struct jz4740_hwmon *hwmon; hwmon =kmalloc (sizeof (*hwmon),GFP_KERNEL ); +if (!hwmon) { +dev_err (&pdev->dev,"Failed to allocate driver structure\n" ); +return -ENOMEM ; + } hwmon->cell = pdev->dev.platform_data;
drivers/mfd/jz4740-adc.c +4 -0
@@ -260,6 +260,10 @@ static int __devinit jz4740_adc_probe(struct platform_device *pdev)int irq; adc =kmalloc (sizeof (*adc),GFP_KERNEL ); +if (!adc) { +dev_err (&pdev->dev,"Failed to allocate driver structure\n" ); +return -ENOMEM ; + } adc->irq =platform_get_irq (pdev,0 );if (adc->irq <0 ) {
Signature · 1 line
1.5.4.3
Hi Axel,
Quoted 1 line · Axel Lin
If
kmalloc()fails, exit with-ENOMEM.
Could you please separate this patch in 2, as the 2 drivers live in different trees for now ?
Cheers,
Samuel.
Quoted 42 lines
Signed-off-by Axel Lin <[email protected]>---
This patch is against linux-next.drivers/hwmon/jz4740-hwmon.c | 4 ++++ drivers/mfd/jz4740-adc.c | 4 ++++ 2 files changed, 8 insertions(+), 0 deletions(-)drivers/hwmon/jz4740-hwmon.c +4
-0@@ -107,6 +107,10 @@ static int __devinit jz4740_hwmon_probe(struct platform_device *pdev)struct jz4740_hwmon *hwmon; hwmon =kmalloc (sizeof (*hwmon),GFP_KERNEL ); +if (!hwmon) { +dev_err (&pdev->dev,"Failed to allocate driver structure\n" ); +return -ENOMEM ; + } hwmon->cell = pdev->dev.platform_data;drivers/mfd/jz4740-adc.c +4
-0@@ -260,6 +260,10 @@ static int __devinit jz4740_adc_probe(struct platform_device *pdev)int irq; adc =kmalloc (sizeof (*adc),GFP_KERNEL ); +if (!adc) { +dev_err (&pdev->dev,"Failed to allocate driver structure\n" ); +return -ENOMEM ; + } adc->irq =platform_get_irq (pdev,0 );if (adc->irq <0 ) {Signature · 1 line
1.5.4.3
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/