char: cs5535_gpio: check put_user() result

PATCH New Kulikov Vasiliy 1 participant 1 message Jul 29, 2010

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Kulikov Vasiliy

author

2010-07-29 15:55 UTC #0 lore raw

PATCH 1/1 char: cs5535_gpio: check put_user() result

put_user() may fail, if so return -EFAULT.

Signed-off-by Kulikov Vasiliy <[email protected]>

---
 drivers/char/cs5535_gpio.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

drivers/char/cs5535_gpio.c +2 -1

index 4d830dc..fb7b888 100644
@@ -146,7 +146,8 @@ static ssize_t cs5535_gpio_read(struct file *file, char __user *buf,
 
 	/* add a line-feed if there is room */
 	if ((i = ARRAY_SIZE(rm)) && (count < len)) {
-		put_user('\n', buf + count);
+		if (put_user('\n', buf + count))
+			return -EFAULT;
 		count++;
 	}

Signature · 1 line

1.7.0.4