Skip to contentSkip to conversation

net: wl12xx: do not use kfree'd memory

PATCH In review Kulikov Vasiliy 2 participants 2 messages Jul 31, 2010 – Aug 2, 2010 1 message not in the archive

Subsystems (4)
Networking Network drivers Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Kulikov Vasiliy

author
#0 lore raw

PATCH 1/1 net: wl12xx: do not use kfree'd memory

wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after wl1271_dump().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/net/wireless/wl12xx/wl1271_spi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1271_spi.c +1 -2
index 96d25fb..4cb99c5 100644
@@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl)
 	spi_message_add_tail(&t, &m);
 
 	spi_sync(wl_to_spi(wl), &m);
-	kfree(cmd);
-
 	wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN);
+	kfree(cmd);
 }
 
 #define WL1271_BUSY_WORD_TIMEOUT 1000
Signature · 1 line
1.7.0.4

A message that is not in the archive (sent off-list or not yet received): 1280594039-3246-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Acked-by
#2 lore raw
Quoted 13 lines · ext Kulikov Vasiliy

wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after wl1271_dump().

Signed-off-by Kulikov Vasiliy <[email protected]>
---
 drivers/net/wireless/wl12xx/wl1271_spi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1271_spi.c +0 -0
index 96d25fb..4cb99c5 100644

drivers/net/wireless/wl12xx/wl1271_spi.c static void wl1271_spi_init(struct wl1271 *wl) · line 167

Quoted 10 lines
drivers/net/wireless/wl12xx/wl1271_spi.c +1 -2
@@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl)
 	spi_message_add_tail(&t, &m);
 
 	spi_sync(wl_to_spi(wl), &m);
-	kfree(cmd);
-
 	wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN);
+	kfree(cmd);
 }
 
 #define WL1271_BUSY_WORD_TIMEOUT 1000

Whoops ;) Good catch, thanks.

Acked-by Juuso Oikarinen <[email protected]>

-Juuso