Skip to contentSkip to conversation

EFI runtime-services on x86_64

DISCUSSION Bjorn Helgaas 5 participants 7 messages Jul 30, 2010 – Aug 3, 2010

lore
Share & tools
lore
#0 lore raw

Hello Feng,

Can you educate me about your commit 772be899bc, "86: Make EFI RTC function depend on 32bit again"?

It adds "#ifdef CONFIG_X86_32" to avoid using efi_get_time() and efi_set_rtc_mmss(), but there's no explanation of *why* those services only work on 32-bit.

Is this an EFI spec limitation? Do the other EFI runtime services work on 64-bit, since you didn't touch them? Or do we just not use any of the others?

Is this something that can be fixed, so we *could* use efi_get_time() on 64-bit if we did some work? What would need to be done?

Bjorn

#1 lore raw

Hi Bjorn,

Quoted 5 lines · On Sat, 31 Jul 2010 04:58:48 +0800 Bjorn Helgaas <[email protected]> wrote:

Hello Feng,

Can you educate me about your commit 772be899bc, "86: Make EFI RTC function depend on 32bit again"?

Quoted 8 lines

It adds "#ifdef CONFIG_X86_32" to avoid using efi_get_time() and efi_set_rtc_mmss(), but there's no explanation of *why* those services only work on 32-bit.

Is this an EFI spec limitation? Do the other EFI runtime services work on 64-bit, since you didn't touch them? Or do we just not use any of the others?

Commit 772be899bc, "86: Make EFI RTC function depend on 32bit again" is a regression fix for 7bd867d "x86: Move get/set_wallclock to x86_platform_ops". These 2 commits just abstract the rtc service for legacy x86 PC/EFI/Virtualiation kernel, and has no functional change to existing code.

I'm not familiar with EFI, but my understanding is current EFI code in kernel only provides the get/set_time service for x86_32 platform.

Cc Ying who is more familiar with EFI than me.

Thanks,
Feng

#2 lore raw

Hi, Bjorn,

Quoted 19 lines · Feng

Hi Bjorn,

Quoted 5 lines · On Sat, 31 Jul 2010 04:58:48 +0800 Bjorn Helgaas <[email protected]> wrote:

Hello Feng,

Can you educate me about your commit 772be899bc, "86: Make EFI RTC function depend on 32bit again"?

Quoted 8 lines

It adds "#ifdef CONFIG_X86_32" to avoid using efi_get_time() and efi_set_rtc_mmss(), but there's no explanation of *why* those services only work on 32-bit.

Is this an EFI spec limitation? Do the other EFI runtime services work on 64-bit, since you didn't touch them? Or do we just not use any of the others?

Quoted 7 lines

Commit 772be899bc, "86: Make EFI RTC function depend on 32bit again" is a regression fix for 7bd867d "x86: Move get/set_wallclock to x86_platform_ops". These 2 commits just abstract the rtc service for legacy x86 PC/EFI/Virtualiation kernel, and has no functional change to existing code.

I'm not familiar with EFI, but my understanding is current EFI code in kernel only provides the get/set_time service for x86_32 platform.

I think get/set_time service should have worked on x86_64 too. Just lacks proper debugging/testing for recent kernels.

Best Regards,
Huang Ying

#3 lore raw
Quoted 27 lines · Huang Ying

Hi, Bjorn,

Quoted 24 lines · Feng

Hi Bjorn,

Quoted 5 lines · On Sat, 31 Jul 2010 04:58:48 +0800 Bjorn Helgaas <[email protected]> wrote:

Hello Feng,

Can you educate me about your commit 772be899bc, "86: Make EFI RTC function depend on 32bit again"?

Quoted 8 lines

It adds "#ifdef CONFIG_X86_32" to avoid using efi_get_time() and efi_set_rtc_mmss(), but there's no explanation of *why* those services only work on 32-bit.

Is this an EFI spec limitation? Do the other EFI runtime services work on 64-bit, since you didn't touch them? Or do we just not use any of the others?

Commit 772be899bc, "86: Make EFI RTC function depend on 32bit again" is a regression fix for 7bd867d "x86: Move get/set_wallclock to x86_platform_ops". These 2 commits just abstract the rtc service for legacy x86 PC/EFI/Virtualiation kernel, and has no functional change to existing code.

Quoted 5 lines
Quoted 2 lines

I'm not familiar with EFI, but my understanding is current EFI code in kernel only provides the get/set_time service for x86_32 platform.

I think get/set_time service should have worked on x86_64 too. Just lacks proper debugging/testing for recent kernels.

Is there any reason we just don't rip those calls out?

If we don't need them and we lack proper debug/testing I don't see the point of using the EFI calls and exposing ourselves to more potential BIOS breakage.

EFI runtime calls have the nasty fact that they don't work in general even if EFI is present because you may have the wrong word size EFI running on your machine. A 32bit EFI and a 64bit kernel or a 64bit EFI and a 32bit kernel.

Eric

#4 lore raw
Quoted 3 lines · Eric W. Biederman

EFI runtime calls have the nasty fact that they don't work in general even if EFI is present because you may have the wrong word size EFI running on your machine. A 32bit EFI and a 64bit kernel or a 64bit EFI and a 32bit kernel.

You've already failed to boot in that case.

Signature · 1 line
Matthew Garrett | [email protected]
#5 lore raw
Quoted 7 lines · Matthew Garrett
Quoted 3 lines · Eric W. Biederman

EFI runtime calls have the nasty fact that they don't work in general even if EFI is present because you may have the wrong word size EFI running on your machine. A 32bit EFI and a 64bit kernel or a 64bit EFI and a 32bit kernel.

You've already failed to boot in that case.

Only if you have EFI runtime services enabled in your kernel. You can skip the efi junk and the kernel runs just fine. Doing what we do on every other platform which appears to be a combination of ACPI and direct hardware access appears to be good enough, and that is a path that actually gets tested regularly.

Eric

#6 lore raw
Quoted 5 lines · Eric W. Biederman

Only if you have EFI runtime services enabled in your kernel. You can skip the efi junk and the kernel runs just fine. Doing what we do on every other platform which appears to be a combination of ACPI and direct hardware access appears to be good enough, and that is a path that actually gets tested regularly.

I think wanting to set the nvram variables so that your bootloader works is a pretty typical usecase...

Signature · 1 line
Matthew Garrett | [email protected]