Staging: wlan-ng: fix checkpatch issues in headers.
PATCH 1/1 Staging: wlan-ng: fix checkpatch issues in headers.
This patch fix errors and warnings reported by checkpatch in p80211meta.h and p80211metstruct.h.
Signed-off-by Edgardo Hames <[email protected]>
--- drivers/staging/wlan-ng/cfg80211.c | 18 +++--- drivers/staging/wlan-ng/p80211meta.h | 16 +++--- drivers/staging/wlan-ng/p80211metastruct.h | 60 +++++++++++----------- drivers/staging/wlan-ng/p80211netdev.c | 9 ++-- drivers/staging/wlan-ng/p80211req.c | 12 ++-- drivers/staging/wlan-ng/prism2fw.c | 8 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 22 ++++---- drivers/staging/wlan-ng/prism2mib.c | 76 ++++++++++++++-------------- drivers/staging/wlan-ng/prism2sta.c | 15 +++--- 9 files changed, 119 insertions(+), 117 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +9 -9
@@ -72,7 +72,7 @@ static int prism2_result2err(int prism2_result)static int prism2_domibset_uint32 (wlandevice_t *wlandev,u32 did,u32 data) { -p80211msg_dot11req_mibset_t msg; +struct p80211msg_dot11req_mibset msg;p80211item_uint32_t *mibitem = (p80211item_uint32_t *) &msg.mibattribute.data; msg.msgcode = DIDmsg_dot11req_mibset;
@@ -85,7 +85,7 @@ static int prism2_domibset_uint32(wlandevice_t *wlandev, u32 did, u32 data)static int prism2_domibset_pstr32 (wlandevice_t *wlandev,u32 did,u8 len,u8 *data) { -p80211msg_dot11req_mibset_t msg; +struct p80211msg_dot11req_mibset msg;p80211item_pstr32_t *mibitem = (p80211item_pstr32_t *) &msg.mibattribute.data; msg.msgcode = DIDmsg_dot11req_mibset;
@@ -294,7 +294,7 @@ int prism2_get_station(struct wiphy *wiphy, struct net_device *dev, u8 *mac, struct station_info *sinfo) { wlandevice_t *wlandev = dev->ml_priv; -p80211msg_lnxreq_commsquality_t quality; +struct p80211msg_lnxreq_commsquality quality;int result;memset (sinfo,0 ,sizeof (*sinfo));
@@ -329,8 +329,8 @@ int prism2_scan(struct wiphy *wiphy, struct net_device *dev, {struct prism2_wiphy_private *priv =wiphy_priv (wiphy);wlandevice_t *wlandev = dev->ml_priv; -p80211msg_dot11req_scan_t msg1; -p80211msg_dot11req_scan_results_t msg2; +struct p80211msg_dot11req_scan msg1; +struct p80211msg_dot11req_scan_results msg2;int result;int err =0 ;int numbss =0 ;
@@ -351,7 +351,7 @@ int prism2_scan(struct wiphy *wiphy, struct net_device *dev, priv->scan_request = request; -memset (&msg1,0x00 ,sizeof (p80211msg_dot11req_scan_t)); +memset (&msg1,0x00 ,sizeof (struct p80211msg_dot11req_scan )); msg1.msgcode = DIDmsg_dot11req_scan; msg1.bsstype.data = P80211ENUM_bsstype_any;
@@ -468,7 +468,7 @@ int prism2_connect(struct wiphy *wiphy, struct net_device *dev, {wlandevice_t *wlandev = dev->ml_priv;struct ieee80211_channel *channel = sme->channel; -p80211msg_lnxreq_autojoin_t msg_join; +struct p80211msg_lnxreq_autojoin msg_join;u32 did;int length = sme->ssid_len;int chan =-1 ;
@@ -589,7 +589,7 @@ int prism2_disconnect(struct wiphy *wiphy, struct net_device *dev, u16 reason_code) {wlandevice_t *wlandev = dev->ml_priv; -p80211msg_lnxreq_autojoin_t msg_join; +struct p80211msg_lnxreq_autojoin msg_join;int result;int err =0 ;
@@ -652,7 +652,7 @@ int prism2_get_tx_power(struct wiphy *wiphy, int *dbm) {struct prism2_wiphy_private *priv =wiphy_priv (wiphy);wlandevice_t *wlandev = priv->wlandev; -p80211msg_dot11req_mibget_t msg; +struct p80211msg_dot11req_mibget msg;p80211item_uint32_t *mibitem = (p80211item_uint32_t *) &msg.mibattribute.data;int result;int err =0 ;
drivers/staging/wlan-ng/p80211meta.h +8 -8
@@ -62,7 +62,7 @@/* representation of category list metadata, group list metadata, */ /* and data item metadata for both Mib and Messages. */ -typedef struct p80211meta { +struct p80211meta {char *name;/* data item name */ u32 did;/* partial did */ u32 flags;/* set of various flag bits */
@@ -75,16 +75,16 @@ typedef struct p80211meta {p80211_totext_t totextptr;/* ptr to totext conversion function */ p80211_fromtext_t fromtextptr;/* ptr to totext conversion function */ p80211_valid_t validfunptr; /* ptr to totext conversion function */ -} p80211meta_t; +}; -typedef struct grplistitem { +struct grplistitem {char *name; -p80211meta_t *itemlist; -}grplistitem_t ; +struct p80211meta *itemlist; +}; -typedef struct catlistitem { +struct catlistitem {char *name; -grplistitem_t *grplist; -}catlistitem_t ; +struct grplistitem *grplist; +};#endif /* _P80211META_H */
drivers/staging/wlan-ng/p80211metastruct.h +30 -30
164 lines not on this page · raw message
drivers/staging/wlan-ng/p80211netdev.c +5 -4
@@ -607,7 +607,8 @@ static int p80211knetdev_do_ioctl(netdevice_t *dev, struct ifreq *ifr, int cmd) result = -ENOMEM ; } bail: -return result;/* If allocate,copyfrom or copyto fails, return errno */ +/* If allocate,copyfrom or copyto fails, return errno */ +return result; }/*----------------------------------------------------------------
@@ -638,7 +639,7 @@ bail:static int p80211knetdev_set_mac_address (netdevice_t *dev,void *addr) {struct sockaddr *new_addr = addr; -p80211msg_dot11req_mibset_t dot11req; +struct p80211msg_dot11req_mibset dot11req;p80211item_unk392_t *mibattr;p80211item_pstr6_t *macaddr;p80211item_uint32_t *resultcode;
@@ -654,9 +655,9 @@ static int p80211knetdev_set_mac_address(netdevice_t *dev, void *addr) resultcode = &dot11req.resultcode;/* Set up a dot11req_mibset */ -memset (&dot11req,0 ,sizeof (p80211msg_dot11req_mibset_t)); +memset (&dot11req,0 ,sizeof (struct p80211msg_dot11req_mibset )); dot11req.msgcode = DIDmsg_dot11req_mibset; - dot11req.msglen =sizeof (p80211msg_dot11req_mibset_t); + dot11req.msglen =sizeof (struct p80211msg_dot11req_mibset );memcpy (dot11req.devname, ((wlandevice_t *) dev->ml_priv)->name,WLAN_DEVNAMELEN_MAX -1 );
drivers/staging/wlan-ng/p80211req.c +6 -6
@@ -74,7 +74,7 @@static void p80211req_handlemsg (wlandevice_t *wlandev,p80211msg_t *msg);static int p80211req_mibset_mibget (wlandevice_t *wlandev, -p80211msg_dot11req_mibget_t *mib_msg, +struct p80211msg_dot11req_mibget *mib_msg,int isget);/*----------------------------------------------------------------
@@ -155,8 +155,8 @@ static void p80211req_handlemsg(wlandevice_t *wlandev, p80211msg_t *msg)switch (msg->msgcode) {case DIDmsg_lnxreq_hostwep:{ -p80211msg_lnxreq_hostwep_t *req = - (p80211msg_lnxreq_hostwep_t *) msg; +struct p80211msg_lnxreq_hostwep *req = + (struct p80211msg_lnxreq_hostwep *) msg; wlandev->hostwep &= ~(HOSTWEP_DECRYPT |HOSTWEP_ENCRYPT );if (req->decrypt.data == P80211ENUM_truth_true)
@@ -169,8 +169,8 @@ static void p80211req_handlemsg(wlandevice_t *wlandev, p80211msg_t *msg)case DIDmsg_dot11req_mibget:case DIDmsg_dot11req_mibset:{int isget = (msg->msgcode == DIDmsg_dot11req_mibget); -p80211msg_dot11req_mibget_t *mib_msg = - (p80211msg_dot11req_mibget_t *) msg; +struct p80211msg_dot11req_mibget *mib_msg = + (struct p80211msg_dot11req_mibget *) msg;p80211req_mibset_mibget (wlandev, mib_msg, isget); }default :
@@ -181,7 +181,7 @@ static void p80211req_handlemsg(wlandevice_t *wlandev, p80211msg_t *msg) }static int p80211req_mibset_mibget (wlandevice_t *wlandev, -p80211msg_dot11req_mibget_t *mib_msg, +struct p80211msg_dot11req_mibget *mib_msg,int isget) {p80211itemd_t *mibitem = (p80211itemd_t *) mib_msg->mibattribute.data;
drivers/staging/wlan-ng/prism2fw.c +4 -4
@@ -239,7 +239,7 @@ int prism2_fwtry(struct usb_device *udev, wlandevice_t *wlandev)int prism2_fwapply (const struct ihex_binrec *rfptr,wlandevice_t *wlandev) {signed int result =0 ; -p80211msg_dot11req_mibget_t getmsg; +struct p80211msg_dot11req_mibget getmsg;p80211itemd_t *item;u32 *data;
@@ -766,7 +766,7 @@ int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,int read_cardpda (struct pda *pda,wlandevice_t *wlandev) {int result =0 ; -p80211msg_p2req_readpda_t msg; +struct p80211msg_p2req_readpda msg;/* set up the msg */ msg.msgcode = DIDmsg_p2req_readpda;
@@ -981,8 +981,8 @@ int writeimage(wlandevice_t *wlandev, struct imgchunk *fchunk, unsigned int nfchunks) {int result =0 ; -p80211msg_p2req_ramdl_state_t rstatemsg; -p80211msg_p2req_ramdl_write_t rwritemsg; +struct p80211msg_p2req_ramdl_state rstatemsg; +struct p80211msg_p2req_ramdl_write rwritemsg;p80211msg_t *msgp;u32 resultcode;int i;
drivers/staging/wlan-ng/prism2mgmt.c +11 -11
@@ -117,7 +117,7 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp) {int result =0 ;hfa384x_t *hw = wlandev->priv; -p80211msg_dot11req_scan_t *msg = msgp; +struct p80211msg_dot11req_scan *msg = msgp;u16 roamingmode, word;int i, timeout;int istmpenable =0 ;
@@ -361,13 +361,13 @@ exit:int prism2mgmt_scan_results (wlandevice_t *wlandev,void *msgp) {int result =0 ; -p80211msg_dot11req_scan_results_t *req; +struct p80211msg_dot11req_scan_results *req;hfa384x_t *hw = wlandev->priv;hfa384x_HScanResultSub_t *item =NULL ;int count; - req = (p80211msg_dot11req_scan_results_t *) msgp; + req = (struct p80211msg_dot11req_scan_results *) msgp; req->resultcode.status = P80211ENUM_msgitem_status_data_ok;
@@ -513,7 +513,7 @@ int prism2mgmt_start(wlandevice_t *wlandev, void *msgp) {int result =0 ;hfa384x_t *hw = wlandev->priv; -p80211msg_dot11req_start_t *msg = msgp; +struct p80211msg_dot11req_start *msg = msgp;p80211pstrd_t *pstr;u8 bytebuf[80 ];
@@ -689,7 +689,7 @@ done:int prism2mgmt_readpda (wlandevice_t *wlandev,void *msgp) {hfa384x_t *hw = wlandev->priv; -p80211msg_p2req_readpda_t *msg = msgp; +struct p80211msg_p2req_readpda *msg = msgp;int result;/* We only support collecting the PDA when in the FWLOAD
@@ -755,7 +755,7 @@ int prism2mgmt_readpda(wlandevice_t *wlandev, void *msgp)int prism2mgmt_ramdl_state (wlandevice_t *wlandev,void *msgp) {hfa384x_t *hw = wlandev->priv; -p80211msg_p2req_ramdl_state_t *msg = msgp; +struct p80211msg_p2req_ramdl_state *msg = msgp;if (wlandev->msdstate !=WLAN_MSD_FWLOAD ) { printk(KERN_ERR
@@ -811,7 +811,7 @@ int prism2mgmt_ramdl_state(wlandevice_t *wlandev, void *msgp)int prism2mgmt_ramdl_write (wlandevice_t *wlandev,void *msgp) {hfa384x_t *hw = wlandev->priv; -p80211msg_p2req_ramdl_write_t *msg = msgp; +struct p80211msg_p2req_ramdl_write *msg = msgp;u32 addr;u32 len;u8 *buf;
@@ -874,7 +874,7 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp) {int result =0 ;hfa384x_t *hw = wlandev->priv; -p80211msg_p2req_flashdl_state_t *msg = msgp; +struct p80211msg_p2req_flashdl_state *msg = msgp;if (wlandev->msdstate !=WLAN_MSD_FWLOAD ) { printk(KERN_ERR
@@ -944,7 +944,7 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp)int prism2mgmt_flashdl_write (wlandevice_t *wlandev,void *msgp) {hfa384x_t *hw = wlandev->priv; -p80211msg_p2req_flashdl_write_t *msg = msgp; +struct p80211msg_p2req_flashdl_write *msg = msgp;u32 addr;u32 len;u8 *buf;
@@ -1008,7 +1008,7 @@ int prism2mgmt_autojoin(wlandevice_t *wlandev, void *msgp)int result =0 ;u16 reg;u16 port_type; -p80211msg_lnxreq_autojoin_t *msg = msgp; +struct p80211msg_lnxreq_autojoin *msg = msgp;p80211pstrd_t *pstr;u8 bytebuf[256 ];hfa384x_bytestr_t *p2bytestr = (hfa384x_bytestr_t *) bytebuf;
@@ -1076,7 +1076,7 @@ int prism2mgmt_autojoin(wlandevice_t *wlandev, void *msgp)int prism2mgmt_wlansniff (wlandevice_t *wlandev,void *msgp) {int result =0 ; -p80211msg_lnxreq_wlansniff_t *msg = msgp; +struct p80211msg_lnxreq_wlansniff *msg = msgp;hfa384x_t *hw = wlandev->priv;u16 word;
drivers/staging/wlan-ng/prism2mib.c +38 -38
207 lines not on this page · raw message
drivers/staging/wlan-ng/prism2sta.c +8 -7
@@ -366,9 +366,9 @@ static int prism2sta_mlmerequest(wlandevice_t *wlandev, p80211msg_t *msg)break ;/* ignore me. */ case DIDmsg_lnxreq_ifstate: { -p80211msg_lnxreq_ifstate_t *ifstatemsg; +struct p80211msg_lnxreq_ifstate *ifstatemsg;pr_debug ("Received mlme ifstate request\n" ); - ifstatemsg = (p80211msg_lnxreq_ifstate_t *) msg; + ifstatemsg = (struct p80211msg_lnxreq_ifstate *) msg; result =prism2sta_ifstate (wlandev, ifstatemsg->ifstate.data);
@@ -387,11 +387,11 @@ static int prism2sta_mlmerequest(wlandevice_t *wlandev, p80211msg_t *msg) result =prism2mgmt_autojoin (wlandev, msg);break ;case DIDmsg_lnxreq_commsquality:{ -p80211msg_lnxreq_commsquality_t *qualmsg; +struct p80211msg_lnxreq_commsquality *qualmsg;pr_debug ("Received commsquality request\n" ); - qualmsg = (p80211msg_lnxreq_commsquality_t *) msg; + qualmsg = (struct p80211msg_lnxreq_commsquality *) msg; qualmsg->link.status = P80211ENUM_msgitem_status_data_ok;
@@ -1987,8 +1987,9 @@ void prism2sta_commsqual_defer(struct work_struct *data) hfa384x_t *hw = container_of(data, struct hfa384x, commsqual_bh);wlandevice_t *wlandev = hw->wlandev;hfa384x_bytestr32_t ssid; -p80211msg_dot11req_mibget_t msg; -p80211item_uint32_t *mibitem = (p80211item_uint32_t *) &msg.mibattribute.data; +struct p80211msg_dot11req_mibget msg; +p80211item_uint32_t *mibitem = (p80211item_uint32_t *) + &msg.mibattribute.data;int result =0 ;if (hw->wlandev->hwremoved)
@@ -2020,7 +2021,7 @@ void prism2sta_commsqual_defer(struct work_struct *data)/* Get the signal rate */ msg.msgcode = DIDmsg_dot11req_mibget; mibitem->did = DIDmib_p2_p2MAC_p2CurrentTxRate; - result =p80211req_dorequest (wlandev, (u8 *) & msg); + result =p80211req_dorequest (wlandev, (u8 *) &msg);if (result) { pr_debug("get signal rate failed, result = %d\n",
Signature · 1 line
1.7.0.4